hadoop aeecfa24f4fb6af289920cbf8830c394e66bd78e

aeecfa24f4fb6af289920cbf8830c394e66bd78e

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 20

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	2
Merge Attribute [blockInFd : FileDescriptor, blockIn : InputStream, volumeRef : FsVolumeReference, checksumIn : DataInputStream] to ris : ReplicaInputStreams in class org.apache.hadoop.hdfs.server.datanode.BlockSender	From	To
Merge Attribute [out : OutputStream, outFd : FileDescriptor] to streams : ReplicaOutputStreams in class org.apache.hadoop.hdfs.server.datanode.BlockReceiver	From	To
Change Parameter Type	4
Change Parameter Type fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.SimulatedFSDataset	From	To
Change Parameter Type fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.FsDatasetSpi	From	To
Change Parameter Type fd : FileDescriptor to streams : ReplicaOutputStreams in method public submitSyncFileRangeRequest(volume FsVolumeImpl, streams ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetAsyncDiskService	From	To
Change Parameter Type fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl	From	To
Rename Variable	1
Rename Variable localReplica : LocalReplica to oldReplica : LocalReplica in method public moveReplicaFrom(oldReplicaInfo ReplicaInfo, newBlkFile File) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplicaInPipeline	From	To
Move Attribute	1
Move Attribute private outFd : FileDescriptor from class org.apache.hadoop.hdfs.server.datanode.BlockReceiver to private outFd : FileDescriptor from class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaOutputStreams	From	To
Parameterize Variable	3
Parameterize Variable p : Path to path : Path in method public setPinning(localFS LocalFileSystem, path Path) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Parameterize Variable tmpFile : File to src : File in method private replaceFile(src File, target File) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Parameterize Variable file : File to fileName : File in method public getHardLinkCount(fileName File) : int in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method	7
Extract Method public setPinning(localFS LocalFileSystem, path Path) : void extracted from public setPinning(localFS LocalFileSystem) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method private nativeCopyFileUnbuffered(srcFile File, destFile File, preserveFileDate boolean) : void extracted from public copyMetadata(destination URI) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method private replaceFile(src File, target File) : void extracted from private breakHardlinks(file File, b Block) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method private copyBytes(in InputStream, out OutputStream, buffSize int) : void extracted from private breakHardlinks(file File, b Block) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method private nativeCopyFileUnbuffered(srcFile File, destFile File, preserveFileDate boolean) : void extracted from public copyBlockdata(destination URI) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method public getHardLinkCount(fileName File) : int extracted from public breakHardLinksIfNeeded() : boolean in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract Method private getDataInputStream(f File, seekOffset long) : FileInputStream extracted from public getDataInputStream(seekOffset long) : InputStream in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Change Attribute Type	1
Change Attribute Type LOG : Log to LOG : Logger in class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Inline Variable	2
Inline Variable blockFile : File in method public getDataInputStream(seekOffset long) : InputStream from class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Inline Variable ioe : IOException in method public close() : void from class org.apache.hadoop.hdfs.server.datanode.BlockSender	From	To
Extract And Move Method	12
Extract And Move Method public readDataFully(buf byte[], off int, len int) : void extracted from private sendPacket(pkt ByteBuffer, maxChunks int, out OutputStream, transferTo boolean, throttler DataTransferThrottler) : int in class org.apache.hadoop.hdfs.server.datanode.BlockSender & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Extract And Move Method public closeChecksumStream() : void extracted from private readChecksum(buf byte[], checksumOffset int, checksumLen int) : void in class org.apache.hadoop.hdfs.server.datanode.BlockSender & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Extract And Move Method public closeStreams() : void extracted from public close() : void in class org.apache.hadoop.hdfs.server.datanode.BlockSender & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Extract And Move Method public renameBlock(newBlockFile File) : void extracted from public moveReplicaFrom(oldReplicaInfo ReplicaInfo, newBlkFile File) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplicaInPipeline & moved to class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract And Move Method public writeToDisk(b byte[], off int, len int) : long extracted from private receivePacket() : int in class org.apache.hadoop.hdfs.server.datanode.BlockReceiver & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaOutputStreams	From	To
Extract And Move Method public dropCacheBehindWrites(identifier String, offset long, len long, flags int) : void extracted from private manageWriterOsCache(offsetInBlock long) : void in class org.apache.hadoop.hdfs.server.datanode.BlockReceiver & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaOutputStreams	From	To
Extract And Move Method public closeDataStream() : void extracted from public close() : void in class org.apache.hadoop.hdfs.server.datanode.BlockReceiver & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaOutputStreams	From	To
Extract And Move Method public renameMeta(newMetaFile File) : void extracted from public moveReplicaFrom(oldReplicaInfo ReplicaInfo, newBlkFile File) : void in class org.apache.hadoop.hdfs.server.datanode.LocalReplicaInPipeline & moved to class org.apache.hadoop.hdfs.server.datanode.LocalReplica	From	To
Extract And Move Method public skipDataFully(len long) : void extracted from private validateIntegrityAndSetLength(blockFile File, genStamp long) : long in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Extract And Move Method public readDataFully(buf byte[], off int, len int) : void extracted from private validateIntegrityAndSetLength(blockFile File, genStamp long) : long in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Extract And Move Method public syncFileRangeIfPossible(offset long, nbytes long, flags int) : void extracted from private manageWriterOsCache(offsetInBlock long) : void in class org.apache.hadoop.hdfs.server.datanode.BlockReceiver & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaOutputStreams	From	To
Extract And Move Method public skipChecksumFully(len long) : void extracted from private validateIntegrityAndSetLength(blockFile File, genStamp long) : long in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.BlockPoolSlice & moved to class org.apache.hadoop.hdfs.server.datanode.fsdataset.ReplicaInputStreams	From	To
Rename Parameter	4
Rename Parameter fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.SimulatedFSDataset	From	To
Rename Parameter fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.FsDatasetSpi	From	To
Rename Parameter fd : FileDescriptor to streams : ReplicaOutputStreams in method public submitSyncFileRangeRequest(volume FsVolumeImpl, streams ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetAsyncDiskService	From	To
Rename Parameter fd : FileDescriptor to outs : ReplicaOutputStreams in method public submitBackgroundSyncFileRangeRequest(block ExtendedBlock, outs ReplicaOutputStreams, offset long, nbytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl	From	To

aeecfa24f4fb6af289920cbf8830c394e66bd78e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: