hadoop b4031a8f1b2c81249ec24167e38679a775c09214

b4031a8f1b2c81249ec24167e38679a775c09214

Files Diff

Added: 1
Removed: 0
Renamed: 0
Modified: 42

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public setPipelineName(pipelineName String) : Builder renamed to public setPipelineID(pipelineID PipelineID) : Builder in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo.Builder	From	To
Rename Method public testCloseContainerViaStandaAlone() : void renamed to public testCloseContainerViaStandAlone() : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline	From	To
Change Parameter Type	17
Change Parameter Type pipelineName : String to id : PipelineID in method public getPipeline(id PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager	From	To
Change Parameter Type request : ContainerProtos.ContainerCommandRequestProto to request : ContainerCommandRequestProto in method public submitRequest(request ContainerCommandRequestProto, pipelineID HddsProtos.PipelineID) : void in class org.apache.hadoop.ozone.container.common.transport.server.XceiverServer	From	To
Change Parameter Type pipelineID : String to pipelineID : PipelineID in method public abstract getMembers(pipelineID PipelineID) : List<DatanodeDetails> in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager	From	To
Change Parameter Type request : ContainerProtos.ContainerCommandRequestProto to request : ContainerCommandRequestProto in method public submitRequest(request ContainerCommandRequestProto, pipelineID HddsProtos.PipelineID) : void in class org.apache.hadoop.ozone.container.common.transport.server.XceiverServerGrpc	From	To
Change Parameter Type pipelineName : String to pipelineID : PipelineID in method package ContainerInfo(containerID long, state HddsProtos.LifeCycleState, pipelineID PipelineID, allocatedBytes long, usedBytes long, numberOfKeys long, stateEnterTime long, owner String, deleteTransactionId long, replicationFactor ReplicationFactor, repType ReplicationType) in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo	From	To
Change Parameter Type pipelineID : String to pipelineID : PipelineID in method public getDatanodes(replicationType ReplicationType, pipelineID PipelineID) : List<DatanodeDetails> in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Change Parameter Type pipeline : String to pipelineID : PipelineID in method public getOpenContainerIDsByPipeline(pipelineID PipelineID) : NavigableSet<ContainerID> in class org.apache.hadoop.hdds.scm.container.states.ContainerStateMap	From	To
Change Parameter Type pipelineID : String to pipelineID : PipelineID in method public getMembers(pipelineID PipelineID) : List<DatanodeDetails> in class org.apache.hadoop.hdds.scm.pipelines.standalone.StandaloneManagerImpl	From	To
Change Parameter Type request : ContainerProtos.ContainerCommandRequestProto to request : ContainerCommandRequestProto in method public submitRequest(request ContainerCommandRequestProto, pipelineID HddsProtos.PipelineID) : void in class org.apache.hadoop.ozone.container.common.transport.server.ratis.XceiverServerRatis	From	To
Change Parameter Type pipelineName : String to pipelineID : PipelineID in method public getPipeline(pipelineID PipelineID, replicationType ReplicationType) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Change Parameter Type pipelineName : String to pipelineID : PipelineID in method public setPipelineID(pipelineID PipelineID) : Builder in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo.Builder	From	To
Change Parameter Type request : ContainerProtos.ContainerCommandRequestProto to request : ContainerCommandRequestProto in method public submitRequest(request ContainerCommandRequestProto, pipelineID HddsProtos.PipelineID) : void in class org.apache.hadoop.ozone.container.common.transport.server.XceiverServerSpi	From	To
Change Parameter Type pipelineID : String to pipelineID : PipelineID in method public updateDatanodes(replicationType ReplicationType, pipelineID PipelineID, newDatanodes List<DatanodeDetails>) : void in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Change Parameter Type pipeline : String to pipelineID : PipelineID in method public getMatchingContainerIDsByPipeline(pipelineID PipelineID) : NavigableSet<ContainerID> in class org.apache.hadoop.hdds.scm.container.ContainerStateManager	From	To
Change Parameter Type name : String to id : PipelineID in method public Pipeline(leaderID String, lifeCycleState HddsProtos.LifeCycleState, replicationType HddsProtos.ReplicationType, replicationFactor HddsProtos.ReplicationFactor, id PipelineID) in class org.apache.hadoop.hdds.scm.container.common.helpers.Pipeline	From	To
Change Parameter Type name : String to id : PipelineID in method public newPipelineFromNodes(nodes List<DatanodeDetails>, replicationType ReplicationType, replicationFactor ReplicationFactor, id PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Change Parameter Type pipelineID : String to pipelineID : PipelineID in method public getMembers(pipelineID PipelineID) : List<DatanodeDetails> in class org.apache.hadoop.hdds.scm.pipelines.ratis.RatisManagerImpl	From	To
Rename Variable	2
Rename Variable pipelineName : String to pipelineID : PipelineID in method public allocatePipeline(factor ReplicationFactor) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.ratis.RatisManagerImpl	From	To
Rename Variable pipelineName : String to pipelineID : PipelineID in method public allocatePipeline(factor ReplicationFactor) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.standalone.StandaloneManagerImpl	From	To
Merge Parameter	1
Merge Parameter [datanodes : List<DatanodeDetails>, clusterId : String] to pipeline : Pipeline in method public createPipeline(pipeline Pipeline) : void in class org.apache.hadoop.hdds.scm.XceiverClientRatis	From	To
Rename Attribute	2
Rename Attribute pipelineName : String to pipelineID : PipelineID in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo	From	To
Rename Attribute pipelineName : String to pipelineID : PipelineID in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo.Builder	From	To
Extract Variable	3
Extract Variable pipeline : Pipeline in method public testCloseContainerViaRatis() : void from class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline	From	To
Extract Variable pipeline : Pipeline in method public testIfCloseContainerCommandHandlerIsInvoked() : void from class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline	From	To
Extract Variable pipeline : Pipeline in method public testCloseContainerViaStandAlone() : void from class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline	From	To
Change Variable Type	2
Change Variable Type pipelineName : String to pipelineID : PipelineID in method public allocatePipeline(factor ReplicationFactor) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.standalone.StandaloneManagerImpl	From	To
Change Variable Type pipelineName : String to pipelineID : PipelineID in method public allocatePipeline(factor ReplicationFactor) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.ratis.RatisManagerImpl	From	To
Extract Method	1
Extract Method private createRaftClientRequest(request ContainerCommandRequestProto, pipelineID HddsProtos.PipelineID, type RaftClientRequest.Type) : RaftClientRequest extracted from public submitRequest(request ContainerProtos.ContainerCommandRequestProto) : void in class org.apache.hadoop.ozone.container.common.transport.server.ratis.XceiverServerRatis	From	To
Change Attribute Type	5
Change Attribute Type pipelineMap : Map<String,Pipeline> to pipelineMap : Map<PipelineID,Pipeline> in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager	From	To
Change Attribute Type activePipelines : List<Pipeline> to activePipelines : List<PipelineID> in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager	From	To
Change Attribute Type pipelineName : String to pipelineID : PipelineID in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo.Builder	From	To
Change Attribute Type openPipelineMap : ContainerAttribute<String> to openPipelineMap : ContainerAttribute<PipelineID> in class org.apache.hadoop.hdds.scm.container.states.ContainerStateMap	From	To
Change Attribute Type pipelineName : String to pipelineID : PipelineID in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo	From	To
Rename Parameter	8
Rename Parameter pipeline : String to pipelineID : PipelineID in method public getOpenContainerIDsByPipeline(pipelineID PipelineID) : NavigableSet<ContainerID> in class org.apache.hadoop.hdds.scm.container.states.ContainerStateMap	From	To
Rename Parameter name : String to id : PipelineID in method public newPipelineFromNodes(nodes List<DatanodeDetails>, replicationType ReplicationType, replicationFactor ReplicationFactor, id PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Rename Parameter pipelineName : String to pipelineID : PipelineID in method public getPipeline(pipelineID PipelineID, replicationType ReplicationType) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector	From	To
Rename Parameter pipelineName : String to pipelineID : PipelineID in method public setPipelineID(pipelineID PipelineID) : Builder in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo.Builder	From	To
Rename Parameter pipelineName : String to id : PipelineID in method public getPipeline(id PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager	From	To
Rename Parameter pipeline : String to pipelineID : PipelineID in method public getMatchingContainerIDsByPipeline(pipelineID PipelineID) : NavigableSet<ContainerID> in class org.apache.hadoop.hdds.scm.container.ContainerStateManager	From	To
Rename Parameter name : String to id : PipelineID in method public Pipeline(leaderID String, lifeCycleState HddsProtos.LifeCycleState, replicationType HddsProtos.ReplicationType, replicationFactor HddsProtos.ReplicationFactor, id PipelineID) in class org.apache.hadoop.hdds.scm.container.common.helpers.Pipeline	From	To
Rename Parameter pipelineName : String to pipelineID : PipelineID in method package ContainerInfo(containerID long, state HddsProtos.LifeCycleState, pipelineID PipelineID, allocatedBytes long, usedBytes long, numberOfKeys long, stateEnterTime long, owner String, deleteTransactionId long, replicationFactor ReplicationFactor, repType ReplicationType) in class org.apache.hadoop.hdds.scm.container.common.helpers.ContainerInfo	From	To

b4031a8f1b2c81249ec24167e38679a775c09214

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: