b507f83e15b47163724d550dfeb41627f26fd551
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public createContainerFile(containerType ContainerProtos.ContainerType, containerFile File, containerData ContainerData) : void renamed to public getYamlForContainerType(containerType ContainerType) : Yaml in class org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public computeCheckSum(containerId long, containerFile File) : String from class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerUtil to public getChecksum(containerDataYamlStr String) : String from class org.apache.hadoop.ozone.container.common.helpers.ContainerUtils | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type containerType : ContainerProtos.ContainerType to containerType : ContainerType in method public getYamlForContainerType(containerType ContainerType) : Yaml in class org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml | From | To | |
| Change Parameter Type containerName : String to containerID : long in method public getContainerDBFile(containerMetaDataPath File, containerID long) : File in class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerLocationUtil | From | To | |
| Change Parameter Type containerName : String to containerID : long in method public getContainerFile(containerMetaDataPath File, containerID long) : File in class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerLocationUtil | From | To | |
| Rename Variable | 5 | ||
| Rename Variable path : String to containerID : long in method public testCreateContainerFile() : void in class org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Rename Variable keyValueContainer : KeyValueContainer to kvContainer : KeyValueContainer in method public verifyContainerData(containerData ContainerData) : void in class org.apache.hadoop.ozone.container.ozoneimpl.ContainerReader | From | To | |
| Rename Variable path : String to containerFile : String in method public testIncorrectContainerFile() : void in class org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Rename Variable containerName : String to containerID : long in method public readVolume(hddsVolumeRootDir File) : void in class org.apache.hadoop.ozone.container.ozoneimpl.ContainerReader | From | To | |
| Rename Variable path : String to containerFile : String in method public testCheckBackWardCompatabilityOfContainerFile() : void in class org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute private YAML_FIELDS : List<String> from class org.apache.hadoop.ozone.container.keyvalue.KeyValueContainerData to protected YAML_FIELDS : List<String> from class org.apache.hadoop.ozone.container.common.impl.ContainerData | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to Yaml in method public getYamlForContainerType(containerType ContainerType) : Yaml in class org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml | From | To | |
| Change Return Type ContainerProtos.ContainerType to ContainerType in method public getContainerType() : ContainerType in class org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute containerName : String to containerID : long in class org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainer | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type path : String to containerID : long in method public testCreateContainerFile() : void in class org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Change Variable Type containerName : String to containerID : long in method public readVolume(hddsVolumeRootDir File) : void in class org.apache.hadoop.ozone.container.ozoneimpl.ContainerReader | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type containerName : String to containerID : long in class org.apache.hadoop.ozone.container.keyvalue.TestKeyValueContainer | From | To | |
| Extract Method | 2 | ||
| Extract Method public verifyContainerData(containerData ContainerData) : void extracted from private verifyContainerFile(containerName String, containerFile File, checksumFile File) : void in class org.apache.hadoop.ozone.container.ozoneimpl.ContainerReader | From | To | |
| Extract Method private createContainerFile(containerID long) : File extracted from public testCreateContainerFile() : void in class org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter containerName : String to containerID : long in method public getContainerDBFile(containerMetaDataPath File, containerID long) : File in class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerLocationUtil | From | To | |
| Rename Parameter containerName : String to containerID : long in method public getContainerFile(containerMetaDataPath File, containerID long) : File in class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerLocationUtil | From | To |