hadoop b61fb267b92b2736920b4bd0c673d31e7632ebb9

b61fb267b92b2736920b4bd0c673d31e7632ebb9

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 23

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	5
Rename Method private findDecommissioningSources() : List<Integer> renamed to private findLeavingServiceSources() : List<Integer> in class org.apache.hadoop.hdfs.server.blockmanagement.ErasureCodingWork	From	To
Rename Method private processBlocksForDecomInternal(datanode DatanodeDescriptor, it Iterator<BlockInfo>, insufficientList List<BlockInfo>, pruneReliableBlocks boolean) : void renamed to private processBlocksInternal(datanode DatanodeDescriptor, it Iterator<BlockInfo>, insufficientList List<BlockInfo>, pruneReliableBlocks boolean) : void in class org.apache.hadoop.hdfs.server.blockmanagement.DecommissionManager.Monitor	From	To
Rename Method package processExtraRedundancyBlocksOnReCommission(srcNode DatanodeDescriptor) : void renamed to package processExtraRedundancyBlocksOnInService(srcNode DatanodeDescriptor) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Method public getDecommissionOnlyReplicas() : int renamed to public getOutOfServiceOnlyReplicas() : int in class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor.LeavingServiceStatus	From	To
Rename Method package isNodeHealthyForDecommission(node DatanodeDescriptor) : boolean renamed to package isNodeHealthyForDecommissionOrMaintenance(node DatanodeDescriptor) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Inline Method	4
Inline Method private getRedundancy(block BlockInfo) : int inlined to package processExtraRedundancyBlocksOnInService(srcNode DatanodeDescriptor) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Inline Method private getRedundancy(block BlockInfo) : int inlined to private updateNeededReconstructions(block BlockInfo, curReplicasDelta int, expectedReplicasDelta int) : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Variable	14
Rename Variable file1 : Path to file : Path in method public testTransitionFromDecommissioned() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable decomm : int to adminOps : int in method public testXceiverCountInternal(minMaintenanceR int) : void in class org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport	From	To
Rename Variable file1 : Path to file : Path in method public testNodeDeadWhenInEnteringMaintenance() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable requiredRedundancy : short to expectedRedundancy : short in method public getExpectedLiveRedundancyNum(block BlockInfo, numberReplicas NumberReplicas) : short in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Variable file1 : Path to file : Path in method public testPutDeadNodeToMaintenanceWithExpiration() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable file1 : Path to file : Path in method public testInvalidExpiration() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable file1 : Path to file : Path in method public testTakeNodeOutOfEnteringMaintenance() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable decommissioningSources : List<Integer> to leavingServiceSources : List<Integer> in method package addTaskToDatanode(numberReplicas NumberReplicas) : void in class org.apache.hadoop.hdfs.server.blockmanagement.ErasureCodingWork	From	To
Rename Variable file1 : Path to file : Path in method public testTransitionFromDecommissionedAndExpired() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable file1 : Path to file : Path in method public testPutDeadNodeToMaintenance() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable file1 : Path to file : Path in method public testEnteringMaintenanceExpiration() : void in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Rename Variable decommissioned : boolean to outOfService : boolean in method private shouldIgnore(dn DatanodeInfo) : boolean in class org.apache.hadoop.hdfs.server.balancer.Dispatcher	From	To
Rename Variable decommissionOnlyReplicas : int to outOfServiceOnlyReplicas : int in method private processBlocksInternal(datanode DatanodeDescriptor, it Iterator<BlockInfo>, insufficientList List<BlockInfo>, pruneReliableBlocks boolean) : void in class org.apache.hadoop.hdfs.server.blockmanagement.DecommissionManager.Monitor	From	To
Rename Class	2
Rename Class org.apache.hadoop.hdfs.DFSUtil.DecomStaleComparator renamed to org.apache.hadoop.hdfs.DFSUtil.ServiceAndStaleComparator	From	To
Rename Class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor.DecommissioningStatus renamed to org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor.LeavingServiceStatus	From	To
Parameterize Variable	2
Parameterize Variable bi : BlockInfo to storedBlock : BlockInfo in method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Parameterize Variable num : NumberReplicas to numberReplicas : NumberReplicas in method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Extract Superclass	1
Extract Superclass org.apache.hadoop.hdfs.DFSUtil.ServiceComparator from classes [org.apache.hadoop.hdfs.DFSUtil.ServiceAndStaleComparator]	From	To
Rename Attribute	1
Rename Attribute decommissionOnlyReplicas : int to outOfServiceOnlyReplicas : int in class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeDescriptor.LeavingServiceStatus	From	To
Change Variable Type	1
Change Variable Type dead : DatanodeID to dead : DatanodeDescriptor in method package heartbeatCheck() : void in class org.apache.hadoop.hdfs.server.blockmanagement.HeartbeatManager	From	To
Change Attribute Type	1
Change Attribute Type LOG : Log to LOG : Logger in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Extract Method	9
Extract Method private startDecommissionOrMaintenance(dnm DatanodeManager, dnd DatanodeDescriptor, decomm boolean) : void extracted from public testXceiverCount() : void in class org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport	From	To
Extract Method public getExpectedLiveRedundancyNum(block BlockInfo, numberReplicas NumberReplicas) : short extracted from private scheduleReconstruction(block BlockInfo, priority int) : BlockReconstructionWork in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Extract Method private removeDatanode(nodeInfo DatanodeDescriptor, removeBlocksFromBlocksMap boolean) : void extracted from private removeDatanode(nodeInfo DatanodeDescriptor) : void in class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager	From	To
Extract Method public getExpectedLiveRedundancyNum(block BlockInfo, numberReplicas NumberReplicas) : short extracted from private validateReconstructionWork(rw BlockReconstructionWork) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Extract Method private stopDecommissionOrMaintenance(dnm DatanodeManager, dnd DatanodeDescriptor, decomm boolean) : void extracted from public testXceiverCount() : void in class org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport	From	To
Extract Method public testXceiverCountInternal(minMaintenanceR int) : void extracted from public testXceiverCount() : void in class org.apache.hadoop.hdfs.server.namenode.TestNamenodeCapacityReport	From	To
Extract Method private getFirstBlockReplicasDatanodeInfos(fileSys FileSystem, name Path) : DatanodeInfo[] extracted from protected getFirstBlockFirstReplicaUuid(fileSys FileSystem, name Path) : String in class org.apache.hadoop.hdfs.TestMaintenanceState	From	To
Extract Method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas) : boolean extracted from private processPendingReconstructions() : void in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Extract Method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas) : boolean extracted from private processMisReplicatedBlock(block BlockInfo) : MisReplicationResult in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Extract And Move Method	1
Extract And Move Method private setInMaintenance(dn DatanodeDescriptor) : void extracted from private check() : void in class org.apache.hadoop.hdfs.server.blockmanagement.DecommissionManager.Monitor & moved to class org.apache.hadoop.hdfs.server.blockmanagement.DecommissionManager	From	To
Rename Parameter	8
Rename Parameter decommissionedReplicas : int to outOfServiceReplicas : int in method private getPriorityStriped(curReplicas int, outOfServiceReplicas int, dataBlkNum short, parityBlkNum short) : int in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To
Rename Parameter decommissionedReplicas : int to outOfServiceReplicas : int in method private getPriority(block BlockInfo, curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, expectedReplicas int) : int in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To
Rename Parameter decommissionedReplicas : int to outOfServiceReplicas : int in method private getPriorityContiguous(curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, expectedReplicas int) : int in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To
Rename Parameter decommissionedReplicas : int to outOfServiceReplicas : int in method package remove(block BlockInfo, oldReplicas int, oldReadOnlyReplicas int, outOfServiceReplicas int, oldExpectedReplicas int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To
Rename Parameter block : BlockInfo to storedBlock : BlockInfo in method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Parameter current : int to pending : int in method package isNeededReconstruction(storedBlock BlockInfo, numberReplicas NumberReplicas, pending int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager	From	To
Rename Parameter decommissionedReplicas : int to outOfServiceReplicas : int in method package update(block BlockInfo, curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, curExpectedReplicas int, curReplicasDelta int, expectedReplicasDelta int) : void in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To
Rename Parameter decomissionedReplicas : int to outOfServiceReplicas : int in method package add(block BlockInfo, curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, expectedReplicas int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks	From	To

b61fb267b92b2736920b4bd0c673d31e7632ebb9

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: