b7bed9f00a25bcad6f9c3543f5a1fb0a1f23b0e9
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private addBlockMovingInfosToCoordinatorDn(blockCollectionID long, blockMovingInfos List<BlockMovingInfo>, coordinatorNode DatanodeDescriptor) : void renamed to private assignBlockMovingInfosToCoordinatorDn(blockCollectionID long, blockMovingInfos List<BlockMovingInfo>, coordinatorNode DatanodeDescriptor) : void in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type blockCollectionID : long to blockCollection : BlockCollection in method private computeAndAssignStorageMismatchedBlocksToDNs(blockCollection BlockCollection) : boolean in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To | |
| Move Method | 3 | ||
| Move Method private isExistInResult(blockCollectionID Long) : boolean from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems.BlocksStorageMovementAttemptResultMonitor to private isExistInResult(blockCollectionID Long) : boolean from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Move Method private blockStorageMovementResultCheck() : void from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems.BlocksStorageMovementAttemptResultMonitor to package blockStorageMovementResultCheck() : void from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Move Method private blocksStorageMovementUnReportedItemsCheck() : void from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems.BlocksStorageMovementAttemptResultMonitor to package blocksStorageMovementUnReportedItemsCheck() : void from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to boolean in method private computeAndAssignStorageMismatchedBlocksToDNs(blockCollection BlockCollection) : boolean in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To | |
| Change Return Type BlockMovingInfo to boolean in method private findSourceAndTargetToMove(blockMovingInfos List<BlockMovingInfo>, blockInfo BlockInfo, existing List<StorageType>, sourceWithStorageList List<StorageTypeNodePair>, expected List<StorageType>, locsForExpectedStorageTypes StorageTypeNodeMap) : boolean in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To | |
| Extract Attribute | 1 | ||
| Extract Attribute private selfRetryTimeout : int in class org.apache.hadoop.hdfs.server.namenode.TestBlockStorageMovementAttemptedItems | From | To | |
| Extract Method | 2 | ||
| Extract Method private writeContent(fileName String, replicatonFactor short) : void extracted from private writeContent(fileName String) : void in class org.apache.hadoop.hdfs.server.namenode.TestStoragePolicySatisfier | From | To | |
| Extract Method private computeBlockMovingInfos(blockMovingInfos List<BlockMovingInfo>, blockInfo BlockInfo, expectedStorageTypes List<StorageType>) : boolean extracted from private computeAndAssignStorageMismatchedBlocksToDNs(blockCollectionID long) : void in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type storageMovementAttemptedItems : Map<Long,Long> to storageMovementAttemptedItems : Map<Long,ItemInfo> in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter blockCollectionID : long to blockCollection : BlockCollection in method private computeAndAssignStorageMismatchedBlocksToDNs(blockCollection BlockCollection) : boolean in class org.apache.hadoop.hdfs.server.namenode.StoragePolicySatisfier | From | To |