c0929ab3c2de76e2d514b7dec11354fea40ea089
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public testWritePreadWithDNFailure1() : void renamed to public testReadWithDNFailure1() : void in class org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding | From | To | |
| Rename Method private testWritePreadWithDNFailure(file String, fileSize int, startOffsetInFile int) : void renamed to private testReadWithDNFailure(file String, fileSize int, startOffsetInFile int) : void in class org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding | From | To | |
| Rename Method public testWritePreadWithDNFailure2() : void renamed to public testReadWithDNFailure2() : void in class org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding | From | To | |
| Rename Method public testWritePreadWithDNFailure3() : void renamed to public testReadWithDNFailure3() : void in class org.apache.hadoop.hdfs.TestReadStripedFileWithDecoding | From | To | |
| Rename Method private copy(strategy ReaderStrategy, offset int, length int) : int renamed to private copyToTargetBuf(strategy ReaderStrategy, offset int, length int) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Method private readBuffer(blockReader BlockReader, currentNode DatanodeInfo, readerStrategy ByteBufferStrategy, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : int renamed to private readToBuffer(blockReader BlockReader, currentNode DatanodeInfo, readerStrategy ByteBufferStrategy, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method private fetchOneStripe(blockGroup LocatedStripedBlock, buf byte[], alignedStripe AlignedStripe, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream to package readStripe(blocks LocatedBlock[], corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream.StripeReader | From | To | |
| Move And Rename Method private fetchOneStripingChunk(futures Map<Future<Void>,Integer>, service CompletionService<Void>, block LocatedBlock, alignedStripe AlignedStripe, index int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream to package readChunk(service CompletionService<Void>, block LocatedBlock, chunkIndex int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream.PositionStripeReader | From | To | |
| Move Method | 2 | ||
| Move Method public getOffsets() : int[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk to public getOffsets() : int[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray | From | To | |
| Move Method public getLengths() : int[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk to public getLengths() : int[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Callable<Integer> to Callable<Void> in method private readCell(reader BlockReader, datanode DatanodeInfo, currentReaderOffset long, targetReaderOffset long, strategy ByteBufferStrategy, targetLength int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : Callable<Void> in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Move Attribute | 3 | ||
| Move Attribute public offsetsInBuf : List<Integer> from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk to private offsetsInBuf : List<Integer> from class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray | From | To | |
| Move Attribute public buf : byte[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk to private buf : byte[] from class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray | From | To | |
| Move Attribute public lengthsInBuf : List<Integer> from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk to private lengthsInBuf : List<Integer> from class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hdfs.util.StripedBlockUtil.ChunkByteArray from class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable i : int to index : int in method private closeReader(index int) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute buf : byte[] to byteBuffer : ByteBuffer in class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk | From | To | |
| Extract Method | 2 | ||
| Extract Method private closeReader(index int) : void extracted from protected closeCurrentBlockReaders() : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Extract Method private testOneFileUsingDFSStripedInputStream(src String, fileLength int, withDataNodeFailure boolean) : void extracted from private testOneFileUsingDFSStripedInputStream(src String, fileLength int) : void in class org.apache.hadoop.hdfs.TestWriteReadStripedFile | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type groupSize : short to groupSize : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Change Attribute Type readingService : CompletionService<Integer> to readingService : CompletionService<Void> in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Change Attribute Type buf : byte[] to byteBuffer : ByteBuffer in class org.apache.hadoop.hdfs.util.StripedBlockUtil.StripingChunk | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter index : int to chunkIndex : int in method package readChunk(service CompletionService<Void>, block LocatedBlock, chunkIndex int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream.PositionStripeReader | From | To |