c17521b1bdfcdf6b369f9c755bed136011e7e076
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 49
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private allocateContainers(count int) : List<String> renamed to private preAllocateContainers(count int, type ReplicationType, factor ReplicationFactor) : void in class org.apache.hadoop.ozone.scm.block.BlockManagerImpl | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type type : OzoneProtos.ReplicationType to type : ReplicationType in method public allocateContainer(type ReplicationType, replicationFactor ReplicationFactor, containerName String, owner Owner) : ContainerInfo in class org.apache.hadoop.ozone.scm.container.ContainerMapping | From | To | |
| Change Parameter Type replicationFactor : OzoneProtos.ReplicationFactor to replicationFactor : ReplicationFactor in method public allocateContainer(type ReplicationType, replicationFactor ReplicationFactor, containerName String, owner Owner) : ContainerInfo in class org.apache.hadoop.ozone.scm.container.ContainerMapping | From | To | |
| Move Method | 1 | ||
| Move Method private initializeStateMachine() : void from class org.apache.hadoop.ozone.scm.container.ContainerMapping to private initializeStateMachine() : void from class org.apache.hadoop.ozone.scm.container.ContainerStateManager | From | To | |
| Inline Method | 1 | ||
| Inline Method private newPipelineFromNodes(nodes List<DatanodeID>, containerName String) : Pipeline inlined to public getPipeline(containerName String, replicationFactor OzoneProtos.ReplicationFactor) : Pipeline in class org.apache.hadoop.ozone.scm.pipelines.standalone.StandaloneManagerImpl | From | To | |
| Rename Variable | 1 | ||
| Rename Variable containerKey : String to blockID : String in method public getFromKsmKeyInfo(keyInfo KsmKeyInfo, xceiverClientManager XceiverClientManager, storageContainerLocationClient StorageContainerLocationProtocolClientSideTranslatorPB, chunkSize int, requestId String) : ChunkGroupOutputStream in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<String> to void in method private preAllocateContainers(count int, type ReplicationType, factor ReplicationFactor) : void in class org.apache.hadoop.ozone.scm.block.BlockManagerImpl | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private stateMachine : StateMachine<OzoneProtos.LifeCycleState,OzoneProtos.LifeCycleEvent> from class org.apache.hadoop.ozone.scm.container.ContainerMapping to private stateMachine : StateMachine<OzoneProtos.LifeCycleState,OzoneProtos.LifeCycleEvent> from class org.apache.hadoop.ozone.scm.container.ContainerStateManager | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.ozone.scm.container.ContainerStateManager from class org.apache.hadoop.ozone.scm.container.ContainerMapping | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute OZONE_SCM_BLOCK_SIZE_KEY : String to OZONE_SCM_BLOCK_SIZE_IN_MB : String in class org.apache.hadoop.ozone.OzoneConfigKeys | From | To | |
| Extract Method | 2 | ||
| Extract Method public createContainer(containerId String, client XceiverClientSpi, pipeline Pipeline) : void extracted from public createContainer(containerId String) : Pipeline in class org.apache.hadoop.scm.client.ContainerOperationClient | From | To | |
| Extract Method public createContainer(containerId String, client XceiverClientSpi, pipeline Pipeline) : void extracted from public createContainer(type OzoneProtos.ReplicationType, factor OzoneProtos.ReplicationFactor, containerId String) : Pipeline in class org.apache.hadoop.scm.client.ContainerOperationClient | From | To |