c1d24f848345f6d34a2ac2d570d49e9787a0df6a
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Parameter Type | 4 | ||
Change Parameter Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method private completeUpload(file Path, uploadHandle UploadHandle, partHandles Map<Integer,PartHandle>, origDigest MessageDigest, expectedLength int) : PathHandle in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Parameter Type handles : List<Pair<Integer,PartHandle>> to handleMap : Map<Integer,PartHandle> in method public complete(filePath Path, handleMap Map<Integer,PartHandle>, multipartUploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.FileSystemMultipartUploader | From | To | |
Change Parameter Type handles : List<Pair<Integer,PartHandle>> to handleMap : Map<Integer,PartHandle> in method public complete(filePath Path, handleMap Map<Integer,PartHandle>, uploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.s3a.S3AMultipartUploader | From | To | |
Change Parameter Type handles : List<Pair<Integer,PartHandle>> to handles : Map<Integer,PartHandle> in method public abstract complete(filePath Path, handles Map<Integer,PartHandle>, multipartUploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.MultipartUploader | From | To | |
Rename Variable | 1 | ||
Rename Variable mpu : MultipartUploader to uploader : MultipartUploader in method public testMultipartUploadEmptyPart() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Parameterize Variable | 6 | ||
Parameterize Variable handle : UploadHandle to uploadHandle : UploadHandle in method private abortUpload(file Path, uploadHandle UploadHandle) : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Parameterize Variable i : int to index : int in method protected buildAndPutPart(file Path, uploadHandle UploadHandle, index int, origDigest MessageDigest) : PartHandle in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Parameterize Variable dest : Path to file : Path in method private abortUpload(file Path, uploadHandle UploadHandle) : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type | 8 | ||
Change Variable Type handle : Pair<Integer,PartHandle> to handle : Map.Entry<Integer,PartHandle> in method public complete(filePath Path, handleMap Map<Integer,PartHandle>, uploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.s3a.S3AMultipartUploader | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testMultipartUploadReverseOrderNonContiguousPartNumbers() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testMultipartUploadAbort() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testMultipartUploadEmptyPart() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testCompleteEmptyUploadID() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testSingleUpload() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testMultipartUploadReverseOrder() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Change Variable Type partHandles : List<Pair<Integer,PartHandle>> to partHandles : Map<Integer,PartHandle> in method public testMultipartUpload() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Inline Variable | 2 | ||
Inline Variable sizeInBytes : int in method private generatePayload(partNumber int) : byte[] from class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Inline Variable fs : FileSystem in method protected digest(path Path) : byte[] from class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method | 8 | ||
Extract Method protected buildAndPutPart(file Path, uploadHandle UploadHandle, index int, origDigest MessageDigest) : PartHandle extracted from public testMultipartUploadReverseOrder() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method protected buildAndPutPart(file Path, uploadHandle UploadHandle, index int, origDigest MessageDigest) : PartHandle extracted from public testMultipartUpload() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method protected verifyContents(file Path, origDigest MessageDigest, expectedLength int) : void extracted from private completeUpload(file Path, mpu MultipartUploader, uploadHandle UploadHandle, partHandles List<Pair<Integer,PartHandle>>, origDigest MessageDigest, expectedLength int) : PathHandle in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method private generatePayload(partNumber int, size int) : byte[] extracted from private generatePayload(partNumber int) : byte[] in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method private abortUpload(file Path, uploadHandle UploadHandle) : void extracted from public testMultipartUploadAbort() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method protected buildAndPutPart(file Path, uploadHandle UploadHandle, index int, origDigest MessageDigest) : PartHandle extracted from public testMultipartUploadReverseOrderNonContiguousPartNumbers() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method protected buildAndPutPart(file Path, uploadHandle UploadHandle, index int, origDigest MessageDigest) : PartHandle extracted from public testMultipartUploadAbort() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Extract Method private abortUpload(file Path, uploadHandle UploadHandle) : void extracted from public testCompleteEmptyUpload() : void in class org.apache.hadoop.fs.contract.AbstractContractMultipartUploaderTest | From | To | |
Rename Parameter | 2 | ||
Rename Parameter handles : List<Pair<Integer,PartHandle>> to handleMap : Map<Integer,PartHandle> in method public complete(filePath Path, handleMap Map<Integer,PartHandle>, multipartUploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.FileSystemMultipartUploader | From | To | |
Rename Parameter handles : List<Pair<Integer,PartHandle>> to handleMap : Map<Integer,PartHandle> in method public complete(filePath Path, handleMap Map<Integer,PartHandle>, uploadId UploadHandle) : PathHandle in class org.apache.hadoop.fs.s3a.S3AMultipartUploader | From | To |