c4d96400280d9a1595b82435297dbbed2668c485
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 36
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type containerSet : ContainerSet to containerController : ContainerController in method private createReplicationService(containerController ContainerController) : GrpcReplicationService in class org.apache.hadoop.ozone.container.server.TestContainerServer | From | To | |
| Change Parameter Type containerSet : ContainerSet to controller : ContainerController in method private createReplicationService(controller ContainerController) : GrpcReplicationService in class org.apache.hadoop.ozone.container.metrics.TestContainerMetrics | From | To | |
| Change Parameter Type containerSet : ContainerSet to controller : ContainerController in method public OnDemandContainerReplicationSource(controller ContainerController) in class org.apache.hadoop.ozone.container.replication.OnDemandContainerReplicationSource | From | To | |
| Change Parameter Type containerDispatcher : ContainerDispatcher to controller : ContainerController in method public DownloadAndImportReplicator(containerSet ContainerSet, controller ContainerController, downloader ContainerDownloader, packer TarContainerPacker) in class org.apache.hadoop.ozone.container.replication.DownloadAndImportReplicator | From | To | |
| Rename Variable | 3 | ||
| Rename Variable closeContainerProto : CloseContainerCommandProto to closeCommand : CloseContainerCommandProto in method public handle(command SCMCommand, ozoneContainer OzoneContainer, context StateContext, connectionManager SCMConnectionManager) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CloseContainerCommandHandler | From | To | |
| Rename Variable request : ContainerProtos.ContainerCommandRequestProto.Builder to command : ContainerCommandRequestProto.Builder in method private getContainerCommandRequestProto(datanodeDetails DatanodeDetails, containerId long) : ContainerCommandRequestProto in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CloseContainerCommandHandler | From | To | |
| Rename Variable containerID : long to containerId : long in method public handle(command SCMCommand, ozoneContainer OzoneContainer, context StateContext, connectionManager SCMConnectionManager) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CloseContainerCommandHandler | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private containerSet : ContainerSet from class org.apache.hadoop.ozone.container.replication.OnDemandContainerReplicationSource to private containerSet : ContainerSet from class org.apache.hadoop.ozone.container.ozoneimpl.ContainerController | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.ozone.container.ozoneimpl.ContainerController from class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Replace Variable With Attribute | 3 | ||
| Replace Variable With Attribute serverinstance : XceiverServerSpi to readChannel : XceiverServerSpi in method public start() : void in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Replace Variable With Attribute serverinstance : XceiverServerSpi to readChannel : XceiverServerSpi in method public stop() : void in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Replace Variable With Attribute serverInstance : XceiverServerSpi to writeChannel : XceiverServerSpi in method public getPipelineReport() : PipelineReportsProto in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute containerDispatcher : ContainerDispatcher to controller : ContainerController in class org.apache.hadoop.ozone.container.replication.DownloadAndImportReplicator | From | To | |
| Rename Attribute dnDetails : DatanodeDetails to handlers : Map<ContainerType,Handler> in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Rename Attribute containerSet : ContainerSet to controller : ContainerController in class org.apache.hadoop.ozone.container.replication.OnDemandContainerReplicationSource | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type request : ContainerProtos.ContainerCommandRequestProto.Builder to command : ContainerCommandRequestProto.Builder in method private getContainerCommandRequestProto(datanodeDetails DatanodeDetails, containerId long) : ContainerCommandRequestProto in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CloseContainerCommandHandler | From | To | |
| Change Variable Type containerState : ContainerDataProto.State to containerState : State in method private checkContainerOpen(kvContainer KeyValueContainer) : void in class org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type containerDispatcher : ContainerDispatcher to controller : ContainerController in class org.apache.hadoop.ozone.container.replication.DownloadAndImportReplicator | From | To | |
| Change Attribute Type dnDetails : DatanodeDetails to handlers : Map<ContainerType,Handler> in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Change Attribute Type containerSet : ContainerSet to controller : ContainerController in class org.apache.hadoop.ozone.container.replication.OnDemandContainerReplicationSource | From | To | |
| Extract Method | 4 | ||
| Extract Method private compactDB() : void extracted from public close() : void in class org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer | From | To | |
| Extract Method public closeContainer(container Container) : void extracted from package handleCloseContainer(request ContainerCommandRequestProto, kvContainer KeyValueContainer) : ContainerCommandResponseProto in class org.apache.hadoop.ozone.container.keyvalue.KeyValueHandler | From | To | |
| Extract Method private getContainerCommandRequestProto(datanodeDetails DatanodeDetails, containerId long) : ContainerCommandRequestProto extracted from public handle(command SCMCommand, ozoneContainer OzoneContainer, context StateContext, connectionManager SCMConnectionManager) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CloseContainerCommandHandler | From | To | |
| Extract Method private updateContainerData(update Runnable) : void extracted from public close() : void in class org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter containerDispatcher : ContainerDispatcher to controller : ContainerController in method public DownloadAndImportReplicator(containerSet ContainerSet, controller ContainerController, downloader ContainerDownloader, packer TarContainerPacker) in class org.apache.hadoop.ozone.container.replication.DownloadAndImportReplicator | From | To | |
| Rename Parameter containerSet : ContainerSet to containerController : ContainerController in method private createReplicationService(containerController ContainerController) : GrpcReplicationService in class org.apache.hadoop.ozone.container.server.TestContainerServer | From | To | |
| Rename Parameter containerSet : ContainerSet to controller : ContainerController in method private createReplicationService(controller ContainerController) : GrpcReplicationService in class org.apache.hadoop.ozone.container.metrics.TestContainerMetrics | From | To | |
| Rename Parameter containerSet : ContainerSet to controller : ContainerController in method public OnDemandContainerReplicationSource(controller ContainerController) in class org.apache.hadoop.ozone.container.replication.OnDemandContainerReplicationSource | From | To |