c58a59f7081d55dd2108545ebf9ee48cf43ca944
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method package nanosPerByte(bytes long) : long renamed to public nanosPerOperation(operations long) : long in class org.apache.hadoop.fs.contract.ContractTestUtils.NanoTimer | From | To | |
| Move Method | 5 | ||
| Move Method private objectRepresentsDirectory(name String, size long) : boolean from class org.apache.hadoop.fs.s3a.S3AFileSystem to public objectRepresentsDirectory(name String, size long) : boolean from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method protected bandwidth(timer NanoTimer, bytes long) : void from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public bandwidth(timer NanoTimer, bytes long) : void from class org.apache.hadoop.fs.contract.ContractTestUtils | From | To | |
| Move Method private dateToLong(date Date) : long from class org.apache.hadoop.fs.s3a.S3AFileSystem to public dateToLong(date Date) : long from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method protected toHuman(nanos long) : String from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public toHuman(nanos long) : String from class org.apache.hadoop.fs.contract.ContractTestUtils | From | To | |
| Move Method public bandwidthMBs(bytes long, durationNS long) : double from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public bandwidthMBs(bytes long, durationNS long) : double from class org.apache.hadoop.fs.contract.ContractTestUtils | From | To | |
| Rename Variable | 3 | ||
| Rename Variable ret : ObjectMetadata to om : ObjectMetadata in method public newObjectMetadata() : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Variable ret : ObjectMetadata to om : ObjectMetadata in method public newObjectMetadata(length long) : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Variable progressListener : ProgressListener to listener : ProgressableProgressListener in method private innerCopyFromLocalFile(delSrc boolean, overwrite boolean, src Path, dst Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Pull Up Attribute | 1 | ||
| Pull Up Attribute public testTimeout : Timeout from class org.apache.hadoop.fs.s3a.scale.TestS3ADeleteManyFiles to public testTimeout : Timeout from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase.NanoTimer moved to org.apache.hadoop.fs.contract.ContractTestUtils.NanoTimer | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable om : ObjectMetadata to metadata : ObjectMetadata in method public newPutObjectRequest(key String, metadata ObjectMetadata, srcfile File) : PutObjectRequest in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type progressListener : ProgressListener to listener : ProgressableProgressListener in method private innerCopyFromLocalFile(delSrc boolean, overwrite boolean, src Path, dst Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable | 2 | ||
| Extract Variable size : int in method public close() : void from class org.apache.hadoop.fs.s3a.S3AFastOutputStream | From | To | |
| Extract Variable size : int in method private putObject() : void from class org.apache.hadoop.fs.s3a.S3AFastOutputStream | From | To | |
| Extract Method | 27 | ||
| Extract Method private deleteObject(key String) : void extracted from private removeKeys(keysToDelete List<DeleteObjectsRequest.KeyVersion>, clearKeys boolean) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private deleteObject(key String) : void extracted from private deleteUnnecessaryFakeDirectories(f Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected listObjects(request ListObjectsRequest) : ObjectListing extracted from public innerListStatus(f Path) : FileStatus[] in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementWriteOperations() : void extracted from private copyFile(srcKey String, dstKey String, size long) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public newPutObjectRequest(key String, metadata ObjectMetadata, srcfile File) : PutObjectRequest extracted from private innerCopyFromLocalFile(delSrc boolean, overwrite boolean, src Path, dst Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementReadOperations() : void extracted from public innerListStatus(f Path) : FileStatus[] in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public newObjectMetadata() : ObjectMetadata extracted from private cloneObjectMetadata(source ObjectMetadata) : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected continueListObjects(objects ObjectListing) : ObjectListing extracted from private innerDelete(f Path, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementReadOperations() : void extracted from private innerDelete(f Path, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private deleteObject(key String) : void extracted from private innerDelete(f Path, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementWriteOperations() : void extracted from private deleteUnnecessaryFakeDirectories(f Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementReadOperations() : void extracted from private getObjectMetadata(key String) : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected listObjects(request ListObjectsRequest) : ObjectListing extracted from private innerRename(src Path, dst Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected listObjects(request ListObjectsRequest) : ObjectListing extracted from public getFileStatus(f Path) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected listObjects(request ListObjectsRequest) : ObjectListing extracted from private innerDelete(f Path, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected continueListObjects(objects ObjectListing) : ObjectListing extracted from public innerListStatus(f Path) : FileStatus[] in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementWriteOperations() : void extracted from private removeKeys(keysToDelete List<DeleteObjectsRequest.KeyVersion>, clearKeys boolean) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public newObjectMetadata(length long) : ObjectMetadata extracted from private cloneObjectMetadata(source ObjectMetadata) : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected continueListObjects(objects ObjectListing) : ObjectListing extracted from private innerRename(src Path, dst Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public newObjectMetadata() : ObjectMetadata extracted from private innerCopyFromLocalFile(delSrc boolean, overwrite boolean, src Path, dst Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementReadOperations() : void extracted from public getFileStatus(f Path) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementWriteOperations() : void extracted from private innerDelete(f Path, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public incrementReadOperations() : void extracted from private innerRename(src Path, dst Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Inline Variable | 1 | ||
| Inline Variable om : ObjectMetadata in method private initiateMultiPartUpload() : MultiPartUpload from class org.apache.hadoop.fs.s3a.S3AFastOutputStream | From | To | |
| Extract And Move Method | 6 | ||
| Extract And Move Method public newObjectMetadata() : ObjectMetadata extracted from private createDefaultMetadata() : ObjectMetadata in class org.apache.hadoop.fs.s3a.S3AFastOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method public newObjectMetadata() : ObjectMetadata extracted from public close() : void in class org.apache.hadoop.fs.s3a.S3AOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method package newPutObjectRequest(key String, metadata ObjectMetadata, inputStream InputStream) : PutObjectRequest extracted from public close() : void in class org.apache.hadoop.fs.s3a.S3AOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method package newPutObjectRequest(key String, metadata ObjectMetadata, inputStream InputStream) : PutObjectRequest extracted from private putObject() : void in class org.apache.hadoop.fs.s3a.S3AFastOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method public createFileStatus(keyPath Path, summary S3ObjectSummary, blockSize long) : S3AFileStatus extracted from public innerListStatus(f Path) : FileStatus[] in class org.apache.hadoop.fs.s3a.S3AFileSystem & moved to class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract And Move Method public newPutObjectRequest(key String, metadata ObjectMetadata, srcfile File) : PutObjectRequest extracted from public close() : void in class org.apache.hadoop.fs.s3a.S3AOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter bytes : long to operations : long in method public nanosPerOperation(operations long) : long in class org.apache.hadoop.fs.contract.ContractTestUtils.NanoTimer | From | To |