d324164a51a43d72c02567248bd9f0f12b244a40
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 25
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public getBlockReportIterator() : BlockReportIterator renamed to public builder() : Builder in class org.apache.hadoop.hdfs.protocol.BlockListAsLongs | From | To | |
| Push Down Method | 2 | ||
| Push Down Method public getNumberOfBlocks() : int from class org.apache.hadoop.hdfs.protocol.BlockListAsLongs to public getNumberOfBlocks() : int from class org.apache.hadoop.hdfs.protocol.BlockListAsLongs.BufferDecoder | From | To | |
| Push Down Method public getBlockListAsLongs() : long[] from class org.apache.hadoop.hdfs.protocol.BlockListAsLongs to public getBlockListAsLongs() : long[] from class org.apache.hadoop.hdfs.protocol.BlockListAsLongs.BufferDecoder | From | To | |
| Extract Subclass | 1 | ||
| Extract Subclass org.apache.hadoop.hdfs.protocol.BlockListAsLongs.BufferDecoder from class org.apache.hadoop.hdfs.protocol.BlockListAsLongs | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type blocks : long[] to blocks : BlockListAsLongs in method public StorageBlockReport(storage DatanodeStorage, blocks BlockListAsLongs) in class org.apache.hadoop.hdfs.server.protocol.StorageBlockReport | From | To | |
| Change Parameter Type injectBlocks : Iterable<Block> to injectBlocks : Iterable<? extends Block> in method public injectBlocks(bpid String, injectBlocks Iterable<? extends Block>) : void in class org.apache.hadoop.hdfs.server.datanode.SimulatedFSDataset | From | To | |
| Rename Variable | 4 | ||
| Rename Variable uc : Map<String,ArrayList<ReplicaInfo>> to builders : Map<String,BlockListAsLongs.Builder> in method public getBlockReports(bpid String) : Map<DatanodeStorage,BlockListAsLongs> in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl | From | To | |
| Rename Variable blockIds : List<Long> to num : int in method public blockReport(controller RpcController, request BlockReportRequestProto) : BlockReportResponseProto in class org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolServerSideTranslatorPB | From | To | |
| Rename Variable blocks : List<Replica> to report : BlockListAsLongs.Builder in method package getBlockReport(bpid String) : BlockListAsLongs in class org.apache.hadoop.hdfs.server.datanode.SimulatedFSDataset | From | To | |
| Rename Variable i : int to block : BlockReportReplica in method private getBlockReports(dn DataNode, bpid String, corruptOneBlockGs boolean, corruptOneBlockLen boolean) : StorageBlockReport[] in class org.apache.hadoop.hdfs.server.datanode.BlockReportTestBase | From | To | |
| Change Return Type | 3 | ||
| Change Return Type BlockReportIterator to Builder in method public builder() : Builder in class org.apache.hadoop.hdfs.protocol.BlockListAsLongs | From | To | |
| Change Return Type long[] to BlockListAsLongs in method package getBlockReportList() : BlockListAsLongs in class org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.TinyDatanode | From | To | |
| Change Return Type long[] to BlockListAsLongs in method public getBlocks() : BlockListAsLongs in class org.apache.hadoop.hdfs.server.protocol.StorageBlockReport | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type blocks : List<Replica> to report : BlockListAsLongs.Builder in method package getBlockReport(bpid String) : BlockListAsLongs in class org.apache.hadoop.hdfs.server.datanode.SimulatedFSDataset | From | To | |
| Change Variable Type blockIds : List<Long> to num : int in method public blockReport(controller RpcController, request BlockReportRequestProto) : BlockReportResponseProto in class org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolServerSideTranslatorPB | From | To | |
| Change Variable Type blocks : ArrayList<Block> to blocks : ArrayList<Replica> in method public testBlockHasMultipleReplicasOnSameDN() : void in class org.apache.hadoop.hdfs.server.datanode.TestBlockHasMultipleReplicasOnSameDN | From | To | |
| Change Variable Type i : int to block : BlockReportReplica in method private getBlockReports(dn DataNode, bpid String, corruptOneBlockGs boolean, corruptOneBlockLen boolean) : StorageBlockReport[] in class org.apache.hadoop.hdfs.server.datanode.BlockReportTestBase | From | To | |
| Change Variable Type blocks : long[] to blocks : BlockListAsLongs in method public blockReport(registration DatanodeRegistration, poolId String, reports StorageBlockReport[]) : DatanodeCommand in class org.apache.hadoop.hdfs.protocolPB.DatanodeProtocolClientSideTranslatorPB | From | To | |
| Change Variable Type uc : Map<String,ArrayList<ReplicaInfo>> to builders : Map<String,BlockListAsLongs.Builder> in method public getBlockReports(bpid String) : Map<DatanodeStorage,BlockListAsLongs> in class org.apache.hadoop.hdfs.server.datanode.fsdataset.impl.FsDatasetImpl | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type blocks : ArrayList<Block> to blocks : ArrayList<BlockReportReplica> in class org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.TinyDatanode | From | To | |
| Change Attribute Type blocks : long[] to blocks : BlockListAsLongs in class org.apache.hadoop.hdfs.server.protocol.StorageBlockReport | From | To | |
| Change Attribute Type blockReportList : long[] to blockReportList : BlockListAsLongs in class org.apache.hadoop.hdfs.server.namenode.NNThroughputBenchmark.TinyDatanode | From | To |