d5eca1a6a0e3939eead6711805b7a61c364d254b
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 7 | ||
| Rename Method private runOOMHandler(containers ConcurrentHashMap<ContainerId,Container>, cGroupsHandler CGroupsHandler, ex ContainerExecutor) : void renamed to protected getCGroupsHandler() : CGroupsHandler in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler.testBothGuaranteedContainersOverLimitUponOOM.handler | From | To | |
| Rename Method public testOneContainerOOM() : void renamed to public testKillOneOverLimitOpportunisticContainerUponOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Method public testNoContainerOOM() : void renamed to public testNoGuaranteedContainerOverLimitOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Method package getToken() : ContainerTokenIdentifier renamed to protected getCGroupsHandler() : CGroupsHandler in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler.testBothGuaranteedContainersOverLimitUponOOM.handler | From | To | |
| Rename Method private killContainerIfOOM(container Container, fileName String) : boolean renamed to private isContainerOutOfLimit(container Container) : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Rename Method public testNoContainers() : void renamed to public testExceptionThrownWithNoContainersToKill() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Method public testBothContainersOOM() : void renamed to public testKillOneLaterOpportunisticContainerUponOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Variable | 8 | ||
| Rename Variable cid2 : ContainerId to type : ExecutionType in method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Variable containers : ArrayList<Container> to candidates : ArrayList<ContainerCandidate> in method protected killContainer() : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Rename Variable ex : ContainerExecutor to token : ContainerTokenIdentifier in method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Variable found : boolean to containerKilled : boolean in method protected killContainer() : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Change Return Type | 2 | ||
| Change Return Type ContainerTokenIdentifier to CGroupsHandler in method protected getCGroupsHandler() : CGroupsHandler in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler.testBothGuaranteedContainersOverLimitUponOOM.handler | From | To | |
| Change Return Type void to CGroupsHandler in method protected getCGroupsHandler() : CGroupsHandler in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler.testBothGuaranteedContainersOverLimitUponOOM.handler | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute fileName : String to memoryStatFile : String in method private isContainerOutOfLimit(container Container) : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Extract Variable | 1 | ||
| Extract Variable outOfLimit : boolean in method private isContainerOutOfLimit(container Container) : boolean from class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type cid2 : ContainerId to type : ExecutionType in method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Change Variable Type containers : ArrayList<Container> to candidates : ArrayList<ContainerCandidate> in method protected killContainer() : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Change Variable Type ex : ContainerExecutor to token : ContainerTokenIdentifier in method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Extract Method | 5 | ||
| Extract Method protected getCGroupsHandler() : CGroupsHandler extracted from public DefaultOOMHandler(context Context, testVirtual boolean) in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Extract Method protected killContainer() : boolean extracted from public run() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To | |
| Extract Method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container extracted from public testOneContainerOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Extract Method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container extracted from public testBothContainersOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Extract Method private createContainer(containerId int, guaranteed boolean, launchTime long) : Container extracted from public testNoContainerOOM() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestDefaultOOMHandler | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter testVirtual : boolean to enforceVirtualMemory : boolean in method public DefaultOOMHandler(context Context, enforceVirtualMemory boolean) in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.DefaultOOMHandler | From | To |