d5f66888b8d767ee6706fab9950c194a1bf26d32
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public createAndRegisterApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse renamed to public registerApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Rename Method public getAttemptId() : ApplicationAttemptId renamed to public getAppId() : ApplicationId in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Rename Method protected getUAMIdentifier() : UnmanagedAMIdentifier renamed to protected getUAMToken() : Token<AMRMTokenIdentifier> in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Rename Method protected createAndRegisterApplicationMaster(request RegisterApplicationMasterRequest, appAttemptId ApplicationAttemptId) : RegisterApplicationMasterResponse renamed to protected registerApplicationMaster(request RegisterApplicationMasterRequest, appAttemptId ApplicationAttemptId) : RegisterApplicationMasterResponse in class org.apache.hadoop.yarn.server.uam.TestUnmanagedApplicationManager | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type attemptId : ApplicationAttemptId to appId : ApplicationId in method public finishAMWithReRegister(request FinishApplicationMasterRequest, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest, appId ApplicationId) : FinishApplicationMasterResponse in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To | |
| Change Parameter Type attemptId : ApplicationAttemptId to appId : ApplicationId in method public handleNotRegisteredExceptionAndReRegister(appId ApplicationId, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest) : void in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To | |
| Change Parameter Type attemptId : ApplicationAttemptId to appId : ApplicationId in method public allocateWithReRegister(request AllocateRequest, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest, appId ApplicationId) : AllocateResponse in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable amrmToken : String to attemptId : ApplicationAttemptId in method public registerApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Rename Variable amrmToken : String to attemptId : ApplicationAttemptId in method public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Change Return Type | 5 | ||
| Change Return Type UnmanagedAMIdentifier to Token<AMRMTokenIdentifier> in method protected initializeUnmanagedAM(appId ApplicationId) : Token<AMRMTokenIdentifier> in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Change Return Type ApplicationAttemptId to ApplicationId in method public getAppId() : ApplicationId in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Change Return Type void to boolean in method public setAMRMToken(amrmToken Token<AMRMTokenIdentifier>) : boolean in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.AMRMProxyApplicationContextImpl | From | To | |
| Change Return Type UnmanagedAMIdentifier to Token<AMRMTokenIdentifier> in method protected getUAMToken() : Token<AMRMTokenIdentifier> in class org.apache.hadoop.yarn.server.uam.UnmanagedApplicationManager | From | To | |
| Change Return Type String to ApplicationAttemptId in method private getAppIdentifier() : ApplicationAttemptId in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute attemptIdMap : Map<String,ApplicationAttemptId> to appIdMap : Map<String,ApplicationId> in class org.apache.hadoop.yarn.server.uam.UnmanagedAMPoolManager | From | To | |
| Extract Variable | 2 | ||
| Extract Variable completedList : List<ContainerStatus> in method public allocate(request AllocateRequest) : AllocateResponse from class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Extract Variable appId : ApplicationId in method public registerApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse from class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.FederationInterceptor | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type amrmToken : String to attemptId : ApplicationAttemptId in method public registerApplicationMaster(request RegisterApplicationMasterRequest) : RegisterApplicationMasterResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Change Variable Type containersForReleasedContainerIds : List<Container> to containersForReleasedContainerIds : List<ContainerId> in method private releaseContainersAndAssert(containers List<Container>) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestFederationInterceptor | From | To | |
| Change Variable Type amrmToken : String to attemptId : ApplicationAttemptId in method public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Change Variable Type containersForReleasedContainerIds : List<Container> to containersForReleasedContainerIds : List<ContainerId> in method private releaseContainersAndAssert(appId int, containers List<Container>) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.TestAMRMProxyService | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type applicationContainerIdMap : HashMap<String,List<ContainerId>> to applicationContainerIdMap : HashMap<ApplicationAttemptId,List<ContainerId>> in class org.apache.hadoop.yarn.server.MockResourceManagerFacade | From | To | |
| Change Attribute Type attemptIdMap : Map<String,ApplicationAttemptId> to appIdMap : Map<String,ApplicationId> in class org.apache.hadoop.yarn.server.uam.UnmanagedAMPoolManager | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter attemptId : ApplicationAttemptId to appId : ApplicationId in method public finishAMWithReRegister(request FinishApplicationMasterRequest, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest, appId ApplicationId) : FinishApplicationMasterResponse in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To | |
| Rename Parameter attemptId : ApplicationAttemptId to appId : ApplicationId in method public handleNotRegisteredExceptionAndReRegister(appId ApplicationId, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest) : void in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To | |
| Rename Parameter attemptId : ApplicationAttemptId to appId : ApplicationId in method public allocateWithReRegister(request AllocateRequest, rmProxy ApplicationMasterProtocol, registerRequest RegisterApplicationMasterRequest, appId ApplicationId) : AllocateResponse in class org.apache.hadoop.yarn.server.utils.AMRMClientUtils | From | To |