d7152332b32a575c3a92e3f4c44b95e58462528d
Files Diff
- Added: 43
- Removed: 3
- Renamed: 0
- Modified: 59
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type e : AWSS3IOException to e : AWSServiceIOException in method protected assertStatusCode(e AWSServiceIOException, code int) : void in class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Change Parameter Type expectedClasses : List<Class<? extends AWSCredentialsProvider>> to expectedClasses : List<Class<?>> in method private assertCredentialProviders(expectedClasses List<Class<?>>, list AWSCredentialProviderList) : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Move Method | 3 | ||
| Move Method protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSECBlockOutputStream to protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.yarn.ITestS3AMiniYarnCluster | From | To | |
| Move Method protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSES3BlockOutputStream to protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3ATemporaryCredentials | From | To | |
| Move Method protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEKMSUserDefinedKeyBlockOutputStream to protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.yarn.ITestS3AMiniYarnCluster | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private accessKey : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider to private accessKey : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials | From | To | |
| Move Attribute private secretKey : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider to private secretKey : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials | From | To | |
| Move Attribute private sessionToken : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider to private sessionToken : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider | From | To | |
| Extract Variable | 2 | ||
| Extract Variable existsPath : Path in method public testFail() : void from class org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit | From | To | |
| Extract Variable exists : Path in method public testDefault() : void from class org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type expectedClasses : List<Class<? extends AWSCredentialsProvider>> to expectedClasses : List<Class<?>> in method public testInstantiationChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Change Variable Type expectedClasses : List<Class<? extends AWSCredentialsProvider>> to expectedClasses : List<Class<?>> in method public testConfiguredChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Change Variable Type expectedClasses : List<Class<? extends AWSCredentialsProvider>> to expectedClasses : List<Class<?>> in method public testConfiguredChainUsesSharedInstanceProfile() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Extract Method | 6 | ||
| Extract Method protected setEncryptionSecrets(secrets EncryptionSecrets) : void extracted from public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public builder(credentials AWSCredentialsProvider, awsConf ClientConfiguration, stsEndpoint String, stsRegion String) : AWSSecurityTokenServiceClientBuilder extracted from public builder(conf Configuration, bucket String, credentials AWSCredentialsProvider, stsEndpoint String, stsRegion String) : AWSSecurityTokenServiceClientBuilder in class org.apache.hadoop.fs.s3a.auth.STSClientFactory | From | To | |
| Extract Method protected createValidRoleConf() : Configuration extracted from public testCreateCredentialProvider() : void in class org.apache.hadoop.fs.s3a.auth.ITestAssumeRole | From | To | |
| Extract Method private expectProviderInstantiationFailure(aClass Class, expectedErrorText String) : IOException extracted from public testProviderWrongClass() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Extract Method private createProviderConfiguration(providerOption String) : Configuration extracted from public testConfiguredChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Extract Method private bindAWSClient(name URI, dtEnabled boolean) : void extracted from public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public getCredentials() : AWSCredentials from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider to public getCredentials() : AWSCredentials from class org.apache.hadoop.fs.s3a.auth.AbstractSessionCredentialsProvider | From | To | |
| Pull Up Method public toString() : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider to public toString() : String from class org.apache.hadoop.fs.s3a.auth.AbstractSessionCredentialsProvider | From | To | |
| Change Return Type | 3 | ||
| Change Return Type SSEAwsKeyManagementParams to Optional<SSEAwsKeyManagementParams> in method private generateSSEAwsKeyParams() : Optional<SSEAwsKeyManagementParams> in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type SSECustomerKey to Optional<SSECustomerKey> in method private generateSSECustomerKey() : Optional<SSECustomerKey> in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type Class<?>[] to List<Class<?>> in method public loadAWSProviderClasses(conf Configuration, key String, defaultValue Class<?>...) : List<Class<?>> in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.fs.s3a.auth.AbstractSessionCredentialsProvider from classes [org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider] | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute OUTPUT_PATH : Path to outputPath : Path in class org.apache.hadoop.fs.s3a.commit.staging.StagingTestBase | From | To | |
| Rename Attribute OUTPUT_PATH_URI : URI to RAW_BUCKET_URI : URI in class org.apache.hadoop.fs.s3a.commit.staging.StagingTestBase | From | To | |
| Rename Attribute PROVIDER_CLASS : String to TEMPORARY_AWS_CREDENTIALS : String in class org.apache.hadoop.fs.s3a.ITestS3ATemporaryCredentials | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type S3_ROOT_RW_OPERATIONS : String[] to S3_ROOT_RW_OPERATIONS : List<String> in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Change Attribute Type S3_PATH_WRITE_OPERATIONS : String[] to S3_PATH_WRITE_OPERATIONS : List<String> in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Change Attribute Type S3_PATH_RW_OPERATIONS : String[] to S3_PATH_RW_OPERATIONS : List<String> in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public terminateService(service T) : T extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.AbstractITCommitMRJob & moved to class org.apache.hadoop.fs.s3a.S3ATestUtils | From | To | |
| Extract And Move Method public buildAWSProviderList(binding URI, conf Configuration, key String, defaultValues List<Class<?>>, forbidden Set<Class<?>>) : AWSCredentialProviderList extracted from public AssumedRoleCredentialProvider(fsUri URI, conf Configuration) in class org.apache.hadoop.fs.s3a.auth.AssumedRoleCredentialProvider & moved to class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter req : InitiateMultipartUploadRequest to request : InitiateMultipartUploadRequest in method protected setOptionalMultipartUploadRequestParameters(request InitiateMultipartUploadRequest) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter uri : URI to fsUri : URI in method protected setUri(fsUri URI, canonicalize boolean) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To |