d749cf65e1ab0e0daf5be86931507183f189e855
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Extract Subclass | 2 | ||
| Extract Subclass org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockReconstructor from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Extract Subclass org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockChecksumReconstructor from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedReader(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReader | From | To | |
| Change Parameter Type reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedReconstructor(worker ErasureCodingWorker, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Change Parameter Type reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedWriter(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedWriter | From | To | |
| Move Method | 1 | ||
| Move Method package getMaxTargetLength() : long from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedWriter to package getMaxTargetLength() : long from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute private stripedWriter : StripedWriter from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to private stripedWriter : StripedWriter from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockReconstructor | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private maxTargetLength : long from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedWriter to private maxTargetLength : long from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Merge Variable | 2 | ||
| Merge Variable [ecPolicy : ErasureCodingPolicy, blockGroup : ExtendedBlock] to stripedReconInfo : StripedReconstructionInfo in method package StripedReader(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReader | From | To | |
| Merge Variable [blockToken : Token<BlockTokenIdentifier>, targetDatanode : DatanodeInfo] to liveBlkInfo : LiveBlockInfo in method package compute() : void in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type task : StripedReconstructor to task : StripedBlockReconstructor in method public processErasureCodingTasks(ecTasks Collection<BlockECReconstructionInfo>) : void in class org.apache.hadoop.hdfs.server.datanode.erasurecode.ErasureCodingWorker | From | To | |
| Change Variable Type targetDatanode : DatanodeInfo to blkIndxLen : int in method package compute() : void in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable numDataUnits : int in method package compute() : void from class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Extract Method | 1 | ||
| Extract Method private setOrVerifyChecksumProperties(blockIdx int, bpc int, cpb long, ct DataChecksum.Type) : void extracted from private checksumBlock(block ExtendedBlock, blockIdx int, blockToken Token<BlockTokenIdentifier>, targetDatanode DatanodeInfo) : void in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Push Down Method | 5 | ||
| Push Down Method private clearBuffers() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to private clearBuffers() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockChecksumReconstructor | From | To | |
| Push Down Method public run() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to public run() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockReconstructor | From | To | |
| Push Down Method package reconstructAndTransfer() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to package reconstruct() : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockReconstructor | From | To | |
| Push Down Method package hasValidTargets() : boolean from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to package hasValidTargets() : boolean from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockReconstructor | From | To | |
| Push Down Method private reconstructTargets(toReconstructLen int) : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor to private reconstructTargets(toReconstructLen int) : void from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockChecksumReconstructor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable targetDatanode : DatanodeInfo to blkIndxLen : int in method package compute() : void in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute worker : ErasureCodingWorker to stripedReadPool : ThreadPoolExecutor in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type worker : ErasureCodingWorker to stripedReadPool : ThreadPoolExecutor in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method package setMaxTargetLength(maxTargetLength long) : void extracted from package StripedWriter(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, reconstructionInfo BlockECReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedWriter & moved to class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedReader(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReader | From | To | |
| Rename Parameter reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedWriter(reconstructor StripedReconstructor, datanode DataNode, conf Configuration, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedWriter | From | To | |
| Rename Parameter reconstructionInfo : BlockECReconstructionInfo to stripedReconInfo : StripedReconstructionInfo in method package StripedReconstructor(worker ErasureCodingWorker, stripedReconInfo StripedReconstructionInfo) in class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedReconstructor | From | To |