da9a39eed138210de29b59b90c449b28da1c04f9
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 28
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private enablePathStyleAccessIfRequired(s3 AmazonS3, conf Configuration) : void renamed to private applyS3ClientOptions(s3 AmazonS3, conf Configuration) : AmazonS3 in class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory | From | To | |
| Rename Method private createAmazonS3Client(s3 AmazonS3, conf Configuration, credentials AWSCredentialsProvider, awsConf ClientConfiguration) : AmazonS3 renamed to private configureAmazonS3Client(s3 AmazonS3, conf Configuration) : AmazonS3 in class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type closeables : java.io.Closeable... to closeables : Closeable... in method public closeAll(log Logger, closeables Closeable...) : void in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method | 4 | ||
| Move Method private initUserAgent(conf Configuration, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory to private initUserAgent(conf Configuration, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method public createAwsConf(conf Configuration) : ClientConfiguration from class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory to public createAwsConf(conf Configuration, bucket String) : ClientConfiguration from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method private initConnectionSettings(conf Configuration, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory to public initConnectionSettings(conf Configuration, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Method private initProxySupport(conf Configuration, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory to public initProxySupport(conf Configuration, bucket String, awsConf ClientConfiguration) : void from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable epr : String to endpoint : String in method public AssumedRoleCredentialProvider(fsUri URI, conf Configuration) in class org.apache.hadoop.fs.s3a.auth.AssumedRoleCredentialProvider | From | To | |
| Rename Variable p : Path to onS3AndMS : Path in method public testListStatusWriteBack() : void in class org.apache.hadoop.fs.s3a.ITestS3GuardWriteBack | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to E in method private expectFileSystemCreateFailure(conf Configuration, clazz Class<E>, text String) : E in class org.apache.hadoop.fs.s3a.auth.ITestAssumeRole | From | To | |
| Change Return Type void to AmazonS3 in method private applyS3ClientOptions(s3 AmazonS3, conf Configuration) : AmazonS3 in class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory | From | To | |
| Extract Variable | 2 | ||
| Extract Variable onS3 : Path in method public testListStatusWriteBack() : void from class org.apache.hadoop.fs.s3a.ITestS3GuardWriteBack | From | To | |
| Extract Variable fs : S3AFileSystem in method public testConcurrentTableCreations() : void from class org.apache.hadoop.fs.s3a.s3guard.ITestS3GuardConcurrentOps | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type c : java.io.Closeable to c : Closeable in method public closeAll(log Logger, closeables Closeable...) : void in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract Method | 7 | ||
| Extract Method private expectFSCreateFailure(clazz Class<E>, conf Configuration, text String) : E extracted from public testAutomaticProxyPortSelection() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Extract Method private expectFSCreateFailure(clazz Class<E>, conf Configuration, text String) : E extracted from public testProxyConnection() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Extract Method private assertIsProxyUsernameError(e IllegalArgumentException) : void extracted from public testUsernameInconsistentWithPassword() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Extract Method public lookupPassword(bucket String, conf Configuration, baseKey String, overrideVal String, defVal String) : String extracted from public lookupPassword(bucket String, conf Configuration, baseKey String, overrideVal String) : String in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract Method private expectFSCreateFailure(clazz Class<E>, conf Configuration, text String) : E extracted from public testUsernameInconsistentWithPassword() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Extract Method private expectFSCreateFailure(clazz Class<E>, conf Configuration, text String) : E extracted from public testProxyPortWithoutHost() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter uri : URI to fsUri : URI in method public AssumedRoleCredentialProvider(fsUri URI, conf Configuration) in class org.apache.hadoop.fs.s3a.auth.AssumedRoleCredentialProvider | From | To |