dab00da19f25619ccc71c7f803a235b21766bf1e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public testDoubleStreamClose() : void renamed to public testWriteAfterStreamClose() : void in class org.apache.hadoop.fs.s3a.ITestS3ABlockOutputArray | From | To | |
Rename Variable | 2 | ||
Rename Variable uploadStream : InputStream to uploadData : S3ADataBlocks.BlockUploadData in method private uploadBlockAsync(block S3ADataBlocks.DataBlock) : void in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream.MultiPartUpload | From | To | |
Rename Variable buffer : ByteBuffer to buf : ByteBuffer in method public toString() : String in class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferBlock.ByteBufferInputStream | From | To | |
Change Return Type | 4 | ||
Change Return Type ByteBufferInputStream to BlockUploadData in method package startUpload() : BlockUploadData in class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferBlock | From | To | |
Change Return Type InputStream to BlockUploadData in method package startUpload() : BlockUploadData in class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteArrayBlock | From | To | |
Change Return Type InputStream to BlockUploadData in method package startUpload() : BlockUploadData in class org.apache.hadoop.fs.s3a.S3ADataBlocks.DataBlock | From | To | |
Change Return Type InputStream to BlockUploadData in method package startUpload() : BlockUploadData in class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock | From | To | |
Move Attribute | 2 | ||
Move Attribute private uploadStream : InputStream from class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock to private uploadStream : InputStream from class org.apache.hadoop.fs.s3a.S3ADataBlocks.BlockUploadData | From | To | |
Move Attribute private closed : AtomicBoolean from class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock.FileDeletingInputStream to private closed : AtomicBoolean from class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock | From | To | |
Move Class | 1 | ||
Move Class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferInputStream moved to org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferBlock.ByteBufferInputStream | From | To | |
Rename Attribute | 1 | ||
Rename Attribute buffer : ByteBuffer to blockBuffer : ByteBuffer in class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferBlock | From | To | |
Change Variable Type | 1 | ||
Change Variable Type uploadStream : InputStream to uploadData : S3ADataBlocks.BlockUploadData in method private uploadBlockAsync(block S3ADataBlocks.DataBlock) : void in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream.MultiPartUpload | From | To | |
Inline Variable | 1 | ||
Inline Variable deleted : boolean in method protected innerClose() : void from class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock | From | To | |
Extract Method | 5 | ||
Extract Method private assertOutstandingBuffers(factory S3ADataBlocks.ByteBufferBlockFactory, expectedCount int) : void extracted from public testByteBufferIO() : void in class org.apache.hadoop.fs.s3a.TestDataBlocks | From | To | |
Extract Method package closeBlock() : void extracted from protected innerClose() : void in class org.apache.hadoop.fs.s3a.S3ADataBlocks.DiskBlock | From | To | |
Rename Parameter | 1 | ||
Rename Parameter buffer : byte[] to b : byte[] in method public read(b byte[], offset int, length int) : int in class org.apache.hadoop.fs.s3a.S3ADataBlocks.ByteBufferBlockFactory.ByteBufferBlock.ByteBufferInputStream | From | To |