dce4ebe81471fa2c1ef913a1a2c8acffcbdaa6f8
Files Diff
- Added: 1
- Removed: 13
- Renamed: 0
- Modified: 88
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 9 | ||
Rename Method public getID() : PipelineID renamed to public getId() : PipelineID in class org.apache.hadoop.hdds.scm.pipeline.Pipeline | From | To | |
Rename Method package getPipelinesByType(type ReplicationType) : List<Pipeline> renamed to package getPipelines(type ReplicationType) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateManager | From | To | |
Rename Method public getPipelinesByTypeAndFactor(type ReplicationType, factor ReplicationFactor) : List<Pipeline> renamed to public getPipelines(type ReplicationType, factor ReplicationFactor) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager | From | To | |
Rename Method public getPipelinesByTypeAndFactor(type ReplicationType, factor ReplicationFactor) : List<Pipeline> renamed to public getPipelines(type ReplicationType, factor ReplicationFactor) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineManager | From | To | |
Rename Method public getPipelinesByType(type ReplicationType) : List<Pipeline> renamed to public getPipelines(type ReplicationType) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineManager | From | To | |
Rename Method public fromProtobuf(pipeline HddsProtos.Pipeline) : Pipeline renamed to public getFromProtobuf(pipeline HddsProtos.Pipeline) : Pipeline in class org.apache.hadoop.hdds.scm.pipeline.Pipeline | From | To | |
Rename Method package getPipelinesByTypeAndFactor(type ReplicationType, factor ReplicationFactor) : List<Pipeline> renamed to package getPipelines(type ReplicationType, factor ReplicationFactor) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateManager | From | To | |
Rename Method package getPipelinesByType(type ReplicationType) : List<Pipeline> renamed to package getPipelines(type ReplicationType) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateMap | From | To | |
Rename Method public getPipelinesByType(type ReplicationType) : List<Pipeline> renamed to public getPipelines(type ReplicationType) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type pipeline : Pipeline to pipeline : org.apache.hadoop.hdds.scm.pipeline.Pipeline in method public newXceiverClientRatis(pipeline org.apache.hadoop.hdds.scm.pipeline.Pipeline, ozoneConf Configuration) : XceiverClientRatis in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
Change Parameter Type initConf : BiConsumer<Pipeline,OzoneConfiguration> to initConf : CheckedBiConsumer<Pipeline,OzoneConfiguration,IOException> in method package runTestClientServer(numDatanodes int, initConf CheckedBiConsumer<Pipeline,OzoneConfiguration,IOException>, createClient CheckedBiFunction<Pipeline,OzoneConfiguration,XceiverClientSpi,IOException>, createServer CheckedBiFunction<DatanodeDetails,OzoneConfiguration,XceiverServerSpi,IOException>, initServer CheckedBiConsumer<DatanodeDetails,Pipeline,IOException>) : void in class org.apache.hadoop.ozone.container.server.TestContainerServer | From | To | |
Change Parameter Type selector : PipelineSelector to pipelineManager : PipelineManager in method package allocateContainer(pipelineManager PipelineManager, type HddsProtos.ReplicationType, replicationFactor HddsProtos.ReplicationFactor, owner String) : ContainerInfo in class org.apache.hadoop.hdds.scm.container.ContainerStateManager | From | To | |
Move Method | 1 | ||
Move Method public isEmpty() : boolean from class org.apache.hadoop.hdds.scm.container.common.helpers.Pipeline to public isEmpty() : boolean from class org.apache.hadoop.hdds.scm.pipeline.Pipeline | From | To | |
Rename Variable | 3 | ||
Rename Variable leadDN : DatanodeDetails to dn : DatanodeDetails in method private getContainerMetadata(containerID Long) : MetadataStore in class org.apache.hadoop.ozone.TestStorageContainerManagerHelper | From | To | |
Rename Variable pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in method private allocateContainer() : ContainerInfo in class org.apache.hadoop.hdds.scm.container.TestContainerStateManager | From | To | |
Rename Variable leader : DatanodeDetails to dn : DatanodeDetails in method public connect() : void in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
Change Return Type | 2 | ||
Change Return Type void to Pipeline in method package removePipeline(pipelineID PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateMap | From | To | |
Change Return Type void to Pipeline in method package removePipeline(pipelineID PipelineID) : Pipeline in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateManager | From | To | |
Move Attribute | 1 | ||
Move Attribute private nodeManager : NodeManager from class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector to private nodeManager : NodeManager from class org.apache.hadoop.hdds.scm.node.StaleNodeHandler | From | To | |
Rename Attribute | 4 | ||
Rename Attribute pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.container.SCMContainerManager | From | To | |
Rename Attribute pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose | From | To | |
Rename Attribute pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.pipeline.TestNode2PipelineMap | From | To | |
Rename Attribute pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.node.StaleNodeHandler | From | To | |
Change Variable Type | 1 | ||
Change Variable Type pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in method private allocateContainer() : ContainerInfo in class org.apache.hadoop.hdds.scm.container.TestContainerStateManager | From | To | |
Inline Variable | 3 | ||
Inline Variable i : Iterator<DatanodeDetails> in method public createPipeline(ids Iterable<DatanodeDetails>) : Pipeline from class org.apache.hadoop.hdds.scm.container.replication.TestReplicationManager | From | To | |
Inline Variable i : Iterator<DatanodeDetails> in method public createPipeline(containerName String, ids Iterable<DatanodeDetails>) : Pipeline from class org.apache.hadoop.ozone.genesis.BenchMarkContainerStateMap | From | To | |
Inline Variable i : Iterator<DatanodeDetails> in method public createPipeline(ids Iterable<DatanodeDetails>) : Pipeline from class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
Extract Method | 1 | ||
Extract Method package getPipelines(type ReplicationType, states PipelineState...) : List<Pipeline> extracted from package getPipelinesByType(type ReplicationType) : List<Pipeline> in class org.apache.hadoop.hdds.scm.pipeline.PipelineStateManager | From | To | |
Change Attribute Type | 4 | ||
Change Attribute Type pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.node.StaleNodeHandler | From | To | |
Change Attribute Type pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.container.SCMContainerManager | From | To | |
Change Attribute Type pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose | From | To | |
Change Attribute Type pipelineSelector : PipelineSelector to pipelineManager : PipelineManager in class org.apache.hadoop.hdds.scm.pipeline.TestNode2PipelineMap | From | To | |
Rename Parameter | 1 | ||
Rename Parameter selector : PipelineSelector to pipelineManager : PipelineManager in method package allocateContainer(pipelineManager PipelineManager, type HddsProtos.ReplicationType, replicationFactor HddsProtos.ReplicationFactor, owner String) : ContainerInfo in class org.apache.hadoop.hdds.scm.container.ContainerStateManager | From | To |