de1dae64f2458f7ab57ae040b98c1f4e26d54bda
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 39
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 6 | ||
| Change Parameter Type retryFailure : boolean to exception : Throwable in method private handleException(streamEntry BlockOutputStreamEntry, streamIndex int, exception Throwable) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Change Parameter Type excludeDns : List<UUID> to excludeDns : List<DatanodeDetails> in method public sendCommand(request ContainerCommandRequestProto, excludeDns List<DatanodeDetails>) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientSpi | From | To | |
| Change Parameter Type excludeDns : List<UUID> to excludeDns : List<DatanodeDetails> in method public sendCommand(request ContainerCommandRequestProto, excludeDns List<DatanodeDetails>) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
| Change Parameter Type excludeDns : List<UUID> to excludeDns : List<DatanodeDetails> in method private sendCommandWithRetry(request ContainerCommandRequestProto, excludeDns List<DatanodeDetails>) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
| Change Parameter Type dnId : UUID to datanodes : List<DatanodeDetails> in method public XceiverClientReply(response CompletableFuture<ContainerCommandResponseProto>, datanodes List<DatanodeDetails>) in class org.apache.hadoop.hdds.scm.XceiverClientReply | From | To | |
| Change Parameter Type excludeDns : List<UUID> to excludeDns : List<DatanodeDetails> in method public readChunk(xceiverClient XceiverClientSpi, chunk ChunkInfo, blockID BlockID, traceID String, excludeDns List<DatanodeDetails>) : XceiverClientReply in class org.apache.hadoop.hdds.scm.storage.ContainerProtocolCalls | From | To | |
| Move Method | 1 | ||
| Move Method private waitForContainerClose(containerIdList Long...) : void from class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient to public waitForContainerClose(cluster MiniOzoneCluster, containerIdList Long...) : void from class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Rename Variable | 2 | ||
| Rename Variable retryFailure : boolean to t : Throwable in method private handleFlushOrClose(close boolean) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Rename Variable retryFailure : boolean to t : Throwable in method private handleWrite(b byte[], off int, len long, retry boolean) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Change Return Type | 4 | ||
| Change Return Type long to XceiverClientReply in method public watchForCommit(index long, timeout long) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Change Return Type long to XceiverClientReply in method public abstract watchForCommit(index long, timeout long) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientSpi | From | To | |
| Change Return Type long to XceiverClientReply in method public watchForCommit(index long, timeout long) : XceiverClientReply in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
| Change Return Type boolean to Throwable in method private checkForException(ioe IOException) : Throwable in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute futureList : List<CompletableFuture<ContainerProtos.ContainerCommandResponseProto>> to futureMap : ConcurrentHashMap<Long,CompletableFuture<ContainerProtos.ContainerCommandResponseProto>> in class org.apache.hadoop.hdds.scm.storage.BlockOutputStream | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type retryFailure : boolean to t : Throwable in method private handleFlushOrClose(close boolean) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Change Variable Type excludeDns : List<UUID> to excludeDns : List<DatanodeDetails> in method private readChunkFromContainer() : void in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Change Variable Type retryFailure : boolean to t : Throwable in method private handleWrite(b byte[], off int, len long, retry boolean) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Change Variable Type cls : Class to cls : Class<? extends Exception> in method private checkForException(ioe IOException) : Throwable in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type commitInfoMap : ConcurrentHashMap<String,Long> to commitInfoMap : ConcurrentHashMap<UUID,Long> in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Change Attribute Type futureList : List<CompletableFuture<ContainerProtos.ContainerCommandResponseProto>> to futureMap : ConcurrentHashMap<Long,CompletableFuture<ContainerProtos.ContainerCommandResponseProto>> in class org.apache.hadoop.hdds.scm.storage.BlockOutputStream | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter retryFailure : boolean to exception : Throwable in method private handleException(streamEntry BlockOutputStreamEntry, streamIndex int, exception Throwable) : void in class org.apache.hadoop.ozone.client.io.KeyOutputStream | From | To | |
| Rename Parameter dnId : UUID to datanodes : List<DatanodeDetails> in method public XceiverClientReply(response CompletableFuture<ContainerCommandResponseProto>, datanodes List<DatanodeDetails>) in class org.apache.hadoop.hdds.scm.XceiverClientReply | From | To |