de8b6ca5ef8614de6d6277b7617e27c788b0555c
Files Diff
- Added: 86
- Removed: 0
- Renamed: 0
- Modified: 58
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 7 | ||
| Change Parameter Type exception : AmazonClientException to exception : SdkBaseException in method public translateException(operation String, path String, exception SdkBaseException) : IOException in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Change Parameter Type key : String to owner : S3AFileSystem in method protected WriteOperationHelper(owner S3AFileSystem) in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Change Parameter Type writeOperationHelper : S3AFileSystem.WriteOperationHelper to writeOperationHelper : WriteOperationHelper in method package S3ABlockOutputStream(fs S3AFileSystem, key String, executorService ExecutorService, progress Progressable, blockSize long, blockFactory S3ADataBlocks.BlockFactory, statistics S3AInstrumentation.OutputStreamStatistics, writeOperationHelper WriteOperationHelper, putTracker PutTracker) in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream | From | To | |
| Change Parameter Type dataOutputStream : DataOutputStream to dataOutputStream : OutputStream in method private writeJsonAsBytes(instance T, dataOutputStream OutputStream) : void in class org.apache.hadoop.util.JsonSerialization | From | To | |
| Change Parameter Type cause : AmazonClientException to cause : SdkBaseException in method public AWSClientIOException(operation String, cause SdkBaseException) in class org.apache.hadoop.fs.s3a.AWSClientIOException | From | To | |
| Change Parameter Type clazz : Class to clazz : Class<E> in method public verifyExceptionClass(clazz Class<E>, ex Exception) : E in class org.apache.hadoop.fs.s3a.S3ATestUtils | From | To | |
| Change Parameter Type clazz : Class to clazz : Class<E> in method private verifyTranslated(clazz Class<E>, exception AmazonClientException) : E in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Move Method | 1 | ||
| Move Method public toString() : String from class org.apache.hadoop.fs.s3a.S3AFileSystem.WriteOperationHelper to public toString() : String from class org.apache.hadoop.fs.FSDataOutputStream | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private mapper : ObjectMapper from class org.apache.hadoop.registry.client.binding.JsonSerDeser to private mapper : ObjectMapper from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Attribute private LOG : Logger from class org.apache.hadoop.registry.client.binding.JsonSerDeser to private LOG : Logger from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Attribute private classType : Class<T> from class org.apache.hadoop.registry.client.binding.JsonSerDeser to private classType : Class<T> from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private retryPolicy : RetryPolicy from class org.apache.hadoop.fs.s3a.S3ABlockOutputStream to private retryPolicy : RetryPolicy from class org.apache.hadoop.fs.s3a.S3ARetryPolicy | From | To | |
| Move Attribute private retryPolicy : RetryPolicy from class org.apache.hadoop.fs.s3a.S3ABlockOutputStream to private retryPolicy : RetryPolicy from class org.apache.hadoop.fs.s3a.Invoker | From | To | |
| Move Attribute package ACCEPT_ALL : PathFilter from class org.apache.hadoop.fs.s3a.Listing to public ACCEPT_ALL : PathFilter from class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.fs.s3a.S3AFileSystem.WriteOperationHelper moved and renamed to org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type ex : AWSS3IOException to ex : AWSBadRequestException in method public testListEncryptedDir() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Change Variable Type timer : NanoTimer to timer : ContractTestUtils.NanoTimer in method protected delete(path Path, recursive boolean) : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type ex : AWSS3IOException to ex : AWSRedirectException in method public test301ContainsEndpoint() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Variable | 6 | ||
| Extract Variable parent : Path in method package maybeCreateFakeParentDirectory(path Path) : void from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable path : Path in method public put(meta DirListingMetadata) : void from class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Extract Variable interval : int in method public S3AInstrumentation(name URI) from class org.apache.hadoop.fs.s3a.S3AInstrumentation | From | To | |
| Extract Variable ex : E in method public intercept(clazz Class<E>, contained String, message String, eval Callable<T>) : E from class org.apache.hadoop.test.LambdaTestUtils | From | To | |
| Extract Variable bucket : String in method public test301ContainsEndpoint() : void from class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Variable sc301 : int in method public test301ContainsEndpoint() : void from class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method | 24 | ||
| Extract Method protected setUri(uri URI) : void extracted from public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected verifyTranslated(status int, expected Class<E>) : void extracted from public test401isNotPermittedFound() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method package deleteObjectAtPath(f Path, key String, isFile boolean) : void extracted from private innerDelete(status S3AFileStatus, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public abortOutstandingMultipartUploads(seconds long) : void extracted from private initMultipartUploads(conf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected delete(path Path, recursive boolean) : void extracted from protected deleteHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Extract Method public assertExceptionContains(expectedText String, t Throwable, message String) : void extracted from public assertExceptionContains(string String, t Throwable) : void in class org.apache.hadoop.test.GenericTestUtils | From | To | |
| Extract Method private validateListArguments(request S3ListRequest) : void extracted from protected continueListObjects(request S3ListRequest, prevResult S3ListResult) : S3ListResult in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected getMethodName() : String extracted from public nameThread() : void in class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Extract Method protected verifyTranslated(status int, expected Class<E>) : void extracted from public test404isNotFound() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method protected verifyTranslated(status int, expected Class<E>) : void extracted from public test416isEOF() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method private innerListObjectsV2(request ListObjectsV2Request) : ListObjectsV2Result extracted from public listObjectsV2(request ListObjectsV2Request) : ListObjectsV2Result in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Extract Method protected verifyTranslated(status int, expected Class<E>) : void extracted from public test410isNotFound() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method public intercept(clazz Class<E>, contained String, message String, eval VoidCallable) : E extracted from public intercept(clazz Class<E>, contained String, eval VoidCallable) : E in class org.apache.hadoop.test.LambdaTestUtils | From | To | |
| Extract Method package maybeCreateFakeParentDirectory(path Path) : void extracted from private innerDelete(status S3AFileStatus, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private initMultipartUpload() : void extracted from private uploadCurrentBlock() : void in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream | From | To | |
| Extract Method package maybeCreateFakeParentDirectory(path Path) : void extracted from private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public intercept(clazz Class<E>, contained String, message String, eval Callable<T>) : E extracted from public intercept(clazz Class<E>, contained String, eval VoidCallable) : E in class org.apache.hadoop.test.LambdaTestUtils | From | To | |
| Extract Method protected verifyTranslated(status int, expected Class<E>) : void extracted from public test403isNotPermittedFound() : void in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Extract Method private assumeFileExists(file Path) : void extracted from package assumeHugeFileExists() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Extract Method public intercept(clazz Class<E>, contained String, message String, eval Callable<T>) : E extracted from public intercept(clazz Class<E>, eval Callable<T>) : E in class org.apache.hadoop.test.LambdaTestUtils | From | To | |
| Extract Method public enableMultipartPurge(conf Configuration, seconds int) : void extracted from public createTestFileSystem(conf Configuration, purge boolean) : S3AFileSystem in class org.apache.hadoop.fs.s3a.S3ATestUtils | From | To | |
| Extract Method public translateDynamoDBException(message String, ex AmazonDynamoDBException) : IOException extracted from public translateException(operation String, path String, exception AmazonClientException) : IOException in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract Method private validateListArguments(request S3ListRequest) : void extracted from protected listObjects(request S3ListRequest) : S3ListResult in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private innerlistObjects(listObjectsRequest ListObjectsRequest) : ObjectListing extracted from public listObjects(listObjectsRequest ListObjectsRequest) : ObjectListing in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Rename Method | 2 | ||
| Rename Method package completeMultipartUpload(uploadId String, partETags List<PartETag>) : CompleteMultipartUploadResult renamed to public completeMPUwithRetries(destKey String, uploadId String, partETags List<PartETag>, length long, errorCount AtomicInteger) : CompleteMultipartUploadResult in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Rename Method private setMaxRetries(config Configuration) : void renamed to private initDataAccessRetries(config Configuration) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Pull Up Method | 12 | ||
| Pull Up Method public toBytes(instance T) : byte[] from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public toBytes(instance T) : byte[] from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public fromInstance(instance T) : T from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public fromInstance(instance T) : T from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public save(fs FileSystem, path Path, instance T, overwrite boolean) : void from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public save(fs FileSystem, path Path, instance T, overwrite boolean) : void from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public fromJson(json String) : T from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public fromJson(json String) : T from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public fromFile(jsonFile File) : T from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public load(jsonFile File) : T from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method private writeJsonAsBytes(instance T, dataOutputStream DataOutputStream) : void from class org.apache.hadoop.registry.client.binding.JsonSerDeser to private writeJsonAsBytes(instance T, dataOutputStream OutputStream) : void from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method private hasOutputPath() : boolean from class org.apache.hadoop.mapreduce.lib.output.FileOutputCommitter to public hasOutputPath() : boolean from class org.apache.hadoop.mapreduce.lib.output.PathOutputCommitter | From | To | |
| Pull Up Method public toString(instance T) : String from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public toString(instance T) : String from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public fromResource(resource String) : T from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public fromResource(resource String) : T from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public load(fs FileSystem, path Path) : T from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public load(fs FileSystem, path Path) : T from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public getName() : String from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public getName() : String from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Pull Up Method public toJson(instance T) : String from class org.apache.hadoop.registry.client.binding.JsonSerDeser to public toJson(instance T) : String from class org.apache.hadoop.util.JsonSerialization | From | To | |
| Rename Variable | 4 | ||
| Rename Variable filesize : long to size : long in method public test_050_readHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Rename Variable f : Path to path : Path in method public create(f Path, permission FsPermission, overwrite boolean, bufferSize int, replication short, blockSize long, progress Progressable) : FSDataOutputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Variable filesize : long to size : long in method public test_100_renameHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Rename Variable filesize : long to size : long in method public test_040_PositionedReadHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Return Type | 6 | ||
| Change Return Type Exception to E in method public verifyExceptionClass(clazz Class<E>, ex Exception) : E in class org.apache.hadoop.fs.s3a.S3ATestUtils | From | To | |
| Change Return Type Exception to E in method private verifyTranslated(clazz Class<E>, exception AmazonClientException) : E in class org.apache.hadoop.fs.s3a.TestS3AExceptionTranslation | From | To | |
| Change Return Type CompleteMultipartUploadResult to void in method private complete(partETags List<PartETag>) : void in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream.MultiPartUpload | From | To | |
| Change Return Type void to long in method public streamOpened() : long in class org.apache.hadoop.fs.s3a.S3AInstrumentation.InputStreamStatistics | From | To | |
| Change Return Type boolean to Exception in method package containsInterruptedException(thrown Throwable) : Exception in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Change Return Type void to int in method public abortMultipartUploadsUnderPath(prefix String) : int in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute s3afs : S3AFileSystem to owner : S3AFileSystem in method public initialize(fs FileSystem) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable f : Path to path : Path in method package maybeCreateFakeParentDirectory(path Path) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Parameterize Variable purgeExistingMultipartAge : long to seconds : long in method public abortOutstandingMultipartUploads(seconds long) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.util.JsonSerialization from classes [org.apache.hadoop.registry.client.binding.JsonSerDeser] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type writeOperationHelper : S3AFileSystem.WriteOperationHelper to writeOperationHelper : WriteOperationHelper in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter e : Exception to ex : Exception in method public writeFailed(ex Exception) : void in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Rename Parameter key : String to owner : S3AFileSystem in method protected WriteOperationHelper(owner S3AFileSystem) in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To | |
| Rename Parameter string : String to expectedText : String in method public assertExceptionContains(expectedText String, t Throwable) : void in class org.apache.hadoop.test.GenericTestUtils | From | To | |
| Rename Parameter name : URI to uri : URI in method protected setUri(uri URI) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter uploadId : String to prefix : String in method public abortMultipartUploadsUnderPath(prefix String) : int in class org.apache.hadoop.fs.s3a.WriteOperationHelper | From | To |