e02eb24e0a9139418120027b694492e0738df20a
Files Diff
- Added: 19
- Removed: 0
- Renamed: 0
- Modified: 52
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method package removeKeys(keysToDelete List<DeleteObjectsRequest.KeyVersion>, clearKeys boolean, deleteFakeDir boolean) : void renamed to private removeKeysS3(keysToDelete List<DeleteObjectsRequest.KeyVersion>, deleteFakeDir boolean) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Method public testTableVersionRequired() : void renamed to public testTableVersioning() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public executeRestrictedRename(conf Configuration) : void from class org.apache.hadoop.fs.s3a.auth.ITestAssumeRole to public testRenameParentPathNotWriteable() : void from class org.apache.hadoop.fs.s3a.impl.ITestPartialRenamesDeletes | From | To | |
| Move And Rename Method public translateMultiObjectDeleteException(message String, ex MultiObjectDeleteException) : IOException from class org.apache.hadoop.fs.s3a.S3AUtils to public translateDeleteException(message String, deleteException MultiObjectDeleteException) : IOException from class org.apache.hadoop.fs.s3a.impl.MultiObjectDeleteSupport | From | To | |
| Change Parameter Type | 8 | ||
| Change Parameter Type metas : Collection<PathMetadata> to metas : Collection<? extends PathMetadata> in method public put(metas Collection<? extends PathMetadata>, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Change Parameter Type iterator : RemoteIterator<LocatedFileStatus> to iterator : RemoteIterator<? extends LocatedFileStatus> in method public applyLocatedFiles(iterator RemoteIterator<? extends LocatedFileStatus>, eval CallOnLocatedFileStatus) : long in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Change Parameter Type iterator : RemoteIterator<LocatedFileStatus> to iterator : RemoteIterator<? extends LocatedFileStatus> in method public mapLocatedFiles(iterator RemoteIterator<? extends LocatedFileStatus>, eval LocatedFileStatusMap<T>) : List<T> in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Change Parameter Type metas : Collection<PathMetadata> to metas : Collection<? extends PathMetadata> in method public put(metas Collection<? extends PathMetadata>, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.MetadataStore | From | To | |
| Change Parameter Type fileMetas : Collection<PathMetadata> to fileMetas : Collection<? extends PathMetadata> in method public putWithTtl(ms MetadataStore, fileMetas Collection<? extends PathMetadata>, timeProvider ITtlTimeProvider, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Change Parameter Type ms : MetadataStore to ms : DynamoDBMetadataStore in method private cleanupMetadata(ms DynamoDBMetadataStore, pm PathMetadata) : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStoreScale | From | To | |
| Change Parameter Type pathMetadatas : Collection<PathMetadata> to pathMetadatas : Collection<? extends PathMetadata> in method package pathMetaToDDBPathMeta(pathMetadatas Collection<? extends PathMetadata>) : List<DDBPathMetadata> in class org.apache.hadoop.fs.s3a.s3guard.PathMetadataDynamoDBTranslation | From | To | |
| Change Parameter Type metas : Collection<PathMetadata> to metas : Collection<? extends PathMetadata> in method public put(metas Collection<? extends PathMetadata>, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Move Method | 2 | ||
| Move Method private assertFileCount(text String, fs FileSystem, path Path, expected long) : void from class org.apache.hadoop.fs.s3a.auth.ITestAssumeRole to public assertFileCount(message String, fs FileSystem, path Path, expected long) : void from class org.apache.hadoop.fs.s3a.test.ExtraAssertions | From | To | |
| Move Method public addAncestors(metadataStore MetadataStore, qualifiedPath Path, username String, timeProvider ITtlTimeProvider) : void from class org.apache.hadoop.fs.s3a.s3guard.S3Guard to public addAncestors(qualifiedPath Path, ttlTimeProvider ITtlTimeProvider, operationState BulkOperationState) : void from class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Rename Variable | 3 | ||
| Rename Variable destDateset : byte[] to destDataset : byte[] in method public testRenameDirIntoExistingDir() : void in class org.apache.hadoop.fs.contract.s3a.ITestS3AContractRename | From | To | |
| Rename Variable contentLength : long to l : long in method public S3AInputStream(ctx S3AReadOpContext, s3Attributes S3ObjectAttributes, client AmazonS3) in class org.apache.hadoop.fs.s3a.S3AInputStream | From | To | |
| Rename Variable testFile : Path to csvPath : Path in method public testMultiObjectDeleteNoPermissions() : void in class org.apache.hadoop.fs.s3a.ITestS3AFailureHandling | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Collection<DDBPathMetadata> to List<DDBPathMetadata> in method package fullPathsToPut(meta DDBPathMetadata, operationState BulkOperationState) : List<DDBPathMetadata> in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Change Return Type boolean to long in method private innerRename(source Path, dest Path) : long in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStoreScale.ThrottleTracker moved to org.apache.hadoop.fs.s3a.s3guard.ThrottleTracker | From | To | |
| Extract Variable | 6 | ||
| Extract Variable finalFile : String in method public testMovePopulatesAncestors() : void from class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Extract Variable fs : S3AFileSystem in method public testBaseRelativePath() : void from class org.apache.hadoop.fs.s3a.commit.ITestCommitOperations | From | To | |
| Extract Variable unguardedConf : Configuration in method public run(args String[], out PrintStream) : int from class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool.BucketInfo | From | To | |
| Extract Variable fsURI : URI in method public run(args String[], out PrintStream) : int from class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool.BucketInfo | From | To | |
| Extract Variable now : long in method public putWithTtl(ms MetadataStore, dirMeta DirListingMetadata, timeProvider ITtlTimeProvider, operationState BulkOperationState) : void from class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract Variable fs : S3AFileSystem in method private testPruneCommand(cmdConf Configuration, parent Path, args String...) : void from class org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type metasToPut : Collection<DDBPathMetadata> to metasToPut : List<DDBPathMetadata> in method public put(meta DirListingMetadata, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Change Variable Type deletionBatch : Collection<Path> to deletionBatch : ArrayList<Path> in method private innerPrune(keyPrefix String, items ItemCollection<ScanOutcome>) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Change Variable Type metasToPut : Collection<DDBPathMetadata> to metasToPut : List<DDBPathMetadata> in method package fullPathsToPut(meta DDBPathMetadata, operationState BulkOperationState) : List<DDBPathMetadata> in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Change Variable Type newItems : Collection<DDBPathMetadata> to newItems : List<DDBPathMetadata> in method public move(pathsToDelete Collection<Path>, pathsToCreate Collection<PathMetadata>, ttlTimeProvider ITtlTimeProvider, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Extract Method | 20 | ||
| Extract Method private destroy(ddbms DynamoDBMetadataStore) : void extracted from public testTableVersionRequired() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Extract Method private unwrapInnerException(e Throwable) : IOException extracted from public raiseInnerCause(e ExecutionException) : T in class org.apache.hadoop.fs.impl.FutureIOSupport | From | To | |
| Extract Method private initiateRename(src Path, dst Path) : Pair<S3AFileStatus,S3AFileStatus> extracted from private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private noteDeleted(count int, deleteFakeDir boolean) : void extracted from package removeKeys(keysToDelete List<DeleteObjectsRequest.KeyVersion>, clearKeys boolean, deleteFakeDir boolean) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method protected get(pathStr String) : PathMetadata extracted from private assertDeleted(pathStr String) : void in class org.apache.hadoop.fs.s3a.s3guard.MetadataStoreTestBase | From | To | |
| Extract Method private destroy(ddbms DynamoDBMetadataStore) : void extracted from public afterClassTeardown() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Extract Method private commitOrFail(destFile Path, commit SinglePendingCommit, actions CommitOperations) : void extracted from private commit(filename String, magicFile Path, destFile Path, throttle float, failures int) : void in class org.apache.hadoop.fs.s3a.commit.ITestCommitOperations | From | To | |
| Extract Method private createObjectAttributes(fileStatus S3AFileStatus) : S3ObjectAttributes extracted from private select(source Path, expression String, options Configuration) : FSDataInputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method public forbidden(message String, contained String, eval Callable<T>) : AccessDeniedException extracted from public forbidden(contained String, eval Callable<T>) : AccessDeniedException in class org.apache.hadoop.fs.s3a.auth.RoleTestUtils | From | To | |
| Extract Method private destroy(ddbms DynamoDBMetadataStore) : void extracted from public testInitializeWithConfiguration() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Extract Method private buildDeleteRequest(keys String[]) : List<DeleteObjectsRequest.KeyVersion> extracted from private removeKeys(fileSystem S3AFileSystem, keys String...) : void in class org.apache.hadoop.fs.s3a.ITestS3AFailureHandling | From | To | |
| Extract Method private createObjectAttributes(fileStatus S3AFileStatus) : S3ObjectAttributes extracted from private open(path Path, options Optional<Configuration>) : FSDataInputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private destroy(ddbms DynamoDBMetadataStore) : void extracted from public testInitialize() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStore | From | To | |
| Extract Method public putAndReturn(ms MetadataStore, status S3AFileStatus, instrumentation S3AInstrumentation, timeProvider ITtlTimeProvider, operationState BulkOperationState) : S3AFileStatus extracted from public putAndReturn(ms MetadataStore, status S3AFileStatus, instrumentation S3AInstrumentation, timeProvider ITtlTimeProvider) : S3AFileStatus in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract Method private expectThrottling() : boolean extracted from public test_030_BatchedWrite() : void in class org.apache.hadoop.fs.s3a.s3guard.ITestDynamoDBMetadataStoreScale | From | To | |
| Extract Method public put(meta PathMetadata, operationState BulkOperationState) : void extracted from public put(meta PathMetadata) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Extract Method public put(meta PathMetadata, operationState BulkOperationState) : void extracted from public put(meta PathMetadata) : void in class org.apache.hadoop.fs.s3a.ITestS3AMetadataPersistenceException.IOExceptionMetadataStore | From | To | |
| Extract Method public put(meta PathMetadata, operationState BulkOperationState) : void extracted from public put(meta PathMetadata) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Extract Method package patchLastUpdated(fileMetas Collection<? extends PathMetadata>, timeProvider ITtlTimeProvider) : void extracted from public putWithTtl(ms MetadataStore, fileMetas Collection<PathMetadata>, timeProvider ITtlTimeProvider) : void in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract And Move Method | 5 | ||
| Extract And Move Method protected terminateCluster(clusterBinding ClusterBinding) : void extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitMRJobBadDest & moved to class org.apache.hadoop.fs.s3a.commit.AbstractYarnClusterITest | From | To | |
| Extract And Move Method protected terminateCluster(clusterBinding ClusterBinding) : void extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.staging.integration.ITestDirectoryCommitMRJob & moved to class org.apache.hadoop.fs.s3a.commit.AbstractYarnClusterITest | From | To | |
| Extract And Move Method protected terminateCluster(clusterBinding ClusterBinding) : void extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.staging.integration.ITestPartitionCommitMRJob & moved to class org.apache.hadoop.fs.s3a.commit.AbstractYarnClusterITest | From | To | |
| Extract And Move Method protected terminateCluster(clusterBinding ClusterBinding) : void extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.magic.ITestMagicCommitMRJob & moved to class org.apache.hadoop.fs.s3a.commit.AbstractYarnClusterITest | From | To | |
| Extract And Move Method protected terminateCluster(clusterBinding ClusterBinding) : void extracted from public teardownClusters() : void in class org.apache.hadoop.fs.s3a.commit.staging.integration.ITestStagingCommitMRJob & moved to class org.apache.hadoop.fs.s3a.commit.AbstractYarnClusterITest | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter ex : MultiObjectDeleteException to deleteException : MultiObjectDeleteException in method public translateDeleteException(message String, deleteException MultiObjectDeleteException) : IOException in class org.apache.hadoop.fs.s3a.impl.MultiObjectDeleteSupport | From | To | |
| Rename Parameter text : String to message : String in method public assertFileCount(message String, fs FileSystem, path Path, expected long) : void in class org.apache.hadoop.fs.s3a.test.ExtraAssertions | From | To | |
| Rename Parameter timeProvider : ITtlTimeProvider to ttlTimeProvider : ITtlTimeProvider in method public addAncestors(qualifiedPath Path, ttlTimeProvider ITtlTimeProvider, operationState BulkOperationState) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To |