e27c2ae8bafc94f18eb38f5d839dcef5652d424e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private chooseExcessReplicasContiguous(bc BlockCollection, nonExcess Collection<DatanodeStorageInfo>, storedBlock BlockInfo, replication short, addedNode DatanodeDescriptor, delNodeHint DatanodeDescriptor, excessTypes List<StorageType>) : void from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager to public chooseReplicasToDelete(candidates Collection<DatanodeStorageInfo>, expectedNumOfReplicas int, excessTypes List<StorageType>, addedNode DatanodeDescriptor, delNodeHint DatanodeDescriptor) : List<DatanodeStorageInfo> from class org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyDefault | From | To | |
| Move Method | 2 | ||
| Move Method package useDelHint(isFirst boolean, delHint DatanodeStorageInfo, added DatanodeStorageInfo, moreThan1Racks List<DatanodeStorageInfo>, excessTypes List<StorageType>) : boolean from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager to package useDelHint(isFirst boolean, delHint DatanodeStorageInfo, added DatanodeStorageInfo, moreThan1Racks List<DatanodeStorageInfo>, excessTypes List<StorageType>) : boolean from class org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyDefault | From | To | |
| Move Method package hasClusterEverBeenMultiRack() : boolean from class org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager to public hasClusterEverBeenMultiRack() : boolean from class org.apache.hadoop.net.NetworkTopology | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to List<DatanodeStorageInfo> in method public chooseReplicasToDelete(candidates Collection<DatanodeStorageInfo>, expectedNumOfReplicas int, excessTypes List<StorageType>, addedNode DatanodeDescriptor, delNodeHint DatanodeDescriptor) : List<DatanodeStorageInfo> in class org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyDefault | From | To | |
| Merge Parameter | 1 | ||
| Merge Parameter [srcPath : String, lBlk : LocatedBlock] to locs : DatanodeInfo[] in method public verifyBlockPlacement(locs DatanodeInfo[], numberOfReplicas int) : BlockPlacementStatus in class org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyWithUpgradeDomain | From | To | |
| Extract Method | 1 | ||
| Extract Method protected incrementRacks() : void extracted from public add(node Node) : void in class org.apache.hadoop.net.NetworkTopology | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected incrementRacks() : void extracted from public add(node Node) : void in class org.apache.hadoop.net.NetworkTopologyWithNodeGroup & moved to class org.apache.hadoop.net.NetworkTopology | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter nonExcess : Collection<DatanodeStorageInfo> to candidates : Collection<DatanodeStorageInfo> in method public chooseReplicasToDelete(candidates Collection<DatanodeStorageInfo>, expectedNumOfReplicas int, excessTypes List<StorageType>, addedNode DatanodeDescriptor, delNodeHint DatanodeDescriptor) : List<DatanodeStorageInfo> in class org.apache.hadoop.hdfs.server.blockmanagement.BlockPlacementPolicyDefault | From | To |