eb08543c7a5d1fd97a1915dbc5a11a2ba2066ba1
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private assertOutputContains(messages String...) : void renamed to private assertErrorContains(messages String...) : void in class org.apache.hadoop.yarn.client.cli.TestNodeAttributesCLI | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private buildNodeLabelsMapFromStr(args String, validateForAttributes boolean, operation AttributeMappingOperationType) : List<NodeToAttributes> from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI to private buildNodeLabelsListFromStr(args String, validateForAttributes boolean, operation String) : List<NodeToAttributes> from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type operation : AttributeMappingOperationType to operation : String in method private buildNodeLabelsListFromStr(args String, validateForAttributes boolean, operation String) : List<NodeToAttributes> in class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler | From | To | |
| Move Method | 3 | ||
| Move Method public setConf(conf Configuration) : void from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI to public setConf(conf Configuration) : void from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler | From | To | |
| Move Method private addSecurityConfiguration(conf Configuration) : Configuration from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI to private addSecurityConfiguration(conf Configuration) : Configuration from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler | From | To | |
| Move Method protected createAdminProtocol() : ResourceManagerAdministrationProtocol from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI to protected createAdminProtocol() : ResourceManagerAdministrationProtocol from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler | From | To | |
| Inline Method | 1 | ||
| Inline Method private handleNodeAttributeMapping(args String[], operation AttributeMappingOperationType) : int inlined to public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI | From | To | |
| Change Return Type | 5 | ||
| Change Return Type Map<String,Set<NodeAttribute>> to Set<NodeAttribute> in method public getAllNodeAttributes() : Set<NodeAttribute> in class org.apache.hadoop.yarn.sls.scheduler.RMNodeWrapper | From | To | |
| Change Return Type Map<String,Set<NodeAttribute>> to Set<NodeAttribute> in method public getAllNodeAttributes() : Set<NodeAttribute> in class org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNodeImpl | From | To | |
| Change Return Type Map<String,Set<NodeAttribute>> to Set<NodeAttribute> in method public getAllNodeAttributes() : Set<NodeAttribute> in class org.apache.hadoop.yarn.sls.nodemanager.NodeInfo.FakeRMNodeImpl | From | To | |
| Change Return Type Map<String,Set<NodeAttribute>> to Set<NodeAttribute> in method public getAllNodeAttributes() : Set<NodeAttribute> in class org.apache.hadoop.yarn.server.resourcemanager.rmnode.RMNode | From | To | |
| Change Return Type Map<String,Set<NodeAttribute>> to Set<NodeAttribute> in method public getAllNodeAttributes() : Set<NodeAttribute> in class org.apache.hadoop.yarn.server.resourcemanager.MockNodes.MockRMNodeImpl | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI.AdminCommandHandler from class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute request : NodesToAttributesMappingRequest to nodeToAttrRequest : NodesToAttributesMappingRequest in class org.apache.hadoop.yarn.client.cli.TestNodeAttributesCLI | From | To | |
| Extract Method | 2 | ||
| Extract Method private getNodeReports(noOfNodes int, state NodeState, emptyNodeLabel boolean, emptyResourceUtilization boolean, emptyAttributes boolean) : List<NodeReport> extracted from private getNodeReports(noOfNodes int, state NodeState, emptyNodeLabel boolean, emptyResourceUtilization boolean) : List<NodeReport> in class org.apache.hadoop.yarn.client.cli.TestYarnCLI | From | To | |
| Extract Method private handleHelpCommand(args String[], handlers CommandHandler...) : boolean extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.NodeAttributesCLI | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter emptyResourceUtilization : boolean to emptyAttributes : boolean in method private getNodeReports(noOfNodes int, state NodeState, emptyNodeLabel boolean, emptyAttributes boolean) : List<NodeReport> in class org.apache.hadoop.yarn.client.cli.TestYarnCLI | From | To |