eb471632349deac4b62f8dec853c8ceb64c9617a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private showMetaInfo(request ContainerLogsRequest, logCliHelper LogCLIHelpers) : int renamed to private showApplicationLogInfo(request ContainerLogsRequest, logCliHelper LogCLIHelpers) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Rename Method public printLogMetadata(options ContainerLogsRequest, out PrintStream, err PrintStream) : void renamed to public printAContainerLogMetadata(options ContainerLogsRequest, out PrintStream, err PrintStream) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Rename Variable | 4 | ||
| Rename Variable containers : List<ContainerReport> to reports : List<ContainerReport> in method private getContainersLogRequestForRunningApplication(options ContainerLogsRequest) : List<ContainerLogsRequest> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Rename Variable showMetaInfo : boolean to showContainerLogInfo : boolean in method private runCommand(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Rename Variable logFiles : List<String> to logFileInfos : List<PerLogFileInfo> in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Rename Variable yarnClient : YarnClient to client : YarnClient in method protected createYarnClient() : YarnClient in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Return Type | 3 | ||
| Change Return Type String to Pair<String,String> in method public readContainerMetaDataAndSkipData(valueStream DataInputStream, out PrintStream) : Pair<String,String> in class org.apache.hadoop.yarn.logaggregation.AggregatedLogFormat.LogReader | From | To | |
| Change Return Type List<String> to List<PerLogFileInfo> in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Return Type void to int in method public printAContainerLogMetadata(options ContainerLogsRequest, out PrintStream, err PrintStream) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute appState : YarnApplicationState to yarnClient : YarnClient in method public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute SHOW_META_INFO : String to SHOW_CONTAINER_LOG_INFO : String in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type logFiles : List<String> to logFileInfos : List<PerLogFileInfo> in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type appState : YarnApplicationState to yarnClient : YarnClient in method public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Variable | 1 | ||
| Extract Variable httpAddress : String in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logCliHelper LogCLIHelpers) : int from class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method | 2 | ||
| Extract Method private getContainerReportsFromRunningApplication(options ContainerLogsRequest) : List<ContainerReport> extracted from private getContainersLogRequestForRunningApplication(options ContainerLogsRequest) : List<ContainerLogsRequest> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private runCommand(args String[]) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To |