ee5495456eac53d5ee00254184384b4c8246cbbf
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private allocatePipelineNodes(replicationFactor OzoneProtos.ReplicationFactor) : List<DatanodeID> renamed to public allocatePipelineChannel(factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl | From | To | |
| Merge Attribute | 1 | ||
| Merge Attribute [datanodes : Map<String,DatanodeID>, leaderID : String] to pipelineChannel : PipelineChannel in class org.apache.hadoop.scm.container.common.helpers.Pipeline | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method package findOpenPipeline(factor OzoneProtos.ReplicationFactor) : Pipeline from class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl to private findOpenPipelineChannel(type ReplicationType, factor ReplicationFactor) : PipelineChannel from class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type factor : OzoneProtos.ReplicationFactor to factor : ReplicationFactor in method protected getReplicationCount(factor ReplicationFactor) : int in class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Change Parameter Type replicationFactor : OzoneProtos.ReplicationFactor to factor : ReplicationFactor in method public allocatePipelineChannel(factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl | From | To | |
| Change Parameter Type factor : OzoneProtos.ReplicationFactor to factor : ReplicationFactor in method private findOpenPipelineChannel(type ReplicationType, factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Move Method | 3 | ||
| Move Method private getReplicationCount(factor OzoneProtos.ReplicationFactor) : int from class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl to protected getReplicationCount(factor ReplicationFactor) : int from class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Move Method public addMember(dataNodeId DatanodeID) : void from class org.apache.hadoop.scm.container.common.helpers.Pipeline to public addMember(dataNodeId DatanodeID) : void from class org.apache.hadoop.scm.container.common.helpers.PipelineChannel | From | To | |
| Move Method private getNextIndex() : int from class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl to private getNextIndex() : int from class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Rename Variable | 4 | ||
| Rename Variable pipeline : Pipeline to newPipeline : Pipeline in method private writeChunkHelper(containerName String, keyName String, pipeline Pipeline) : ChunkInfo in class org.apache.hadoop.ozone.container.common.impl.TestContainerPersistence | From | To | |
| Rename Variable pipeline : Pipeline to pipelineChannel : PipelineChannel in method public createPipeline(containerName String, ids Iterable<DatanodeID>) : Pipeline in class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Rename Variable pipeline : Pipeline to newPipeline : Pipeline in method public getWriteSmallFileRequest(pipeline Pipeline, containerName String, keyName String, dataLen int) : ContainerCommandRequestProto in class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Rename Variable pipeline : Pipeline to pipelineChannel : PipelineChannel in method public newPipelineFromNodes(nodes List<DatanodeID>, state LifeCycleState, replicationType ReplicationType, replicationFactor ReplicationFactor, name String) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.PipelineSelector | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Pipeline to PipelineChannel in method public newPipelineFromNodes(nodes List<DatanodeID>, state LifeCycleState, replicationType ReplicationType, replicationFactor ReplicationFactor, name String) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.PipelineSelector | From | To | |
| Change Return Type Pipeline to PipelineChannel in method private findOpenPipelineChannel(type ReplicationType, factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.PipelineManager | From | To | |
| Change Return Type List<DatanodeID> to PipelineChannel in method public allocatePipelineChannel(factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private leaderID : String from class org.apache.hadoop.scm.container.common.helpers.Pipeline to private leaderID : String from class org.apache.hadoop.scm.container.common.helpers.PipelineChannel | From | To | |
| Move Attribute private datanodes : Map<String,DatanodeID> from class org.apache.hadoop.scm.container.common.helpers.Pipeline to private datanodes : Map<String,DatanodeID> from class org.apache.hadoop.scm.container.common.helpers.PipelineChannel | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.scm.container.common.helpers.PipelineChannel from class org.apache.hadoop.scm.container.common.helpers.Pipeline | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type pipeline : Pipeline to pipelineChannel : PipelineChannel in method public newPipelineFromNodes(nodes List<DatanodeID>, state LifeCycleState, replicationType ReplicationType, replicationFactor ReplicationFactor, name String) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.PipelineSelector | From | To | |
| Change Variable Type pipeline : Pipeline to pipelineChannel : PipelineChannel in method public createPipeline(containerName String, ids Iterable<DatanodeID>) : Pipeline in class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Extract Method | 1 | ||
| Extract Method public getPipelineChannel() : PipelineChannel extracted from public getFromProtoBuf(pipeline OzoneProtos.Pipeline) : Pipeline in class org.apache.hadoop.scm.container.common.helpers.Pipeline | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter leaderID : String to containerName : String in method public Pipeline(containerName String, pipelineChannel PipelineChannel) in class org.apache.hadoop.scm.container.common.helpers.Pipeline | From | To | |
| Rename Parameter replicationFactor : OzoneProtos.ReplicationFactor to factor : ReplicationFactor in method public allocatePipelineChannel(factor ReplicationFactor) : PipelineChannel in class org.apache.hadoop.ozone.scm.pipelines.ratis.RatisManagerImpl | From | To |