hadoop ef1757790d89cc72f88f5330761b1c8901c59e94

ef1757790d89cc72f88f5330761b1c8901c59e94

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 3

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	2
Rename Method public setAmContainerId(amContainerId String) : void renamed to public setContainerId(containerId String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Rename Method public getAmContainerId() : String renamed to public getContainerId() : String in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Change Parameter Type	2
Change Parameter Type isAppFinished : boolean to applicationId : ApplicationId in method public ContainerLogsRequest(applicationId ApplicationId, isAppFinished boolean, owner String, address String, httpAddress String, container String) in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Change Parameter Type request : AMLogsRequest to request : ContainerLogsRequest in method private outputAMContainerLogs(request ContainerLogsRequest, conf Configuration, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Variable	3
Rename Variable appStateObtainedSuccessfully : boolean to request : ContainerLogsRequest in method public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Variable request : AMLogsRequest to amRequest : ContainerLogsRequest in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Class	1
Rename Class org.apache.hadoop.yarn.client.cli.LogsCLI.AMLogsRequest renamed to org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Merge Variable	4
Merge Variable [request : AMLogsRequest, appId : String] to amRequest : ContainerLogsRequest in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Variable [appIdStr : String, containerIdStr : String, nodeId : String] to request : ContainerLogsRequest in method private fetchContainerLogs(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Variable [appId : String, containerId : String, nodeId : String] to request : ContainerLogsRequest in method private outputAMContainerLogs(request ContainerLogsRequest, conf Configuration, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Variable [containerId : ContainerId, nodeHttpAddress : String, nodeId : String] to request : ContainerLogsRequest in method private fetchContainerLogs(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Parameter	5
Merge Parameter [appOwner : String, appId : ApplicationId] to request : ContainerLogsRequest in method private fetchAMContainerLogs(request ContainerLogsRequest, amContainersList List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Parameter [nodeAddress : String, appOwner : String] to request : ContainerLogsRequest in method private printContainerLogsForFinishedApplication(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Parameter [appId : ApplicationId, appOwner : String] to request : ContainerLogsRequest in method private showNodeLists(request ContainerLogsRequest, logCliHelper LogCLIHelpers) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Parameter [appId : ApplicationId, containerIdStr : String, nodeAddress : String, appOwner : String] to request : ContainerLogsRequest in method private showMetaInfo(request ContainerLogsRequest, logCliHelper LogCLIHelpers) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Merge Parameter [appOwner : String, nodeAddress : String] to request : ContainerLogsRequest in method private fetchContainerLogs(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Attribute	1
Rename Attribute amContainerId : String to containerId : String in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Extract Variable	1
Extract Variable out : PrintStream in method public dumpAContainersLogsForALogTypeWithoutNodeId(appId String, containerId String, jobOwner String, logType List<String>, localDir String) : int from class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers	From	To
Change Variable Type	4
Change Variable Type requests : List<AMLogsRequest> to requests : List<ContainerLogsRequest> in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Change Variable Type appStateObtainedSuccessfully : boolean to request : ContainerLogsRequest in method public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Change Variable Type request : AMLogsRequest to amRequest : ContainerLogsRequest in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Extract Method	7
Extract Method private getContainerLogsStream(containerIdStr String, reader AggregatedLogFormat.LogReader) : DataInputStream extracted from public dumpAContainerLogs(containerIdStr String, reader AggregatedLogFormat.LogReader, out PrintStream, logUploadedTime long) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers	From	To
Extract Method public setAppId(appId ApplicationId) : void extracted from package AMLogsRequest(isAppFinished boolean) in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Extract Method private printContainerLogsForFinishedApplication(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void extracted from private fetchContainerLogs(appState YarnApplicationState, appStateObtainedSuccessfully boolean, logFiles String[], appOwner String, nodeAddress String, containerId ContainerId, logCliHelper LogCLIHelpers) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Extract Method private getContainerLogsStream(containerIdStr String, reader AggregatedLogFormat.LogReader) : DataInputStream extracted from public dumpAContainerLogsForALogType(containerIdStr String, reader AggregatedLogFormat.LogReader, out PrintStream, logUploadedTime long, logType List<String>) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers	From	To
Extract Method public setAppOwner(appOwner String) : void extracted from package AMLogsRequest(isAppFinished boolean) in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Extract Method private fetchApplicationLogs(appId ApplicationId, appOwner String, logCliHelper LogCLIHelpers, localDir String) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Extract Method public setAppFinished(appFinished boolean) : void extracted from package AMLogsRequest(isAppFinished boolean) in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Rename Parameter	10
Rename Parameter appOwner : String to localDir : String in method private fetchContainerLogs(request ContainerLogsRequest, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter appOwner : String to localDir : String in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter amContainerId : String to containerId : String in method public setContainerId(containerId String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Rename Parameter appId : String to localDir : String in method private printAMContainerLogs(conf Configuration, request ContainerLogsRequest, amContainers List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter isAppFinished : boolean to appFinished : boolean in method public setAppFinished(appFinished boolean) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Rename Parameter appOwner : String to localDir : String in method private outputAMContainerLogs(request ContainerLogsRequest, conf Configuration, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter isAppFinished : boolean to applicationId : ApplicationId in method public ContainerLogsRequest(applicationId ApplicationId, isAppFinished boolean, owner String, address String, httpAddress String, container String) in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To
Rename Parameter appOwner : String to localDir : String in method private fetchAMContainerLogs(request ContainerLogsRequest, amContainersList List<String>, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter appId : String to localDir : String in method private outputAMContainerLogs(request ContainerLogsRequest, conf Configuration, logFiles String[], logCliHelper LogCLIHelpers, localDir String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI	From	To
Rename Parameter nodeId : String to nodeAddress : String in method public setNodeId(nodeAddress String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI.ContainerLogsRequest	From	To

ef1757790d89cc72f88f5330761b1c8901c59e94

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: