f0d5382ff3e31a47d13e4cb6c3a244cca82b17ce
Files Diff
- Added: 5
- Removed: 0
- Renamed: 0
- Modified: 24
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Change Return Type | 1 | ||
Change Return Type void to boolean in method public copyINodeDefaultAcl(child INode) : boolean in class org.apache.hadoop.hdfs.server.namenode.AclStorage | From | To | |
Extract Variable | 4 | ||
Extract Variable masked : FsPermission in method public create(controller RpcController, req CreateRequestProto) : CreateResponseProto from class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB | From | To | |
Extract Variable builder : MkdirsRequestProto.Builder in method public mkdirs(src String, masked FsPermission, createParent boolean) : boolean from class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolTranslatorPB | From | To | |
Extract Variable masked : FsPermission in method private put(ugi UserGroupInformation, delegation DelegationParam, username UserParam, doAsUser DoAsParam, fullpath String, op PutOpParam, destination DestinationParam, owner OwnerParam, group GroupParam, permission PermissionParam, unmaskedPermission UnmaskedPermissionParam, overwrite OverwriteParam, bufferSize BufferSizeParam, replication ReplicationParam, blockSize BlockSizeParam, modificationTime ModificationTimeParam, accessTime AccessTimeParam, renameOptions RenameOptionSetParam, createParent CreateParentParam, delegationTokenArgument TokenArgumentParam, aclPermission AclPermissionParam, xattrName XAttrNameParam, xattrValue XAttrValueParam, xattrSetFlag XAttrSetFlagParam, snapshotName SnapshotNameParam, oldSnapshotName OldSnapshotNameParam, exclDatanodes ExcludeDatanodesParam, createFlagParam CreateFlagParam, noredirectParam NoRedirectParam) : Response from class org.apache.hadoop.hdfs.server.namenode.web.resources.NamenodeWebHdfsMethods | From | To | |
Extract Variable masked : FsPermission in method public mkdirs(controller RpcController, req MkdirsRequestProto) : MkdirsResponseProto from class org.apache.hadoop.hdfs.protocolPB.ClientNamenodeProtocolServerSideTranslatorPB | From | To | |
Extract Method | 2 | ||
Extract Method private copyINodeDefaultAcl(child INode, modes FsPermission) : void extracted from public addLastINode(existing INodesInPath, inode INode, checkQuota boolean) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirectory | From | To | |
Extract Method protected initConf() : void extracted from public setUp() : void in class org.apache.hadoop.cli.TestAclCLI | From | To |