hadoop f365957c6326f88734bc0a5d01cfb7eac713db20

f365957c6326f88734bc0a5d01cfb7eac713db20

Files Diff

Added: 25
Removed: 0
Renamed: 0
Modified: 47

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move Method	3
Move Method protected getLandsatCSVFile() : String from class org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase to public getLandsatCSVFile(conf Configuration) : String from class org.apache.hadoop.fs.s3a.S3ATestUtils	From	To
Move Method protected exec(cmd S3GuardTool, buf ByteArrayOutputStream, args String...) : void from class org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase to public exec(expectedResult int, errorText String, cmd S3GuardTool, buf ByteArrayOutputStream, args String...) : void from class org.apache.hadoop.fs.s3a.s3guard.S3GuardToolTestHelper	From	To
Move Method public exec(cmd S3GuardTool, args String...) : String from class org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase to public exec(cmd S3GuardTool, args String...) : String from class org.apache.hadoop.fs.s3a.s3guard.S3GuardToolTestHelper	From	To
Pull Up Attribute	2
Pull Up Attribute private options : Configuration from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to private options : Configuration from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Attribute private mandatoryKeys : Set<String> from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to private mandatoryKeys : Set<String> from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Move Attribute	2
Move Attribute private path : Path from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to private path : Path from class org.apache.hadoop.fs.s3a.select.CsvFile	From	To
Move Attribute private path : Path from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to private path : Path from class org.apache.hadoop.fs.s3a.S3AReadOpContext	From	To
Extract Attribute	1
Extract Attribute public E_NEGATIVE_READAHEAD_VALUE : String in class org.apache.hadoop.fs.s3a.S3AInputStream	From	To
Merge Parameter	1
Merge Parameter [inputPolicy : S3AInputPolicy, readahead : long] to ctx : S3AReadOpContext in method public S3AInputStream(ctx S3AReadOpContext, s3Attributes S3ObjectAttributes, contentLength long, client AmazonS3) in class org.apache.hadoop.fs.s3a.S3AInputStream	From	To
Extract Variable	1
Extract Variable path : Path in method public createRecordReader(genericSplit InputSplit, context TaskAttemptContext) : RecordReader<Text,Text> from class org.apache.hadoop.streaming.mapreduce.StreamInputFormat	From	To
Change Variable Type	4
Change Variable Type fs : FileSystem to builder : FutureDataInputStreamBuilder in method public initialize(job Configuration, splitStart long, splitLength long, file Path) : void in class org.apache.hadoop.mapreduce.lib.input.FixedLengthRecordReader	From	To
Change Variable Type fs : FileSystem to builder : FutureDataInputStreamBuilder in method public getSplitsForFile(status FileStatus, conf Configuration, numLinesPerSplit int) : List<FileSplit> in class org.apache.hadoop.mapreduce.lib.input.NLineInputFormat	From	To
Change Variable Type fs : FileSystem to builder : FutureDataInputStreamBuilder in method public initialize(genericSplit InputSplit, context TaskAttemptContext) : void in class org.apache.hadoop.mapreduce.lib.input.LineRecordReader	From	To
Change Variable Type fs : FileSystem to builder : FutureDataInputStreamBuilder in method public LineRecordReader(job Configuration, split FileSplit, recordDelimiter byte[]) in class org.apache.hadoop.mapred.LineRecordReader	From	To
Extract Method	6
Extract Method private createReadContext(fileStatus FileStatus, seekPolicy S3AInputPolicy, readAheadRange long) : S3AReadOpContext extracted from public open(f Path, bufferSize int) : FSDataInputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem	From	To
Extract Method public validateReadahead(readahead Long) : long extracted from public setReadahead(readahead Long) : void in class org.apache.hadoop.fs.s3a.S3AInputStream	From	To
Extract Method protected exitException(exitCode int, format String, args Object...) : ExitUtil.ExitException extracted from protected userAborted(format String, args Object...) : ExitUtil.ExitException in class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool	From	To
Extract Method protected exitException(exitCode int, format String, args Object...) : ExitUtil.ExitException extracted from protected badState(format String, args Object...) : ExitUtil.ExitException in class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool	From	To
Extract Method protected exitException(exitCode int, format String, args Object...) : ExitUtil.ExitException extracted from protected invalidArgs(format String, args Object...) : ExitUtil.ExitException in class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool	From	To
Extract Method private open(path Path, options Optional<Configuration>) : FSDataInputStream extracted from public open(f Path, bufferSize int) : FSDataInputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem	From	To
Inline Variable	1
Inline Variable result : int in method public testOpenReadZeroByteFile() : void from class org.apache.hadoop.fs.contract.AbstractContractOpenTest	From	To
Pull Up Method	15
Pull Up Method public opt(key String, value int) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, value int) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method protected getPath() : Path from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public getPath() : Path from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public opt(key String, value float) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, value float) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, value boolean) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, value boolean) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, value String) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, value String) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public opt(key String, value String) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, value String) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public opt(key String, value boolean) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, value boolean) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, value double) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, value double) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method protected getOptions() : Configuration from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public getOptions() : Configuration from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public opt(key String, values String...) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, values String...) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, values String...) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, values String...) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method protected getMandatoryKeys() : Set<String> from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public getMandatoryKeys() : Set<String> from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, value float) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, value float) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public must(key String, value int) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public must(key String, value int) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Pull Up Method public opt(key String, value double) : B from class org.apache.hadoop.fs.FSDataOutputStreamBuilder to public opt(key String, value double) : B from class org.apache.hadoop.fs.impl.AbstractFSBuilderImpl	From	To
Rename Variable	4
Rename Variable fs : FileSystem to builder : FutureDataInputStreamBuilder in method public getSplitsForFile(status FileStatus, conf Configuration, numLinesPerSplit int) : List<FileSplit> in class org.apache.hadoop.mapreduce.lib.input.NLineInputFormat	From	To
Rename Variable fs : FileSystem to builder : FutureDataInputStreamBuilder in method public initialize(genericSplit InputSplit, context TaskAttemptContext) : void in class org.apache.hadoop.mapreduce.lib.input.LineRecordReader	From	To
Rename Variable fs : FileSystem to builder : FutureDataInputStreamBuilder in method public LineRecordReader(job Configuration, split FileSplit, recordDelimiter byte[]) in class org.apache.hadoop.mapred.LineRecordReader	From	To
Rename Variable fs : FileSystem to builder : FutureDataInputStreamBuilder in method public initialize(job Configuration, splitStart long, splitLength long, file Path) : void in class org.apache.hadoop.mapreduce.lib.input.FixedLengthRecordReader	From	To
Change Return Type	1
Change Return Type void to String in method protected expectSuccess(message String, tool S3GuardTool, args String...) : String in class org.apache.hadoop.fs.s3a.s3guard.AbstractS3GuardToolTestBase	From	To
Extract Superclass	1
Extract Superclass org.apache.hadoop.fs.impl.AbstractFSBuilderImpl from classes [org.apache.hadoop.fs.FSDataOutputStreamBuilder]	From	To
Extract And Move Method	4
Extract And Move Method public getCSVTestPath(conf Configuration) : Path extracted from public testInstantiationChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider & moved to class org.apache.hadoop.fs.s3a.S3ATestUtils	From	To
Extract And Move Method public verifyCause(clazz Class<E>, caught Throwable) : E extracted from public testEvalDoesWrapIOEs() : void in class org.apache.hadoop.test.TestLambdaTestUtils & moved to class org.apache.hadoop.test.LambdaTestUtils	From	To
Extract And Move Method public getLandsatCSVPath(conf Configuration) : Path extracted from public testMultiObjectDeleteNoPermissions() : void in class org.apache.hadoop.fs.s3a.ITestS3AFailureHandling & moved to class org.apache.hadoop.fs.s3a.S3ATestUtils	From	To
Extract And Move Method public getCSVTestPath(conf Configuration) : Path extracted from public testAnonymousProvider() : void in class org.apache.hadoop.fs.s3a.ITestS3AAWSCredentialsProvider & moved to class org.apache.hadoop.fs.s3a.S3ATestUtils	From	To
Rename Parameter	1
Rename Parameter f : Path to path : Path in method private open(path Path, options Optional<Configuration>) : FSDataInputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem	From	To

f365957c6326f88734bc0a5d01cfb7eac713db20

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: