f7ff8c051e4d4b5cd0eee1884e2a546de1f57793
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 31
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private verifyBlockDeletionEvent() : void renamed to private verifyPendingDeleteEvent() : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type cmdExecuted : boolean to cmdStatusUpdater : Consumer<CommandStatus> in method public updateCommandStatus(context StateContext, command SCMCommand, cmdStatusUpdater Consumer<CommandStatus>, log Logger) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CommandHandler | From | To | |
| Change Parameter Type cmdExecuted : boolean to cmdStatusUpdater : Consumer<CommandStatus> in method public updateCommandStatus(cmdId Long, cmdStatusUpdater Consumer<CommandStatus>) : boolean in class org.apache.hadoop.ozone.container.common.statemachine.StateContext | From | To | |
| Rename Variable | 1 | ||
| Rename Variable reportList : List<GeneratedMessage> to reportsToReturn : List<GeneratedMessage> in method public getReports(maxLimit int) : List<GeneratedMessage> in class org.apache.hadoop.ozone.container.common.statemachine.StateContext | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to boolean in method private addTransactionToDN(dnID UUID, tx DeletedBlocksTransaction) : boolean in class org.apache.hadoop.hdds.scm.block.DatanodeDeletedBlockTransactions | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.hdds.scm.command.CommandStatusReportHandler.DeleteBlockCommandStatus renamed to org.apache.hadoop.hdds.scm.command.CommandStatusReportHandler.DeleteBlockStatus | From | To | |
| Extract Variable | 3 | ||
| Extract Variable leaderId : String in method public getContainerWithPipeline(containerID long) : ContainerWithPipeline from class org.apache.hadoop.hdds.scm.container.ContainerMapping | From | To | |
| Extract Variable success : boolean in method public addTransaction(tx DeletedBlocksTransaction, dnsWithTransactionCommitted Set<UUID>) : boolean from class org.apache.hadoop.hdds.scm.block.DatanodeDeletedBlockTransactions | From | To | |
| Extract Variable statusBuilder : CommandStatusBuilder in method public addCmdStatus(cmd SCMCommand) : void from class org.apache.hadoop.ozone.container.common.statemachine.StateContext | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type reports : Queue<GeneratedMessage> to reports : List<GeneratedMessage> in class org.apache.hadoop.ozone.container.common.statemachine.StateContext | From | To | |
| Change Attribute Type DELETE_BLOCK_STATUS : Event<DeleteBlockCommandStatus> to DELETE_BLOCK_STATUS : TypedEvent<CommandStatusReportHandler.DeleteBlockStatus> in class org.apache.hadoop.hdds.scm.events.SCMEvents | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter cmdExecuted : boolean to cmdStatusUpdater : Consumer<CommandStatus> in method public updateCommandStatus(cmdId Long, cmdStatusUpdater Consumer<CommandStatus>) : boolean in class org.apache.hadoop.ozone.container.common.statemachine.StateContext | From | To | |
| Rename Parameter cmdExecuted : boolean to cmdStatusUpdater : Consumer<CommandStatus> in method public updateCommandStatus(context StateContext, command SCMCommand, cmdStatusUpdater Consumer<CommandStatus>, log Logger) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.CommandHandler | From | To |