f8f7a923b76abcd1d0242c15a536b20af1c1695e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private readCell(reader BlockReader, datanode DatanodeInfo, currentReaderOffset long, targetReaderOffset long, strategy ByteBufferStrategy, targetLength int, currentBlock ExtendedBlock, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : Callable<Void> renamed to private readCells(reader BlockReader, datanode DatanodeInfo, currentReaderOffset long, targetReaderOffset long, strategies ByteBufferStrategy[], currentBlock ExtendedBlock, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : Callable<Void> in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Pull Up Method | 3 | ||
| Pull Up Method package readChunk(service CompletionService<Void>, block LocatedBlock, chunkIndex int) : boolean from class org.apache.hadoop.hdfs.DFSStripedInputStream.PositionStripeReader to package readChunk(block LocatedBlock, chunkIndex int) : boolean from class org.apache.hadoop.hdfs.DFSStripedInputStream.StripeReader | From | To | |
| Pull Up Method package updateState4SuccessRead(result StripingChunkReadResult) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream.StatefulStripeReader to package updateState4SuccessRead(result StripingChunkReadResult) : void from class org.apache.hadoop.hdfs.DFSStripedInputStream.StripeReader | From | To | |
| Pull Up Method private prepareParityBlockReader(i int) : boolean from class org.apache.hadoop.hdfs.DFSStripedInputStream.StatefulStripeReader to package createBlockReader(block LocatedBlock, chunkIndex int) : boolean from class org.apache.hadoop.hdfs.DFSStripedInputStream.StripeReader | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type index : int to readerInfo : BlockReaderInfo in method private closeReader(readerInfo BlockReaderInfo) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Variable | 1 | ||
| Rename Variable length : int to len : int in method package actualGetFromOneDataNode(datanode DNAddrPair, block LocatedBlock, startInBlk long, endInBlk long, buf byte[], offset int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSInputStream | From | To | |
| Inline Method | 1 | ||
| Inline Method package actualGetFromOneDataNode(datanode DNAddrPair, block LocatedBlock, startInBlk long, endInBlk long, buf byte[], offsets int[], lengths int[], corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void inlined to package actualGetFromOneDataNode(datanode DNAddrPair, block LocatedBlock, startInBlk long, endInBlk long, buf byte[], offset int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSInputStream | From | To | |
| Inline Variable | 1 | ||
| Inline Variable ret : int in method public call() : Void from class org.apache.hadoop.hdfs.DFSStripedInputStream.readCell | From | To | |
| Rename Parameter | 5 | ||
| Rename Parameter index : int to readerInfo : BlockReaderInfo in method private closeReader(readerInfo BlockReaderInfo) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Parameter end : long to endInBlk : long in method package actualGetFromOneDataNode(datanode DNAddrPair, block LocatedBlock, startInBlk long, endInBlk long, buf byte[], offset int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSInputStream | From | To | |
| Rename Parameter i : int to chunkIndex : int in method package createBlockReader(block LocatedBlock, chunkIndex int) : boolean in class org.apache.hadoop.hdfs.DFSStripedInputStream.StripeReader | From | To | |
| Rename Parameter readerStrategy : ByteBufferStrategy to strategy : ByteBufferStrategy in method private readToBuffer(blockReader BlockReader, currentNode DatanodeInfo, strategy ByteBufferStrategy, currentBlock ExtendedBlock, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Parameter start : long to startInBlk : long in method package actualGetFromOneDataNode(datanode DNAddrPair, block LocatedBlock, startInBlk long, endInBlk long, buf byte[], offset int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSInputStream | From | To |