f9cc9e162175444efe9d5b07ecb9a795f750ca3c
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getAuthoritativeDirTtl() : long renamed to public getMetadataTtl() : long in class org.apache.hadoop.fs.s3a.s3guard.S3Guard.TtlTimeProvider | From | To | |
| Rename Method public getAuthoritativeDirTtl() : long renamed to public getMetadataTtl() : long in class org.apache.hadoop.fs.s3a.s3guard.ITtlTimeProvider | From | To | |
| Change Parameter Type | 3 | ||
| Change Parameter Type ttlTimeProvider : S3Guard.ITtlTimeProvider to ttlTimeProvider : ITtlTimeProvider in method protected setTtlTimeProvider(ttlTimeProvider ITtlTimeProvider) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Parameter Type modTime : long to pruneMode : PruneMode in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Change Parameter Type modTime : long to pruneMode : PruneMode in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Change Return Type | 2 | ||
| Change Return Type S3Guard.ITtlTimeProvider to ITtlTimeProvider in method public getTtlTimeProvider() : ITtlTimeProvider in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type FileStatus to S3AFileStatus in method private awaitFileStatus(fs S3AFileSystem, testFilePath Path) : S3AFileStatus in class org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.fs.s3a.s3guard.S3Guard.ITtlTimeProvider moved and renamed to org.apache.hadoop.fs.s3a.s3guard.ITtlTimeProvider | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable newDirs : Collection<PathMetadata> to fileMetas : Collection<PathMetadata> in method public putWithTtl(ms MetadataStore, fileMetas Collection<PathMetadata>, timeProvider ITtlTimeProvider) : void in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute DEFAULT_METADATASTORE_AUTHORITATIVE_DIR_TTL : long to DEFAULT_METADATASTORE_METADATA_TTL : long in class org.apache.hadoop.fs.s3a.Constants | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type timeProvider : S3Guard.ITtlTimeProvider to timeProvider : ITtlTimeProvider in method public testDirListingUnion() : void in class org.apache.hadoop.fs.s3a.s3guard.TestS3Guard | From | To | |
| Change Variable Type origStatus : FileStatus to origStatus : S3AFileStatus in method private overwriteFileInListing(firstText String, secondText String) : void in class org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations | From | To | |
| Change Variable Type origList : FileStatus[] to origList : S3AFileStatus[] in method private overwriteFileInListing(firstText String, secondText String) : void in class org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations | From | To | |
| Change Variable Type mockTimeProvider : S3Guard.ITtlTimeProvider to mockTimeProvider : ITtlTimeProvider in method public testDirectoryListingAuthoritativeTtl() : void in class org.apache.hadoop.fs.s3a.ITestS3GuardTtl | From | To | |
| Change Variable Type modList : FileStatus[] to modList : S3AFileStatus[] in method private overwriteFileInListing(firstText String, secondText String) : void in class org.apache.hadoop.fs.s3a.ITestS3GuardOutOfBandOperations | From | To | |
| Change Variable Type restoreTimeProvider : S3Guard.ITtlTimeProvider to restoreTimeProvider : ITtlTimeProvider in method public testDirectoryListingAuthoritativeTtl() : void in class org.apache.hadoop.fs.s3a.ITestS3GuardTtl | From | To | |
| Extract Variable | 3 | ||
| Extract Variable pmTombstone : PathMetadata in method public move(pathsToDelete Collection<Path>, pathsToCreate Collection<PathMetadata>, ttlTimeProvider ITtlTimeProvider) : void from class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Extract Variable pmTombstone : PathMetadata in method private innerDelete(path Path, tombstone boolean, ttlTimeProvider ITtlTimeProvider) : void from class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Extract Variable pmTombstone : PathMetadata in method package deleteEntryByAncestor(ancestor Path, cache Cache<Path,LocalMetadataEntry>, tombstone boolean, ttlTimeProvider ITtlTimeProvider) : void from class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Extract Method | 4 | ||
| Extract Method public putWithTtl(ms MetadataStore, fileMeta PathMetadata, timeProvider ITtlTimeProvider) : void extracted from public dirListingUnion(ms MetadataStore, path Path, backingStatuses List<S3AFileStatus>, dirMeta DirListingMetadata, isAuthoritative boolean, timeProvider ITtlTimeProvider) : FileStatus[] in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract Method public putWithTtl(ms MetadataStore, fileMetas Collection<PathMetadata>, timeProvider ITtlTimeProvider) : void extracted from public addAncestors(metadataStore MetadataStore, qualifiedPath Path, username String) : void in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract Method private removeAuthoritativeFromParent(path Path, oldChildren Collection<PathMetadata>, newChildren Collection<PathMetadata>) : void extracted from public prune(modTime long, keyPrefix String) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Extract Method public putWithTtl(ms MetadataStore, fileMeta PathMetadata, timeProvider ITtlTimeProvider) : void extracted from public putAndReturn(ms MetadataStore, status S3AFileStatus, instrumentation S3AInstrumentation) : S3AFileStatus in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type ttlTimeProvider : S3Guard.ITtlTimeProvider to ttlTimeProvider : ITtlTimeProvider in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method | 4 | ||
| Extract And Move Method public putWithTtl(ms MetadataStore, fileMeta PathMetadata, timeProvider ITtlTimeProvider) : void extracted from private putParentsIfNotPresent(f FileStatus) : void in class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool.Import & moved to class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Extract And Move Method public putWithTtl(ms MetadataStore, fileMeta PathMetadata, timeProvider ITtlTimeProvider) : void extracted from private importDir(status FileStatus) : long in class org.apache.hadoop.fs.s3a.s3guard.S3GuardTool.Import & moved to class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Rename Parameter | 8 | ||
| Rename Parameter modTime : long to cutoff : long in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.MetadataStore | From | To | |
| Rename Parameter modTime : long to pruneMode : PruneMode in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Rename Parameter modTime : long to cutoff : long in method public prune(pruneMode PruneMode, cutoff long, keyPrefix String) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Rename Parameter metadataStore : MetadataStore to ms : MetadataStore in method public putWithTtl(ms MetadataStore, fileMetas Collection<PathMetadata>, timeProvider ITtlTimeProvider) : void in class org.apache.hadoop.fs.s3a.s3guard.S3Guard | From | To | |
| Rename Parameter modTime : long to cutoff : long in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.DynamoDBMetadataStore | From | To | |
| Rename Parameter modTime : long to cutoff : long in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To | |
| Rename Parameter modTime : long to cutoff : long in method public prune(pruneMode PruneMode, cutoff long, keyPrefix String) : void in class org.apache.hadoop.fs.s3a.s3guard.MetadataStore | From | To | |
| Rename Parameter modTime : long to pruneMode : PruneMode in method public prune(pruneMode PruneMode, cutoff long) : void in class org.apache.hadoop.fs.s3a.s3guard.LocalMetadataStore | From | To |