ff036e49ff967d5dacf4b2d9d5376e57578ef391
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 26
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public getDBKeyBytes(volume String, bucket String, key String) : byte[] renamed to public getOpenKeyBytes(volume String, bucket String, key String, id long) : byte[] in class org.apache.hadoop.ozone.om.OMMetadataManager | From | To | |
| Rename Method public getDBKeyBytes(volume String, bucket String, key String) : byte[] renamed to public getOpenKeyBytes(volume String, bucket String, key String, id long) : byte[] in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public put(key byte[], value byte[]) : void moved from class org.apache.hadoop.ozone.om.OmMetadataManagerImpl to class org.apache.hadoop.ozone.om.TestBucketManagerImpl & inlined to public testDeleteNonEmptyBucket() : void | From | To | |
| Change Parameter Type | 13 | ||
| Change Parameter Type clientID : int to clientID : long in method public allocateBlock(args OmKeyArgs, clientID long) : OmKeyLocationInfo in class org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public allocateBlock(args OmKeyArgs, clientID long) : OmKeyLocationInfo in class org.apache.hadoop.ozone.om.KeyManager | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.protocolPB.OzoneManagerProtocolClientSideTranslatorPB | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.OzoneManager | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public allocateBlock(args OmKeyArgs, clientID long) : OmKeyLocationInfo in class org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.protocol.OzoneManagerProtocol | From | To | |
| Change Parameter Type batchOperation : BatchOperation to batch : WriteBatch in method private delVolumeFromOwnerList(volume String, owner String, batch WriteBatch) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public allocateBlock(args OmKeyArgs, clientID long) : OmKeyLocationInfo in class org.apache.hadoop.ozone.om.KeyManagerImpl | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public allocateBlock(args OmKeyArgs, clientID long) : OmKeyLocationInfo in class org.apache.hadoop.ozone.om.OzoneManager | From | To | |
| Change Parameter Type id : int to id : long in method public OpenKeySession(id long, info OmKeyInfo, version long) in class org.apache.hadoop.ozone.om.helpers.OpenKeySession | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.KeyManager | From | To | |
| Change Parameter Type batchOperation : BatchOperation to batchOperation : WriteBatch in method private addVolumeToOwnerList(volume String, owner String, batchOperation WriteBatch) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Parameter Type clientID : int to clientID : long in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.KeyManagerImpl | From | To | |
| Rename Variable | 2 | ||
| Rename Variable store : MetadataStore to manager : OMMetadataManager in method public testDeleteKey() : void in class org.apache.hadoop.ozone.om.TestOzoneManager | From | To | |
| Rename Variable keyKey : byte[] to keyBytes : byte[] in method public lookupKey(args OmKeyArgs) : OmKeyInfo in class org.apache.hadoop.ozone.om.KeyManagerImpl | From | To | |
| Change Return Type | 4 | ||
| Change Return Type MetadataStore to DBStore in method public getStore() : DBStore in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Change Return Type MetadataStore to DBStore in method public getStore() : DBStore in class org.apache.hadoop.ozone.om.OMMetadataManager | From | To | |
| Change Return Type int to long in method public getOpenID() : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Change Return Type int to long in method public getId() : long in class org.apache.hadoop.ozone.om.helpers.OpenKeySession | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type objectKey : String to objectKey : byte[] in method public commitKey(args OmKeyArgs, clientID long) : void in class org.apache.hadoop.ozone.om.KeyManagerImpl | From | To | |
| Change Variable Type clientId : int to clientId : long in method private waitForContainerClose(keyName String, outputStream OzoneOutputStream, type HddsProtos.ReplicationType) : void in class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient | From | To | |
| Change Variable Type store : MetadataStore to manager : OMMetadataManager in method public testDeleteKey() : void in class org.apache.hadoop.ozone.om.TestOzoneManager | From | To | |
| Inline Variable | 4 | ||
| Inline Variable id : int in method public commitKey(controller RpcController, request CommitKeyRequest) : CommitKeyResponse from class org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB | From | To | |
| Inline Variable info : OmBucketInfo in method public listBuckets(volumeName String, startBucket String, bucketPrefix String, maxNumOfBuckets int) : List<OmBucketInfo> from class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Inline Variable info : OmKeyInfo in method public listKeys(volumeName String, bucketName String, startKey String, keyPrefix String, maxKeys int) : List<OmKeyInfo> from class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Inline Variable id : int in method public allocateBlock(controller RpcController, request AllocateBlockRequest) : AllocateBlockResponse from class org.apache.hadoop.ozone.protocolPB.OzoneManagerProtocolServerSideTranslatorPB | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type id : int to id : long in class org.apache.hadoop.ozone.om.helpers.OpenKeySession | From | To | |
| Change Attribute Type openID : int to openID : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Change Attribute Type store : MetadataStore to store : DBStore in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Extract Method | 5 | ||
| Extract Method private startsWith(firstArray byte[], secondArray byte[]) : boolean extracted from public isBucketEmpty(volume String, bucket String) : boolean in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Extract Method public move(sourceKey byte[], destKey byte[], value byte[], source Table, dest Table) : void extracted from public move(key byte[], value byte[], source Table, dest Table) : void in class org.apache.hadoop.utils.db.RDBStore | From | To | |
| Extract Method private startsWith(firstArray byte[], secondArray byte[]) : boolean extracted from public listBuckets(volumeName String, startBucket String, bucketPrefix String, maxNumOfBuckets int) : List<OmBucketInfo> in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Extract Method private startsWith(firstArray byte[], secondArray byte[]) : boolean extracted from public isVolumeEmpty(volume String) : boolean in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Extract Method private startsWith(firstArray byte[], secondArray byte[]) : boolean extracted from public listKeys(volumeName String, bucketName String, startKey String, keyPrefix String, maxKeys int) : List<OmKeyInfo> in class org.apache.hadoop.ozone.om.OmMetadataManagerImpl | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter batchOperation : BatchOperation to batch : WriteBatch in method private delVolumeFromOwnerList(volume String, owner String, batch WriteBatch) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To |