05b1d918b0a845ced066a66b187823c357ed673d
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public getFilesForScanOrGet(isGet boolean, startRow byte[], stopRow byte[]) : Collection<StoreFile> renamed to public getFilesForScan(startRow byte[], includeStartRow boolean, stopRow byte[], includeStopRow boolean) : Collection<StoreFile> in class org.apache.hadoop.hbase.regionserver.StoreFileManager | From | To | |
| Rename Method private isStartRowAndEqualsStopRow() : boolean renamed to private areStartRowAndStopRowEqual(startRow byte[], stopRow byte[]) : boolean in class org.apache.hadoop.hbase.client.Scan | From | To | |
| Rename Method public getFilesForScanOrGet(isGet boolean, startRow byte[], stopRow byte[]) : Collection<StoreFile> renamed to public getFilesForScan(startRow byte[], includeStartRow boolean, stopRow byte[], includeStopRow boolean) : Collection<StoreFile> in class org.apache.hadoop.hbase.regionserver.StripeStoreFileManager | From | To | |
| Rename Method public getFilesForScanOrGet(isGet boolean, startRow byte[], stopRow byte[]) : Collection<StoreFile> renamed to public getFilesForScan(startRow byte[], includeStartRow boolean, stopRow byte[], includeStopRow boolean) : Collection<StoreFile> in class org.apache.hadoop.hbase.regionserver.DefaultStoreFileManager | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type startRow : byte[] to startKey : Cell in method protected ScanQueryMatcher(startKey Cell, scanInfo ScanInfo, columns ColumnTracker, oldestUnexpiredTS long, now long) in class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher | From | To | |
| Rename Variable | 1 | ||
| Rename Variable stopRow : boolean to shouldStop : boolean in method private nextInternal(results List<Cell>, scannerContext ScannerContext) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion.RegionScannerImpl | From | To | |
| Change Return Type | 2 | ||
| Change Return Type CompletableFuture<RegionLocateType> to CompletableFuture<Boolean> in method public start() : CompletableFuture<Boolean> in class org.apache.hadoop.hbase.client.AsyncRpcRetryingCallerFactory.ScanSingleRegionCallerBuilder | From | To | |
| Change Return Type CompletableFuture<RegionLocateType> to CompletableFuture<Boolean> in method public start() : CompletableFuture<Boolean> in class org.apache.hadoop.hbase.client.AsyncScanSingleRegionRpcRetryingCaller | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute getScan : boolean to includeStopRow : boolean in class org.apache.hadoop.hbase.client.Scan | From | To | |
| Extract Variable | 5 | ||
| Extract Variable table : RawAsyncTable in method protected doScan(scan Scan) : List<Result> from class org.apache.hadoop.hbase.client.TestRawAsyncTableScan | From | To | |
| Extract Variable actualStart : int in method private testReversedScan(start int, startInclusive boolean, stop int, stopInclusive boolean) : void from class org.apache.hadoop.hbase.client.AbstractTestAsyncTableScan | From | To | |
| Extract Variable actualStop : int in method private testReversedScan(start int, startInclusive boolean, stop int, stopInclusive boolean) : void from class org.apache.hadoop.hbase.client.AbstractTestAsyncTableScan | From | To | |
| Extract Variable actualStart : int in method private testScan(start int, startInclusive boolean, stop int, stopInclusive boolean) : void from class org.apache.hadoop.hbase.client.AbstractTestAsyncTableScan | From | To | |
| Extract Variable actualStop : int in method private testScan(start int, startInclusive boolean, stop int, stopInclusive boolean) : void from class org.apache.hadoop.hbase.client.AbstractTestAsyncTableScan | From | To | |
| Extract Method | 2 | ||
| Extract Method public withStartRow(startRow byte[]) : Scan extracted from public setStartRow(startRow byte[]) : Scan in class org.apache.hadoop.hbase.client.Scan | From | To | |
| Extract Method public withStopRow(stopRow byte[]) : Scan extracted from public setStopRow(stopRow byte[]) : Scan in class org.apache.hadoop.hbase.client.Scan | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type future : CompletableFuture<RegionLocateType> to future : CompletableFuture<Boolean> in class org.apache.hadoop.hbase.client.AsyncScanSingleRegionRpcRetryingCaller | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method package noMoreResultsForReverseScan(scan Scan, info HRegionInfo) : boolean extracted from private completeReversedWhenNoMoreResultsInRegion() : void in class org.apache.hadoop.hbase.client.AsyncScanSingleRegionRpcRetryingCaller & moved to class org.apache.hadoop.hbase.client.ConnectionUtils | From | To | |
| Extract And Move Method package noMoreResultsForScan(scan Scan, info HRegionInfo) : boolean extracted from private nextScan(region HRegionInfo) : boolean in class org.apache.hadoop.hbase.client.AsyncSmallScanRpcRetryingCaller & moved to class org.apache.hadoop.hbase.client.ConnectionUtils | From | To | |
| Extract And Move Method package noMoreResultsForReverseScan(scan Scan, info HRegionInfo) : boolean extracted from private reversedNextScan(region HRegionInfo) : boolean in class org.apache.hadoop.hbase.client.AsyncSmallScanRpcRetryingCaller & moved to class org.apache.hadoop.hbase.client.ConnectionUtils | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter region : HRegionInfo to info : HRegionInfo in method private nextScan(info HRegionInfo) : boolean in class org.apache.hadoop.hbase.client.AsyncSmallScanRpcRetryingCaller | From | To | |
| Rename Parameter startRow : byte[] to startKey : Cell in method protected ScanQueryMatcher(startKey Cell, scanInfo ScanInfo, columns ColumnTracker, oldestUnexpiredTS long, now long) in class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher | From | To | |
| Rename Parameter nextStartRow : byte[] to row : byte[] in method private completeWithNextStartRow(row byte[], inclusive boolean) : void in class org.apache.hadoop.hbase.client.AsyncScanSingleRegionRpcRetryingCaller | From | To | |
| Rename Parameter region : HRegionInfo to info : HRegionInfo in method private reversedNextScan(info HRegionInfo) : boolean in class org.apache.hadoop.hbase.client.AsyncSmallScanRpcRetryingCaller | From | To |