hbase 1267f76e9aa9591b462f6e1ba2e50ec4dbf92f8b

1267f76e9aa9591b462f6e1ba2e50ec4dbf92f8b

Files Diff

Added: 4
Removed: 2
Renamed: 0
Modified: 55

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Push Down Method	1
Push Down Method package batchWriteAndWait(table Table, log FSHLog, start int, expect boolean, timeout int) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRolling to package batchWriteAndWait(table Table, log FSHLog, start int, expect boolean, timeout int) : void from class org.apache.hadoop.hbase.regionserver.wal.TestLogRolling	From	To
Pull Up Method	35
Pull Up Method private deleteDir(p Path) : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private deleteDir(p Path) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createBasic3FamilyHRegionInfo(tableName TableName) : HRegionInfo from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createBasic3FamilyHRegionInfo(tableName TableName) : HRegionInfo from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createBasic1FamilyHTD(tableName TableName) : HTableDescriptor from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createBasic1FamilyHTD(tableName TableName) : HTableDescriptor from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testNameConflictWhenSplit1() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testNameConflictWhenSplit1() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testNoEdits() : void from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to public testNoEdits() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Method public testReplayEditsWrittenViaHRegion() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testReplayEditsWrittenViaHRegion() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public tearDown() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public tearDown() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testNameConflictWhenSplit0() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testNameConflictWhenSplit0() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testCompactedBulkLoadedFiles() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testCompactedBulkLoadedFiles() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private getScannedCount(scanner RegionScanner) : int from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private getScannedCount(scanner RegionScanner) : int from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testReplayEditsAfterRegionMovedWithMultiCF() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testReplayEditsAfterRegionMovedWithMultiCF() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createBasic3FamilyHTD(tableName TableName) : HTableDescriptor from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createBasic3FamilyHTD(tableName TableName) : HTableDescriptor from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private testNameConflictWhenSplit(largeFirst boolean) : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private testNameConflictWhenSplit(largeFirst boolean) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testRegionMadeOfBulkLoadedFilesOnly() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testRegionMadeOfBulkLoadedFilesOnly() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public test2727() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public test2727() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testReplayEditsAfterPartialFlush() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testReplayEditsAfterPartialFlush() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testDatalossWhenInputError() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testDatalossWhenInputError() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method package addRegionEdits(rowName byte[], family byte[], count int, ee EnvironmentEdge, r Region, qualifierPrefix String) : List<Put> from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to package addRegionEdits(rowName byte[], family byte[], count int, ee EnvironmentEdge, r Region, qualifierPrefix String) : List<Put> from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testWithEdits() : void from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to public testWithEdits() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Method private checkMinLogRolls(log WAL, minRolls int) : void from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to private checkMinLogRolls(log WAL, minRolls int) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Method private createWALEdit(rowName byte[], family byte[], ee EnvironmentEdge, index int) : WALEdit from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createWALEdit(rowName byte[], family byte[], ee EnvironmentEdge, index int) : WALEdit from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public toString() : String from class org.apache.hadoop.hbase.regionserver.wal.FSHLog to public toString() : String from class org.apache.hadoop.hbase.regionserver.wal.AbstractFSWAL	From	To
Pull Up Method private writerWALFile(file Path, entries List<FSWALEntry>) : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private writerWALFile(file Path, entries List<FSWALEntry>) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testSequentialEditLogSeqNum() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testSequentialEditLogSeqNum() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createFSWALEntry(htd HTableDescriptor, hri HRegionInfo, sequence long, rowName byte[], family byte[], ee EnvironmentEdge, mvcc MultiVersionConcurrencyControl, index int, scopes NavigableMap<byte[],Integer>) : FSWALEntry from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createFSWALEntry(htd HTableDescriptor, hri HRegionInfo, sequence long, rowName byte[], family byte[], ee EnvironmentEdge, mvcc MultiVersionConcurrencyControl, index int, scopes NavigableMap<byte[],Integer>) : FSWALEntry from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public tearDownAfterClass() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public tearDownAfterClass() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public setUp() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public setUp() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private moveRegionAndWait(destRegion Region, destServer HRegionServer) : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private moveRegionAndWait(destRegion Region, destServer HRegionServer) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public testReplayEditsAfterAbortingFlush() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testReplayEditsAfterAbortingFlush() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private addWALEdits(tableName TableName, hri HRegionInfo, rowName byte[], family byte[], count int, ee EnvironmentEdge, wal WAL, htd HTableDescriptor, mvcc MultiVersionConcurrencyControl, scopes NavigableMap<byte[],Integer>) : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private addWALEdits(tableName TableName, hri HRegionInfo, rowName byte[], family byte[], count int, ee EnvironmentEdge, wal WAL, htd HTableDescriptor, mvcc MultiVersionConcurrencyControl, scopes NavigableMap<byte[],Integer>) : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private runWALSplit(c Configuration) : Path from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private runWALSplit(c Configuration) : Path from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createWALKey(tableName TableName, hri HRegionInfo, mvcc MultiVersionConcurrencyControl, scopes NavigableMap<byte[],Integer>) : WALKey from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createWALKey(tableName TableName, hri HRegionInfo, mvcc MultiVersionConcurrencyControl, scopes NavigableMap<byte[],Integer>) : WALKey from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method private createMockWAL() : MockWAL from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private createMockWAL() : MockWAL from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Method public tearDownAfterClass() : void from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to public tearDownAfterClass() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Method public testReplayEditsWrittenIntoWAL() : void from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public testReplayEditsWrittenIntoWAL() : void from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute	15
Pull Up Attribute private LOG : Log from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private LOG : Log from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private logName : String from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private logName : String from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private fs : FileSystem from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private fs : FileSystem from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private conf : Configuration from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private conf : Configuration from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private mode : RecoveryMode from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private mode : RecoveryMode from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute public currentTest : TestName from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to public currentTest : TestName from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private LOG_ROLL_PERIOD : long from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to private LOG_ROLL_PERIOD : long from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Attribute private oldLogDir : Path from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private oldLogDir : Path from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private wals : WALFactory from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private wals : WALFactory from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute protected TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to protected TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Attribute private logDir : Path from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private logDir : Path from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private LOG : Log from class org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod to private LOG : Log from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod	From	To
Pull Up Attribute private ee : EnvironmentEdge from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private ee : EnvironmentEdge from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute private hbaseRootDir : Path from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to private hbaseRootDir : Path from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Pull Up Attribute package TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay to package TEST_UTIL : HBaseTestingUtility from class org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay	From	To
Rename Class	2
Rename Class org.apache.hadoop.hbase.wal.DefaultWALProvider renamed to org.apache.hadoop.hbase.wal.FSHLogProvider	From	To
Rename Class org.apache.hadoop.hbase.wal.TestDefaultWALProvider renamed to org.apache.hadoop.hbase.wal.TestFSHLogProvider	From	To
Move Class	3
Move Class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.MockWAL moved to org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay.MockWAL	From	To
Move Class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.CustomStoreFlusher moved to org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay.CustomStoreFlusher	From	To
Move Class org.apache.hadoop.hbase.regionserver.wal.TestWALReplay.TestFlusher moved to org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay.TestFlusher	From	To
Extract Superclass	2
Extract Superclass org.apache.hadoop.hbase.regionserver.wal.AbstractTestLogRollPeriod from classes [org.apache.hadoop.hbase.regionserver.wal.TestLogRollPeriod, org.apache.hadoop.hbase.regionserver.wal.TestAsyncLogRollPeriod]	From	To
Extract Superclass org.apache.hadoop.hbase.regionserver.wal.AbstractTestWALReplay from classes [org.apache.hadoop.hbase.regionserver.wal.TestWALReplay, org.apache.hadoop.hbase.regionserver.wal.TestAsyncWALReplay]	From	To
Change Variable Type	3
Change Variable Type lrClass : Class<? extends DefaultWALProvider.Reader> to lrClass : Class<? extends AbstractFSWALProvider.Reader> in method public createReader(fs FileSystem, path Path, reporter CancelableProgressable, allowCustom boolean) : Reader in class org.apache.hadoop.hbase.wal.WALFactory	From	To
Change Variable Type reader : DefaultWALProvider.Reader to reader : AbstractFSWALProvider.Reader in method public createReader(fs FileSystem, path Path, reporter CancelableProgressable, allowCustom boolean) : Reader in class org.apache.hadoop.hbase.wal.WALFactory	From	To
Change Attribute Type	1
Change Attribute Type logReaderClass : Class<? extends DefaultWALProvider.Reader> to logReaderClass : Class<? extends AbstractFSWALProvider.Reader> in class org.apache.hadoop.hbase.wal.WALFactory	From	To

1267f76e9aa9591b462f6e1ba2e50ec4dbf92f8b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: