hbase 130057f13774f6b213cdb06952c805a29d59396e

130057f13774f6b213cdb06952c805a29d59396e

Files Diff

Added: 3
Removed: 1
Renamed: 0
Modified: 21

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Change Parameter Type	10
Change Parameter Type tablePerms : ListMultimap<String,TablePermission> to tablePerms : ListMultimap<String,Permission> in method private updateTableCache(table TableName, tablePerms ListMultimap<String,Permission>) : void in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Parameter Type first : ListMultimap<String,TablePermission> to first : ListMultimap<String,UserPermission> in method public checkMultimapEqual(first ListMultimap<String,UserPermission>, second ListMultimap<String,UserPermission>) : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Parameter Type perm : ListMultimap<String,TablePermission> to perm : ListMultimap<String,UserPermission> in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Parameter Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method public writePermissionsAsBytes(perms ListMultimap<String,UserPermission>, conf Configuration) : byte[] in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Parameter Type second : ListMultimap<String,TablePermission> to second : ListMultimap<String,UserPermission> in method public checkMultimapEqual(first ListMultimap<String,UserPermission>, second ListMultimap<String,UserPermission>) : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Parameter Type instance : TableAuthManager to instance : AuthManager in method public release(instance AuthManager) : void in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Parameter Type perm : ListMultimap<String,TablePermission> to perm : ListMultimap<String,UserPermission> in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Parameter Type namespace : String to table : TableName in method private failCheckTable(table TableName) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Change Parameter Type mgr : TableAuthManager to mgr : AuthManager in method package AccessControlFilter(mgr AuthManager, ugi User, tableName TableName, strategy Strategy, cfVsMaxVersions Map<ByteRange,Integer>) in class org.apache.hadoop.hbase.security.access.AccessControlFilter	From	To
Change Parameter Type authManager : TableAuthManager to authManager : AuthManager in method public ZKPermissionWatcher(watcher ZKWatcher, authManager AuthManager, conf Configuration) in class org.apache.hadoop.hbase.security.access.ZKPermissionWatcher	From	To
Move Method	2
Move Method public readFields(in DataInput) : void from class org.apache.hadoop.hbase.security.access.UserPermission to public readFields(in DataInput) : void from class org.apache.hadoop.hbase.security.access.NamespacePermission	From	To
Move Method public write(out DataOutput) : void from class org.apache.hadoop.hbase.security.access.UserPermission to public write(out DataOutput) : void from class org.apache.hadoop.hbase.security.access.NamespacePermission	From	To
Move Attribute	1
Move Attribute private namespace : String from class org.apache.hadoop.hbase.security.access.TablePermission to private namespace : String from class org.apache.hadoop.hbase.security.access.NamespacePermission	From	To
Extract Class	1
Extract Class org.apache.hadoop.hbase.security.access.NamespacePermission from class org.apache.hadoop.hbase.security.access.UserPermission	From	To
Rename Class	1
Rename Class org.apache.hadoop.hbase.security.access.TableAuthManager renamed to org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Variable Type	54
Change Variable Type user3Perms : List<TablePermission> to user3Perms : List<UserPermission> in method public testGlobalPermission() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method private initialize(e RegionCoprocessorEnvironment) : void in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,Permission> in method public readPermissions(data byte[], conf Configuration) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type resultPerms : ListMultimap<String,TablePermission> to resultPerms : ListMultimap<String,UserPermission> in method package loadAll(conf Configuration) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type allPerms : Map<byte[],ListMultimap<String,TablePermission>> to allPerms : Map<byte[],ListMultimap<String,UserPermission>> in method package loadAll(conf Configuration) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type e : Entry<String,TablePermission> to e : Entry<String,Permission> in method public restoreSnapshotAcl(snapshot SnapshotDescription, newTableName TableName, conf Configuration) : void in class org.apache.hadoop.hbase.snapshot.RestoreSnapshotHelper	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method private writeAclToSnapshotDescription(snapshot SnapshotDescription, conf Configuration) : SnapshotDescription in class org.apache.hadoop.hbase.snapshot.SnapshotDescriptionUtils	From	To
Change Variable Type p2 : TablePermission to p2 : Permission in method public testEquals() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,Permission> in method public toUserTablePermissions(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Variable Type entry : Map.Entry<String,Collection<TablePermission>> to entry : Map.Entry<String,Collection<UserPermission>> in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Variable Type tablePerm : TablePermission to userPerm : UserPermission in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method public testGlobalPermission() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type permissionsOfUserOnTable : Pair<String,TablePermission> to permissionsOfUserOnTable : Pair<String,Permission> in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method package getPermissions(conf Configuration, entryName byte[], t Table, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type tablePerm : TablePermission to userPerm : UserPermission in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Variable Type user1Perms : List<TablePermission> to user1Perms : List<UserPermission> in method public testGlobalPermission() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type permissions : ListMultimap<String,TablePermission> to permissions : ListMultimap<String,UserPermission> in method public testSerialization() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type entry : Map.Entry<String,TablePermission> to entry : Map.Entry<String,UserPermission> in method public testAclTableEntries() : void in class org.apache.hadoop.hbase.security.access.TestNamespaceCommands	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method private parsePermissions(entryName byte[], result Result, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type tables : Map<byte[],ListMultimap<String,TablePermission>> to tables : Map<byte[],ListMultimap<String,UserPermission>> in method private initialize(e RegionCoprocessorEnvironment) : void in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Change Variable Type p1 : TablePermission to p1 : Permission in method public testEquals() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type permissions : TablePermission to permission : Permission in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type entry : Map.Entry<String,Collection<TablePermission>> to entry : Map.Entry<String,Collection<UserPermission>> in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Variable Type p : TablePermission to p : UserPermission in method public checkMultimapEqual(first ListMultimap<String,UserPermission>, second ListMultimap<String,UserPermission>) : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type allPerms : Map<byte[],ListMultimap<String,TablePermission>> to allPerms : Map<byte[],ListMultimap<String,UserPermission>> in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method public testAclTableEntries() : void in class org.apache.hadoop.hbase.security.access.TestNamespaceCommands	From	To
Change Variable Type secondPerms : List<TablePermission> to secondPerms : List<UserPermission> in method public checkMultimapEqual(first ListMultimap<String,UserPermission>, second ListMultimap<String,UserPermission>) : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,Permission> in method public toPermission(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Variable Type permissionsOfUserOnTable : Pair<String,TablePermission> to permissionsOfUserOnTable : Pair<String,Permission> in method private parsePermissions(entryName byte[], result Result, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type permissions : ListMultimap<String,TablePermission> to permissions : ListMultimap<String,UserPermission> in method private createPermissions() : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type userPerms : List<TablePermission> to userPerms : List<UserPermission> in method public testBasicWrite() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type perms : List<TablePermission> to perms : List<UserPermission> in method public testCreateWithCorrectOwner() : void in class org.apache.hadoop.hbase.security.access.TestAccessController2	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method private updateACL(e RegionCoprocessorEnvironment, familyMap Map<byte[],List<Cell>>) : void in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Change Variable Type user2Perms : List<TablePermission> to user2Perms : List<UserPermission> in method public testGlobalPermission() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type copy : ListMultimap<String,TablePermission> to copy : ListMultimap<String,UserPermission> in method public testSerialization() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type tablePerm : TablePermission to perm : Permission in method public toUserTablePermissions(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Variable Type postperms : ListMultimap<String,TablePermission> to postperms : ListMultimap<String,UserPermission> in method public testPersistence() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type preperms : ListMultimap<String,TablePermission> to preperms : ListMultimap<String,UserPermission> in method public testPersistence() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,Permission> in method public restoreSnapshotAcl(snapshot SnapshotDescription, newTableName TableName, conf Configuration) : void in class org.apache.hadoop.hbase.snapshot.RestoreSnapshotHelper	From	To
Change Variable Type namespacePerms : List<TablePermission> to namespacePerms : List<UserPermission> in method public testAclTableEntries() : void in class org.apache.hadoop.hbase.security.access.TestNamespaceCommands	From	To
Change Variable Type allPerms : ListMultimap<String,TablePermission> to allPerms : ListMultimap<String,UserPermission> in method package getUserPermissions(conf Configuration, entryName byte[], cf byte[], cq byte[], user String, hasFilterUser boolean) : List<UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type firstPerms : List<TablePermission> to firstPerms : List<UserPermission> in method public checkMultimapEqual(first ListMultimap<String,UserPermission>, second ListMultimap<String,UserPermission>) : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type acl : List<TablePermission> to acl : List<UserPermission> in method public testPermissionsWatcher() : void in class org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method public testBasicWrite() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type instance : TableAuthManager to instance : AuthManager in method public getOrCreate(watcher ZKWatcher, conf Configuration) : AuthManager in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Variable Type authManager : TableAuthManager to authManager : AuthManager in method public testAuthManager() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type actions : List<TablePermission.Action> to actions : List<Permission.Action> in method public testBasicWrite() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type list : List<TablePermission> to list : List<Permission> in method private readWritableUserPermission(in DataInput, conf Configuration) : List<Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type entry : Map.Entry<String,TablePermission> to entry : Map.Entry<String,UserPermission> in method package getUserPermissions(conf Configuration, entryName byte[], cf byte[], cq byte[], user String, hasFilterUser boolean) : List<UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type perms : ListMultimap<String,TablePermission> to perms : ListMultimap<String,UserPermission> in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type userPerm : UserPermission to tablePermission : TablePermission in method package userPermissionKey(permission UserPermission) : byte[] in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type permissions : TablePermission to permission : Permission in method private parsePermissions(entryName byte[], result Result, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Variable Type allPerms : Map<byte[],ListMultimap<String,TablePermission>> to allPerms : Map<byte[],ListMultimap<String,UserPermission>> in method public testBasicWrite() : void in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Variable Type t : Map.Entry<byte[],ListMultimap<String,TablePermission>> to t : Map.Entry<byte[],ListMultimap<String,UserPermission>> in method private initialize(e RegionCoprocessorEnvironment) : void in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Extract Variable	3
Extract Variable perm : AccessControlProtos.NamespacePermission in method public toPermission(proto AccessControlProtos.Permission) : Permission from class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Extract Variable perm : AccessControlProtos.TablePermission in method public toPermission(proto AccessControlProtos.Permission) : Permission from class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Extract Variable perm : AccessControlProtos.GlobalPermission in method public toPermission(proto AccessControlProtos.Permission) : Permission from class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Extract Method	8
Extract Method protected rawExpression() : String extracted from public toString() : String in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method private failCheckTable(table TableName) : boolean extracted from public implies(namespace String, action Action) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method private failCheckTable(table TableName) : boolean extracted from public implies(table TableName, kv KeyValue, action Action) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method protected rawExpression() : String extracted from public toString() : String in class org.apache.hadoop.hbase.security.access.Permission	From	To
Extract Method public equalsExceptActions(obj Object) : boolean extracted from public equals(obj Object) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method private failCheckFamily(family byte[]) : boolean extracted from public implies(table TableName, family byte[], qualifier byte[], action Action) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method private failCheckTable(table TableName) : boolean extracted from public implies(table TableName, family byte[], qualifier byte[], action Action) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Extract Method private failCheckQualifier(qual byte[]) : boolean extracted from public implies(table TableName, family byte[], qualifier byte[], action Action) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Inline Variable	2
Inline Variable groups : String[] in method public authorize(user User, action Permission.Action) : boolean from class org.apache.hadoop.hbase.security.access.TableAuthManager	From	To
Inline Variable namespace : String in method public toTablePermission(proto AccessControlProtos.Permission) : TablePermission from class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Rename Method	4
Rename Method public groupHasAccess(groupName String, table TableName, action Permission.Action) : boolean renamed to private hasAccessTable(permissions Set<TablePermission>, action Permission.Action) : boolean in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Rename Method private readWritablePermissions(in DataInput, conf Configuration) : List<TablePermission> renamed to private readWritableUserPermission(in DataInput, conf Configuration) : List<Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Rename Method public toTablePermission(proto AccessControlProtos.Permission) : TablePermission renamed to public toPermission(proto AccessControlProtos.Permission) : Permission in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Rename Method public toUserTablePermissions(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,TablePermission> renamed to public toPermission(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Rename Variable	15
Rename Variable tablePerm : TablePermission to perm : Permission in method public toUserTablePermissions(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Rename Variable tablePerm : TablePermission to userPerm : UserPermission in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Rename Variable namespace : String to ns : String in method public toPermission(proto AccessControlProtos.Permission) : Permission in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Rename Variable qualifier : byte[] to q : byte[] in method public filterCell(cell Cell) : ReturnCode in class org.apache.hadoop.hbase.security.access.AccessControlFilter	From	To
Rename Variable userPerm : UserPermission to tablePermission : TablePermission in method package userPermissionKey(permission UserPermission) : byte[] in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Rename Variable permissions : TablePermission to permission : Permission in method private parsePermissions(entryName byte[], result Result, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Rename Variable tablePerm : TablePermission to userPerm : UserPermission in method public toUserTablePermissions(perm ListMultimap<String,UserPermission>) : AccessControlProtos.UsersAndPermissions in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Rename Variable a : Action to action : Action in method public Permission(actionCodes byte[]) in class org.apache.hadoop.hbase.security.access.Permission	From	To
Rename Variable family : byte[] to f : byte[] in method public filterCell(cell Cell) : ReturnCode in class org.apache.hadoop.hbase.security.access.AccessControlFilter	From	To
Rename Variable a : Action to action : Action in method public readFields(in DataInput) : void in class org.apache.hadoop.hbase.security.access.Permission	From	To
Rename Variable str : StringBuilder to raw : StringBuilder in method protected rawExpression() : String in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Rename Variable permissions : TablePermission to permission : Permission in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Rename Variable newTablePerms : PermissionCache<TablePermission> to cacheToUpdate : PermissionCache<TablePermission> in method private updateTableCache(table TableName, tablePerms ListMultimap<String,Permission>) : void in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Rename Variable str : StringBuilder to raw : StringBuilder in method protected rawExpression() : String in class org.apache.hadoop.hbase.security.access.Permission	From	To
Rename Variable userperm : UserPermission to userPermission : UserPermission in method public postCompletedCreateTableAction(c ObserverContext<MasterCoprocessorEnvironment>, desc TableDescriptor, regions RegionInfo[]) : void in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Inline Method	1
Inline Method public toTablePermission(proto AccessControlProtos.Permission) : TablePermission inlined to public toPermission(proto AccessControlProtos.Permission) : Permission in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Return Type	18
Change Return Type TableAuthManager to AuthManager in method public getAuthManager() : AuthManager in class org.apache.hadoop.hbase.security.access.AccessController	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,UserPermission> in method public getNamespacePermissions(conf Configuration, namespace String) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type List<TablePermission> to List<Permission> in method private readWritableUserPermission(in DataInput, conf Configuration) : List<Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,UserPermission> in method private parsePermissions(entryName byte[], result Result, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,UserPermission> in method private createPermissions() : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.TestTablePermissions	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,Permission> in method public readPermissions(data byte[], conf Configuration) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type TableAuthManager to AuthManager in method public getAuthManager() : AuthManager in class org.apache.hadoop.hbase.security.access.AccessChecker	From	To
Change Return Type PermissionCache<Permission> to Map<String,GlobalPermission> in method private initGlobal(conf Configuration) : Map<String,GlobalPermission> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Return Type byte[] to String in method public getUser() : String in class org.apache.hadoop.hbase.security.access.UserPermission	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,Permission> in method public toUserTablePermissions(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Return Type TableAuthManager to AuthManager in method public getOrCreate(watcher ZKWatcher, conf Configuration) : AuthManager in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Return Type Map<byte[],ListMultimap<String,TablePermission>> to Map<byte[],ListMultimap<String,UserPermission>> in method package loadAll(aclRegion Region) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type Map<byte[],ListMultimap<String,TablePermission>> to Map<byte[],ListMultimap<String,UserPermission>> in method package loadAll(conf Configuration) : Map<byte[],ListMultimap<String,UserPermission>> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type TablePermission to Permission in method public toPermission(proto AccessControlProtos.Permission) : Permission in class org.apache.hadoop.hbase.security.access.ShadedAccessControlUtil	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,UserPermission> in method package getPermissions(conf Configuration, entryName byte[], t Table, cf byte[], cq byte[], user String, hasFilterUser boolean) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,Permission> in method public toPermission(proto AccessControlProtos.UsersAndPermissions) : ListMultimap<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlUtil	From	To
Change Return Type Pair<String,TablePermission> to Pair<String,Permission> in method private parsePermissionRecord(entryName byte[], kv Cell, cf byte[], cq byte[], filterPerms boolean, filterUser String) : Pair<String,Permission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Change Return Type ListMultimap<String,TablePermission> to ListMultimap<String,UserPermission> in method public getTablePermissions(conf Configuration, tableName TableName) : ListMultimap<String,UserPermission> in class org.apache.hadoop.hbase.security.access.AccessControlLists	From	To
Rename Attribute	1
Rename Attribute nsCache : ConcurrentSkipListMap<String,PermissionCache<TablePermission>> to namespaceCache : ConcurrentHashMap<String,PermissionCache<NamespacePermission>> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Attribute Type	12
Change Attribute Type authManager : TableAuthManager to authManager : AuthManager in class org.apache.hadoop.hbase.security.access.AccessChecker	From	To
Change Attribute Type user : byte[] to user : String in class org.apache.hadoop.hbase.security.access.UserPermission	From	To
Change Attribute Type nsCache : ConcurrentSkipListMap<String,PermissionCache<TablePermission>> to namespaceCache : ConcurrentHashMap<String,PermissionCache<NamespacePermission>> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Attribute Type authManager : TableAuthManager to authManager : AuthManager in class org.apache.hadoop.hbase.security.access.ZKPermissionWatcher	From	To
Change Attribute Type AUTH_B : TableAuthManager to AUTH_B : AuthManager in class org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher	From	To
Change Attribute Type AUTH_A : TableAuthManager to AUTH_A : AuthManager in class org.apache.hadoop.hbase.security.access.TestZKPermissionWatcher	From	To
Change Attribute Type refCount : Map<TableAuthManager,Integer> to refCount : Map<AuthManager,Integer> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Attribute Type tableCache : ConcurrentSkipListMap<TableName,PermissionCache<TablePermission>> to tableCache : ConcurrentHashMap<TableName,PermissionCache<TablePermission>> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Attribute Type globalCache : PermissionCache<Permission> to globalCache : Map<String,GlobalPermission> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Change Attribute Type authManager : TableAuthManager to authManager : AuthManager in class org.apache.hadoop.hbase.security.access.AccessControlFilter	From	To
Change Attribute Type actions : Action[] to actions : EnumSet<Action> in class org.apache.hadoop.hbase.security.access.Permission	From	To
Change Attribute Type managerMap : Map<ZKWatcher,TableAuthManager> to managerMap : Map<ZKWatcher,AuthManager> in class org.apache.hadoop.hbase.security.access.AuthManager	From	To
Rename Parameter	2
Rename Parameter namespace : String to table : TableName in method private failCheckTable(table TableName) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To
Rename Parameter other : TablePermission to tp : TablePermission in method public tableFieldsEqual(tp TablePermission) : boolean in class org.apache.hadoop.hbase.security.access.TablePermission	From	To

130057f13774f6b213cdb06952c805a29d59396e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: