18a48af2424a9a45d24c08014d4948e3274513a1
Files Diff
- Added: 3
- Removed: 4
- Renamed: 0
- Modified: 20
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 3 | ||
Rename Method private getRunQueueOrCreate(table TableName) : TableRunQueue renamed to private getTablePriority(tableName TableName) : int in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Method private getRunQueue(table TableName) : TableRunQueue renamed to private getTableQueue(tableName TableName) : TableQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Method private getRunQueueOrCreate(proc Procedure) : RunQueue renamed to private doAdd(proc Procedure, addFront boolean) : void in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Parameter Type | 3 | ||
Change Parameter Type queue : MasterProcedureQueue to queue : MasterProcedureScheduler in method public TestTableProcSet(queue MasterProcedureScheduler) in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.TestTableProcSet | From | To | |
Change Parameter Type spi : ServerProcedureInterface to serverName : ServerName in method public tryAcquireServerSharedLock(serverName ServerName) : boolean in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Parameter Type spi : ServerProcedureInterface to serverName : ServerName in method public releaseServerSharedLock(serverName ServerName) : void in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Inline Method | 1 | ||
Inline Method private createTableRunQueue(table TableName) : TableRunQueue inlined to private getTablePriority(tableName TableName) : int in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Variable | 2 | ||
Rename Variable procId : Long to xProc : Procedure in method public acquire() : TableProcedureInterface in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.TestTableProcSet | From | To | |
Rename Variable procId : Long to proc : Procedure in method public testSimpleTableOpsQueues() : void in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Change Return Type | 7 | ||
Change Return Type TableRunQueue to TableQueue in method private getTableQueue(tableName TableName) : TableQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Return Type Long to Procedure in method public poll() : Procedure in class org.apache.hadoop.hbase.procedure2.ProcedureSimpleRunQueue | From | To | |
Change Return Type TableRunQueue to int in method private getTablePriority(tableName TableName) : int in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Return Type Long to Procedure in method public poll() : Procedure in class org.apache.hadoop.hbase.procedure2.ProcedureRunnableSet | From | To | |
Change Return Type MasterProcedureQueue to MasterProcedureScheduler in method public getProcedureQueue() : MasterProcedureScheduler in class org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv | From | To | |
Change Return Type Long to Procedure in method public poll() : Procedure in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Return Type RunQueue to void in method private doAdd(proc Procedure, addFront boolean) : void in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Class | 2 | ||
Rename Class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureQueue renamed to org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Rename Class org.apache.hadoop.hbase.master.procedure.MasterProcedureQueue renamed to org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Attribute | 1 | ||
Rename Attribute procQueue : MasterProcedureQueue to procSched : MasterProcedureScheduler in class org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv | From | To | |
Change Variable Type | 6 | ||
Change Variable Type queue : TableRunQueue to queue : TableQueue in method protected markTableAsDeleted(table TableName) : boolean in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Variable Type procId : Long to proc : Procedure in method public testSimpleTableOpsQueues() : void in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Change Variable Type procQueue : MasterProcedureQueue to procQueue : MasterProcedureScheduler in method public testConcurrentCreateDelete() : void in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Change Variable Type procId : Long to xProc : Procedure in method public acquire() : TableProcedureInterface in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.TestTableProcSet | From | To | |
Change Variable Type pollResult : Long to pollResult : Procedure in method package poll(waitNsec long) : Procedure in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Variable Type procId : Long to procId : long in method public testVerifyRwLocks() : void in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Extract Method | 4 | ||
Extract Method private isTableProcedure(proc Procedure) : boolean extracted from private getRunQueueOrCreate(proc Procedure) : RunQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Extract Method private getTableName(proc Procedure) : TableName extracted from private getRunQueueOrCreate(proc Procedure) : RunQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Extract Method package poll(waitNsec long) : Procedure extracted from public poll() : Long in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Extract Method private isServerProcedure(proc Procedure) : boolean extracted from private getRunQueueOrCreate(proc Procedure) : RunQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Change Attribute Type | 6 | ||
Change Attribute Type initialized : boolean to initialized : ProcedureEvent in class org.apache.hadoop.hbase.master.HMaster | From | To | |
Change Attribute Type queue : MasterProcedureQueue to queue : MasterProcedureScheduler in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler.TestTableProcSet | From | To | |
Change Attribute Type procQueue : MasterProcedureQueue to procSched : MasterProcedureScheduler in class org.apache.hadoop.hbase.master.procedure.MasterProcedureEnv | From | To | |
Change Attribute Type serverCrashProcessingEnabled : boolean to serverCrashProcessingEnabled : ProcedureEvent in class org.apache.hadoop.hbase.master.HMaster | From | To | |
Change Attribute Type queue : MasterProcedureQueue to queue : MasterProcedureScheduler in class org.apache.hadoop.hbase.master.procedure.TestMasterProcedureScheduler | From | To | |
Change Attribute Type runnables : Deque<Long> to runnables : Deque<Procedure> in class org.apache.hadoop.hbase.procedure2.ProcedureSimpleRunQueue | From | To | |
Rename Parameter | 5 | ||
Rename Parameter table : TableName to tableName : TableName in method private getTableQueue(tableName TableName) : TableQueue in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Parameter spi : ServerProcedureInterface to serverName : ServerName in method public releaseServerSharedLock(serverName ServerName) : void in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Parameter table : TableName to tableName : TableName in method private getTablePriority(tableName TableName) : int in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To | |
Rename Parameter spi : ServerProcedureInterface to serverName : ServerName in method public tryAcquireServerSharedLock(serverName ServerName) : boolean in class org.apache.hadoop.hbase.master.procedure.MasterProcedureScheduler | From | To |