hbase 2093aadec1433c1376d1a9a6166e94a257a811b2

2093aadec1433c1376d1a9a6166e94a257a811b2

Files Diff

Added: 4
Removed: 1
Renamed: 0
Modified: 11

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	7
Pull Up Method private createAndGetReplicationTable() : Table from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private createAndGetReplicationTable() : Table from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private getRawQueueIdFromRowKey(rowKey String) : String from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to protected getRawQueueIdFromRowKey(rowKey String) : String from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private createReplicationTable() : void from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private createReplicationTable() : void from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private replicationTableExists() : boolean from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private replicationTableExists() : boolean from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private getQueuesBelongingToServer(server String) : ResultScanner from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private getQueuesBelongingToServer(server String) : ResultScanner from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private buildQueueRowKey(serverName String, queueId String) : String from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to protected buildQueueRowKey(serverName String, queueId String) : String from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Method private buildClaimedQueueHistory(originalHistory String, oldServer String) : String from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to protected buildClaimedQueueHistory(originalHistory String, oldServer String) : String from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Move And Rename Method	1
Move And Rename Method private loadWALsFromQueues() : Set<String> from class org.apache.hadoop.hbase.replication.master.ReplicationLogCleaner to public getAllWALs() : Set<String> from class org.apache.hadoop.hbase.replication.ReplicationQueuesClientZKImpl	From	To
Rename Variable	1
Rename Variable wals : List<String> to logs : List<String> in method private getLogsInQueueAndCheckOwnership(rowKey byte[]) : List<String> in class org.apache.hadoop.hbase.replication.TableBasedReplicationQueuesImpl	From	To
Inline Method	1
Inline Method private readWALsFromResult(queue Result) : List<String> inlined to private getLogsInQueueAndCheckOwnership(rowKey byte[]) : List<String> in class org.apache.hadoop.hbase.replication.TableBasedReplicationQueuesImpl	From	To
Pull Up Attribute	9
Pull Up Attribute private replicationTable : Table from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to protected replicationTable : Table from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private RPC_TIMEOUT : int from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private RPC_TIMEOUT : int from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private REPLICATION_COL_DESCRIPTOR : HColumnDescriptor from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private REPLICATION_COL_DESCRIPTOR : HColumnDescriptor from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private connection : Connection from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private connection : Connection from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private CLIENT_RETRIES : int from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private CLIENT_RETRIES : int from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private ROW_KEY_DELIMITER : String from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to public ROW_KEY_DELIMITER : String from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute public REPLICATION_TABLE_NAME : TableName from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to public REPLICATION_TABLE_NAME : TableName from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private admin : Admin from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private admin : Admin from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Pull Up Attribute private OPERATION_TIMEOUT : int from class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl to private OPERATION_TIMEOUT : int from class org.apache.hadoop.hbase.replication.ReplicationTableBase	From	To
Rename Class	1
Rename Class org.apache.hadoop.hbase.replication.ReplicationQueuesHBaseImpl renamed to org.apache.hadoop.hbase.replication.TableBasedReplicationQueuesImpl	From	To
Extract Superclass	1
Extract Superclass org.apache.hadoop.hbase.replication.ReplicationTableBase from classes [org.apache.hadoop.hbase.replication.TableBasedReplicationQueuesImpl]	From	To
Change Variable Type	2
Change Variable Type rqcMock : ReplicationQueuesClient to rqcMock : ReplicationQueuesClientZKImpl in method public testZnodeCversionChange() : void in class org.apache.hadoop.hbase.master.cleaner.TestLogsCleaner	From	To
Change Variable Type client : ReplicationQueuesClient to client : ReplicationQueuesClientZKImpl in method public testFailoverDeadServerCversionChange() : void in class org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManager	From	To

2093aadec1433c1376d1a9a6166e94a257a811b2

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: