39dd81a7c69763475e5a72f6c84e0f450fd957e5
Files Diff
- Added: 3
- Removed: 1
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type procedure : ModifyPeerProcedure to procedure : AbstractPeerProcedure<?> in method private executePeerProcedure(procedure AbstractPeerProcedure<?>) : long in class org.apache.hadoop.hbase.master.HMaster | From | To | |
| Change Parameter Type state : PeerModificationState to state : TState in method protected rollbackState(env MasterProcedureEnv, state TState) : void in class org.apache.hadoop.hbase.master.replication.AbstractPeerProcedure | From | To | |
| Move Method | 1 | ||
| Move Method private getPeerIdAndRemoteWALDir(info RegionInfo) : Optional<Pair<String,String>> from class org.apache.hadoop.hbase.wal.TestSyncReplicationWALProvider to public getPeerIdAndRemoteWALDir(info RegionInfo) : Optional<Pair<String,String>> from class org.apache.hadoop.hbase.wal.TestSyncReplicationWALProvider.InfoProvider | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.hbase.replication.regionserver.SyncReplicationPeerProvider renamed to org.apache.hadoop.hbase.replication.regionserver.SyncReplicationPeerInfoProvider | From | To | |
| Split Parameter | 1 | ||
| Split Parameter clusterState : SyncReplicationState to [from : SyncReplicationState, to : SyncReplicationState] in method public postTransitReplicationPeerSyncReplicationState(peerId String, from SyncReplicationState, to SyncReplicationState) : void in class org.apache.hadoop.hbase.master.MasterCoprocessorHost | From | To | |
| Split Attribute | 1 | ||
| Split Attribute state : SyncReplicationState to [fromState : SyncReplicationState, toState : SyncReplicationState] in class org.apache.hadoop.hbase.master.replication.TransitPeerSyncReplicationStateProcedure | From | To | |
| Extract Method | 1 | ||
| Extract Method private getSyncReplicationState(peerId String, path String) : SyncReplicationState extracted from public getPeerSyncReplicationState(peerId String) : SyncReplicationState in class org.apache.hadoop.hbase.replication.ZKReplicationPeerStorage | From | To | |
| Rename Method | 7 | ||
| Rename Method protected updatePeerStorage(env MasterProcedureEnv) : void renamed to private getRegionsToReopen(env MasterProcedureEnv) : List<RegionInfo> in class org.apache.hadoop.hbase.master.replication.TransitPeerSyncReplicationStateProcedure | From | To | |
| Rename Method public peerRemoved(peerId String) : void renamed to public peerSyncReplicationStateChange(peerId String, from SyncReplicationState, to SyncReplicationState, stage int) : void in class org.apache.hadoop.hbase.wal.SyncReplicationWALProvider | From | To | |
| Rename Method public setPeerSyncReplicationState(peerId String, state SyncReplicationState) : void renamed to public setPeerNewSyncReplicationState(peerId String, state SyncReplicationState) : void in class org.apache.hadoop.hbase.replication.ReplicationPeerStorage | From | To | |
| Rename Method protected postPeerModification(env MasterProcedureEnv) : void renamed to private postTransit(env MasterProcedureEnv) : void in class org.apache.hadoop.hbase.master.replication.TransitPeerSyncReplicationStateProcedure | From | To | |
| Rename Method protected prePeerModification(env MasterProcedureEnv) : void renamed to private preTransit(env MasterProcedureEnv) : void in class org.apache.hadoop.hbase.master.replication.TransitPeerSyncReplicationStateProcedure | From | To | |
| Rename Method public setPeerSyncReplicationState(peerId String, state SyncReplicationState) : void renamed to public setPeerNewSyncReplicationState(peerId String, state SyncReplicationState) : void in class org.apache.hadoop.hbase.replication.ZKReplicationPeerStorage | From | To | |
| Rename Method public peerRemoved(peerId String) : void renamed to public peerSyncReplicationStateChange(peerId String, from SyncReplicationState, to SyncReplicationState, stage int) : void in class org.apache.hadoop.hbase.replication.regionserver.PeerActionListener | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method protected rollbackState(env MasterProcedureEnv, state PeerModificationState) : void from class org.apache.hadoop.hbase.master.replication.ModifyPeerProcedure to protected rollbackState(env MasterProcedureEnv, state TState) : void from class org.apache.hadoop.hbase.master.replication.AbstractPeerProcedure | From | To | |
| Inline Method | 2 | ||
| Inline Method private getProvider(key String, defaultValue String, providerId String) : WALProvider inlined to public WALFactory(conf Configuration, factoryId String) in class org.apache.hadoop.hbase.wal.WALFactory | From | To | |
| Inline Method private getProvider(key String, defaultValue String, providerId String) : WALProvider inlined to private getMetaProvider() : WALProvider in class org.apache.hadoop.hbase.wal.WALFactory | From | To | |
| Change Return Type | 3 | ||
| Change Return Type void to SyncReplicationState in method public preTransitPeerSyncReplicationState(peerId String, state SyncReplicationState) : SyncReplicationState in class org.apache.hadoop.hbase.master.replication.ReplicationPeerManager | From | To | |
| Change Return Type void to ReplicationPeerImpl in method public removePeer(peerId String) : ReplicationPeerImpl in class org.apache.hadoop.hbase.replication.ReplicationPeers | From | To | |
| Change Return Type void to List<RegionInfo> in method private getRegionsToReopen(env MasterProcedureEnv) : List<RegionInfo> in class org.apache.hadoop.hbase.master.replication.TransitPeerSyncReplicationStateProcedure | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute peerProvider : SyncReplicationPeerProvider to peerInfoProvider : SyncReplicationPeerInfoProvider in class org.apache.hadoop.hbase.wal.SyncReplicationWALProvider | From | To | |
| Rename Attribute SYNCHRONOUS_REPLICATION_STATE_ZNODE : String to SYNC_REPLICATION_STATE_ZNODE : String in class org.apache.hadoop.hbase.replication.ZKReplicationPeerStorage | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type peerProvider : SyncReplicationPeerProvider to peerInfoProvider : SyncReplicationPeerInfoProvider in class org.apache.hadoop.hbase.wal.SyncReplicationWALProvider | From | To | |
| Change Attribute Type allowedTransition : EnumMap<SyncReplicationState,EnumSet<SyncReplicationState>> to allowedTransition : ImmutableMap<SyncReplicationState,EnumSet<SyncReplicationState>> in class org.apache.hadoop.hbase.master.replication.ReplicationPeerManager | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter clusterState : SyncReplicationState to state : SyncReplicationState in method public preTransitReplicationPeerSyncReplicationState(peerId String, state SyncReplicationState) : void in class org.apache.hadoop.hbase.master.MasterCoprocessorHost | From | To | |
| Rename Parameter state : SyncReplicationState to newState : SyncReplicationState in method public transitPeerSyncReplicationState(peerId String, newState SyncReplicationState) : void in class org.apache.hadoop.hbase.master.replication.ReplicationPeerManager | From | To |