3abd13dacb57927bd44a47632f4bd0c2e2bb87ea
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type controller : RpcController to controller : HBaseRpcController in method private addResults(builder ScanResponse.Builder, results List<Result>, controller HBaseRpcController, isDefaultRegion boolean, clientCellBlockSupported boolean) : void in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Rename Variable | 1 | ||
| Rename Variable ttl : int to moreResultsInRegion : boolean in method public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Change Return Type | 1 | ||
| Change Return Type boolean to void in method private closeScanner(region Region, scanner RegionScanner, scannerName String, context RpcCallContext) : void in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type ttl : int to moreResultsInRegion : boolean in method public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Variable | 1 | ||
| Extract Variable msg : String in method private getRegionScanner(request ScanRequest) : RegionScannerHolder from class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type scanners : ConcurrentHashMap<String,RegionScannerHolder> to scanners : ConcurrentMap<String,RegionScannerHolder> in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method | 7 | ||
| Extract Method private newRegionScanner(request ScanRequest, builder ScanResponse.Builder) : Pair<RegionScannerHolder,Boolean> extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method private getRegionScanner(request ScanRequest) : RegionScannerHolder extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method private getTimeLimit(controller HBaseRpcController, allowHeartbeatMessages boolean) : long extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method protected closeScanner() : void extracted from protected nextScanner(nbRows int, done boolean) : boolean in class org.apache.hadoop.hbase.client.ClientScanner | From | To | |
| Extract Method private scan(controller HBaseRpcController, request ScanRequest, rsh RegionScannerHolder, isSmallScan boolean, maxQuotaResultSize long, rows int, results List<Result>, builder ScanResponse.Builder, lastBlock MutableObject, context RpcCallContext) : boolean extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method private checkScanNextCallSeq(request ScanRequest, rsh RegionScannerHolder) : void extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract Method private addScannerLeaseBack(lease Leases.Lease) : void extracted from public scan(controller RpcController, request ScanRequest) : ScanResponse in class org.apache.hadoop.hbase.regionserver.RSRpcServices | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected closeScanner() : void extracted from protected nextScanner(nbRows int, done boolean) : boolean in class org.apache.hadoop.hbase.client.ReversedClientScanner & moved to class org.apache.hadoop.hbase.client.ClientScanner | From | To |