3f75ba195c62b1752f4a3f6a408c74f16ea6b0d4
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 3 | ||
| Pull Up Method package readPreamble(buffer ByteBuf) : void from class org.apache.hadoop.hbase.ipc.NettyServerRpcConnection to protected processPreamble(preambleBuffer ByteBuffer) : boolean from class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Pull Up Method private doBadPreambleHandling(msg String) : int from class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection to private doBadPreambleHandling(msg String) : void from class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Pull Up Method private doBadPreambleHandling(msg String) : void from class org.apache.hadoop.hbase.ipc.NettyServerRpcConnection to private doBadPreambleHandling(msg String) : void from class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method protected setupResponse(response ByteArrayOutputStream, call ServerCall<?>, t Throwable, error String) : void moved from class org.apache.hadoop.hbase.ipc.RpcServer to class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection & inlined to public readAndProcess() : int | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type call : SimpleServerCall to resp : RpcResponse in method private processResponse(conn SimpleServerRpcConnection, resp RpcResponse) : boolean in class org.apache.hadoop.hbase.ipc.SimpleRpcServerResponder | From | To | |
| Change Parameter Type buffer : ByteBuf to preambleBuffer : ByteBuffer in method protected processPreamble(preambleBuffer ByteBuffer) : boolean in class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Rename Variable | 1 | ||
| Rename Variable call : SimpleServerCall to resp : RpcResponse in method private processAllResponses(connection SimpleServerRpcConnection) : boolean in class org.apache.hadoop.hbase.ipc.SimpleRpcServerResponder | From | To | |
| Inline Method | 2 | ||
| Inline Method private doBadPreambleHandling(msg String, e Exception) : int inlined to private readPreamble() : int in class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection | From | To | |
| Inline Method private doConnectionHeaderResponse(wrappedCipherMetaData byte[]) : void inlined to private responseConnectionHeader(chrBuilder RPCProtos.ConnectionHeaderResponse.Builder) : void in class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Change Return Type | 2 | ||
| Change Return Type int to void in method private doBadPreambleHandling(msg String) : void in class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Change Return Type void to boolean in method protected processPreamble(preambleBuffer ByteBuffer) : boolean in class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To | |
| Move Attribute | 1 | ||
| Move Attribute package lastSentTime : long from class org.apache.hadoop.hbase.ipc.SimpleServerCall to package lastSentTime : long from class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute protected connectionPreambleRead : boolean from class org.apache.hadoop.hbase.ipc.ServerRpcConnection to private connectionPreambleRead : boolean from class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.hbase.ipc.NettyRpcServer.MessageDecoder moved and renamed to org.apache.hadoop.hbase.ipc.NettyRpcServerRequestDecoder | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type call : SimpleServerCall to resp : RpcResponse in method private processAllResponses(connection SimpleServerRpcConnection) : boolean in class org.apache.hadoop.hbase.ipc.SimpleRpcServerResponder | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.hadoop.hbase.ipc.RpcResponse from classes [org.apache.hadoop.hbase.ipc.ServerCall] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type responseQueue : ConcurrentLinkedDeque<SimpleServerCall> to responseQueue : ConcurrentLinkedDeque<RpcResponse> in class org.apache.hadoop.hbase.ipc.SimpleServerRpcConnection | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter call : SimpleServerCall to resp : RpcResponse in method private processResponse(conn SimpleServerRpcConnection, resp RpcResponse) : boolean in class org.apache.hadoop.hbase.ipc.SimpleRpcServerResponder | From | To | |
| Rename Parameter buffer : ByteBuf to preambleBuffer : ByteBuffer in method protected processPreamble(preambleBuffer ByteBuffer) : boolean in class org.apache.hadoop.hbase.ipc.ServerRpcConnection | From | To |