45a2594249dcb624eca664c09fcfae414916ac6b
Files Diff
- Added: 0
- Removed: 1
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private createCipherHelper() : CipherOptionHelper renamed to private createPBHelper() : PBHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Rename Method package createCryptoCodec(conf Configuration, stat HdfsFileStatus, client DFSClient) : CryptoCodec renamed to package createEncryptor(conf Configuration, stat HdfsFileStatus, client DFSClient) : Encryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type cryptoCodec : CryptoCodec to encryptor : Encryptor in method package FanOutOneBlockAsyncDFSOutput(conf Configuration, fsUtils FSUtils, dfs DistributedFileSystem, client DFSClient, namenode ClientProtocol, clientName String, src String, fileId long, locatedBlock LocatedBlock, encryptor Encryptor, eventLoop EventLoop, datanodeList List<Channel>, summer DataChecksum, alloc ByteBufAllocator) in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput | From | To | |
| Change Parameter Type options : List<Object> to options : List<CipherOption> in method private sendSaslMessage(ctx ChannelHandlerContext, payload byte[], options List<CipherOption>) : void in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.SaslNegotiateHandler | From | To | |
| Rename Variable | 3 | ||
| Rename Variable cryptocodec : CryptoCodec to encryptor : Encryptor in method private createOutput(dfs DistributedFileSystem, src String, overwrite boolean, createParent boolean, replication short, blockSize long, eventLoop EventLoop) : FanOutOneBlockAsyncDFSOutput in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper | From | To | |
| Rename Variable client : DFSClient to saslClient : SaslDataTransferClient in method package trySaslNegotiate(conf Configuration, channel Channel, dnInfo DatanodeInfo, timeoutMs int, client DFSClient, accessToken Token<BlockTokenIdentifier>, saslPromise Promise<Void>) : void in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Rename Variable cipherOptionClass : Class<?> to helperClass : Class<?> in method private createPBHelper() : PBHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Inline Method | 4 | ||
| Inline Method private createSaslAdaptor27(saslDataTransferClientClass Class<?>) : SaslAdaptor inlined to private createSaslAdaptor() : SaslAdaptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Inline Method private createTransparentCryptoHelper27(feInfoClass Class<?>) : TransparentCryptoHelper inlined to private createTransparentCryptoHelper() : TransparentCryptoHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Inline Method private createTransparentCryptoHelper25() : TransparentCryptoHelper inlined to private createTransparentCryptoHelper() : TransparentCryptoHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Inline Method private createLeaseManager25() : LeaseManager inlined to private createLeaseManager() : LeaseManager in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to CompletableFuture<Long> in method public sync() : CompletableFuture<Long> in class org.apache.hadoop.hbase.wal.WALProvider.AsyncWriter | From | To | |
| Change Return Type CryptoCodec to Encryptor in method package createEncryptor(conf Configuration, stat HdfsFileStatus, client DFSClient) : Encryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Return Type CipherOptionHelper to PBHelper in method private createPBHelper() : PBHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Return Type void to CompletableFuture<Long> in method public sync() : CompletableFuture<Long> in class org.apache.hadoop.hbase.regionserver.wal.AsyncProtobufLogWriter | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute codec : CryptoCodec to decryptor : Decryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.DecryptHandler | From | To | |
| Rename Attribute codec : CryptoCodec to encryptor : Encryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.EncryptHandler | From | To | |
| Change Variable Type | 10 | ||
| Change Variable Type cipherOption : Object to cipherOption : CipherOption in method public channelRead(ctx ChannelHandlerContext, msg Object) : void in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.SaslNegotiateHandler | From | To | |
| Change Variable Type cryptocodec : CryptoCodec to encryptor : Encryptor in method private createOutput(dfs DistributedFileSystem, src String, overwrite boolean, createParent boolean, replication short, blockSize long, eventLoop EventLoop) : FanOutOneBlockAsyncDFSOutput in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper | From | To | |
| Change Variable Type e : IllegalAccessException|InvocationTargetException to e : IllegalAccessException in method private createSaslAdaptor() : SaslAdaptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Variable Type client : DFSClient to saslClient : SaslDataTransferClient in method package trySaslNegotiate(conf Configuration, channel Channel, dnInfo DatanodeInfo, timeoutMs int, client DFSClient, accessToken Token<BlockTokenIdentifier>, saslPromise Promise<Void>) : void in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Variable Type feInfo : Object to feInfo : FileEncryptionInfo in method private createTransparentCryptoHelper() : TransparentCryptoHelper in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper | From | To | |
| Change Variable Type cipherOptions : List<Object> to cipherOptions : List<CipherOption> in method public channelRead(ctx ChannelHandlerContext, msg Object) : void in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.SaslNegotiateHandler | From | To | |
| Change Variable Type builder : Builder to builder : OpWriteBlockProto.Builder in method private createStorageTypeSetter() : StorageTypeSetter in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputHelper | From | To | |
| Extract Method | 2 | ||
| Extract Method private syncCompleted(writer AsyncWriter, processedTxid long, startTimeNs long) : void extracted from private sync(writer AsyncWriter, processedTxid long) : void in class org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL | From | To | |
| Extract Method private syncFailed(error Throwable) : void extracted from private sync(writer AsyncWriter, processedTxid long) : void in class org.apache.hadoop.hbase.regionserver.wal.AsyncFSWAL | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type codec : CryptoCodec to decryptor : Decryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.DecryptHandler | From | To | |
| Change Attribute Type codec : CryptoCodec to encryptor : Encryptor in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutputSaslHelper.EncryptHandler | From | To | |
| Inline Variable | 1 | ||
| Inline Variable len : int in method private write0(bb ByteBuffer) : void from class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter cryptoCodec : CryptoCodec to encryptor : Encryptor in method package FanOutOneBlockAsyncDFSOutput(conf Configuration, fsUtils FSUtils, dfs DistributedFileSystem, client DFSClient, namenode ClientProtocol, clientName String, src String, fileId long, locatedBlock LocatedBlock, encryptor Encryptor, eventLoop EventLoop, datanodeList List<Channel>, summer DataChecksum, alloc ByteBufAllocator) in class org.apache.hadoop.hbase.io.asyncfs.FanOutOneBlockAsyncDFSOutput | From | To |