4b91a6425eadc3578ec291496bbf7fde9742f96a
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Inline Method | 1 | ||
Inline Method public listHFiles(fs FileSystem, tableDir Path) : Path[] inlined to public listHFileNames(fs FileSystem, tableDir Path) : ArrayList<String> in class org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils | From | To | |
Rename Variable | 2 | ||
Rename Variable names : String[] to hfiles : ArrayList<String> in method public listHFileNames(fs FileSystem, tableDir Path) : ArrayList<String> in class org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils | From | To | |
Rename Variable regionManifests : List<SnapshotRegionManifest> to restoredRegions : List<HRegionInfo> in method private init() : void in class org.apache.hadoop.hbase.client.TableSnapshotScanner | From | To | |
Change Return Type | 2 | ||
Change Return Type void to RestoreMetaChanges in method public copySnapshotForScanner(conf Configuration, fs FileSystem, rootDir Path, restoreDir Path, snapshotName String) : RestoreMetaChanges in class org.apache.hadoop.hbase.snapshot.RestoreSnapshotHelper | From | To | |
Change Return Type String[] to ArrayList<String> in method public listHFileNames(fs FileSystem, tableDir Path) : ArrayList<String> in class org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils | From | To | |
Change Variable Type | 5 | ||
Change Variable Type names : String[] to hfiles : ArrayList<String> in method public listHFileNames(fs FileSystem, tableDir Path) : ArrayList<String> in class org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils | From | To | |
Change Variable Type storeFiles : List<StoreFileInfo> to storeFiles : ArrayList<StoreFileInfo> in method private getStoreFiles(storeDir Path) : List<StoreFileInfo> in class org.apache.hadoop.hbase.snapshot.SnapshotManifest | From | To | |
Change Variable Type regionManifests : List<SnapshotRegionManifest> to restoredRegions : List<HRegionInfo> in method private init() : void in class org.apache.hadoop.hbase.client.TableSnapshotScanner | From | To | |
Change Variable Type hfiles : ArrayList<Path> to hfiles : ArrayList<String> in method public listHFileNames(fs FileSystem, tableDir Path) : ArrayList<String> in class org.apache.hadoop.hbase.snapshot.SnapshotTestingUtils | From | To | |
Change Variable Type files : String[] to files : List<String> in method private verifyRestore(rootDir Path, sourceHtd HTableDescriptor, htdClone HTableDescriptor) : void in class org.apache.hadoop.hbase.snapshot.TestRestoreSnapshotHelper | From | To | |
Extract Method | 4 | ||
Extract Method public cloneRegionInfo(tableName TableName, snapshotRegionInfo HRegionInfo) : HRegionInfo extracted from public cloneRegionInfo(snapshotRegionInfo HRegionInfo) : HRegionInfo in class org.apache.hadoop.hbase.snapshot.RestoreSnapshotHelper | From | To | |
Extract Method private addReferenceFiles(visitor RegionVisitor, regionData Object, familyData Object, storeFiles Collection<StoreFileInfo>, isMob boolean) : void extracted from public addRegion(tableDir Path, regionInfo HRegionInfo) : void in class org.apache.hadoop.hbase.snapshot.SnapshotManifest | From | To | |
Extract Method private getStoreFiles(storeDir Path) : List<StoreFileInfo> extracted from public addRegion(tableDir Path, regionInfo HRegionInfo) : void in class org.apache.hadoop.hbase.snapshot.SnapshotManifest | From | To | |
Extract Method private getStoreFiles(storeDir Path) : List<StoreFileInfo> extracted from public addMobRegion(regionInfo HRegionInfo, hcds HColumnDescriptor[]) : void in class org.apache.hadoop.hbase.snapshot.SnapshotManifest | From | To | |
Extract And Move Method | 1 | ||
Extract And Move Method public logFileSystemState(log Log) : void extracted from private logFSTree() : void in class org.apache.hadoop.hbase.snapshot.TestRestoreFlushSnapshotFromClient & moved to class org.apache.hadoop.hbase.master.MasterFileSystem | From | To |