54028140f4f19a6af81c8c8f29dda0c52491a0c9
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 4 | ||
| Pull Up Method private createServerMap(numNodes int, numRegions int, numRegionsPerServer int, replication int, numTables int) : Map<ServerName,List<HRegionInfo>> from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected createServerMap(numNodes int, numRegions int, numRegionsPerServer int, replication int, numTables int) : Map<ServerName,List<HRegionInfo>> from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Method protected testWithCluster(numNodes int, numRegions int, numRegionsPerServer int, replication int, numTables int, assertFullyBalanced boolean, assertFullyBalancedForReplicas boolean) : void from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected testWithCluster(numNodes int, numRegions int, numRegionsPerServer int, replication int, numTables int, assertFullyBalanced boolean, assertFullyBalancedForReplicas boolean) : void from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Method protected testWithCluster(serverMap Map<ServerName,List<HRegionInfo>>, rackManager RackManager, assertFullyBalanced boolean, assertFullyBalancedForReplicas boolean) : void from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected testWithCluster(serverMap Map<ServerName,List<HRegionInfo>>, rackManager RackManager, assertFullyBalanced boolean, assertFullyBalancedForReplicas boolean) : void from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Method public beforeAllTests() : void from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to public beforeAllTests() : void from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Inline Method | 1 | ||
| Inline Method private pickHighestLocalityServer(cluster Cluster, thisServer int, thisRegion int) : int inlined to package generate(cluster Cluster) : Cluster.Action in class org.apache.hadoop.hbase.master.balancer.StochasticLoadBalancer.LocalityBasedCandidateGenerator | From | To | |
| Pull Up Attribute | 4 | ||
| Pull Up Attribute package clusterStateMocks : int[][] from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected clusterStateMocks : int[][] from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Attribute package conf : Configuration from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected conf : Configuration from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Attribute package loadBalancer : StochasticLoadBalancer from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected loadBalancer : StochasticLoadBalancer from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Pull Up Attribute package largeCluster : int[] from class org.apache.hadoop.hbase.master.balancer.TestStochasticLoadBalancer to protected largeCluster : int[] from class org.apache.hadoop.hbase.master.balancer.BalancerTestBase | From | To | |
| Change Return Type | 2 | ||
| Change Return Type LoadingCache<HRegionInfo,List<ServerName>> to LoadingCache<HRegionInfo,HDFSBlocksDistribution> in method private createCache(mins int) : LoadingCache<HRegionInfo,HDFSBlocksDistribution> in class org.apache.hadoop.hbase.master.balancer.RegionLocationFinder | From | To | |
| Change Return Type List<ServerName> to HDFSBlocksDistribution in method protected internalGetTopBlockLocation(region HRegionInfo) : HDFSBlocksDistribution in class org.apache.hadoop.hbase.master.balancer.RegionLocationFinder | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type loader : CacheLoader<HRegionInfo,List<ServerName>> to loader : CacheLoader<HRegionInfo,HDFSBlocksDistribution> in class org.apache.hadoop.hbase.master.balancer.RegionLocationFinder | From | To | |
| Change Attribute Type cache : LoadingCache<HRegionInfo,List<ServerName>> to cache : LoadingCache<HRegionInfo,HDFSBlocksDistribution> in class org.apache.hadoop.hbase.master.balancer.RegionLocationFinder | From | To |