67f013430c9ba051385c45d72ee680c44eb88470
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 15
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 5 | ||
| Rename Method protected postShipEdits(entryBatch WALEntryBatch) : void renamed to protected noMoreData() : void in class org.apache.hadoop.hbase.replication.regionserver.RecoveredReplicationSourceShipper | From | To | |
| Rename Method private appendEntriesToLog(count int) : void renamed to private appendEntriesToLogAndSync(count int) : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Rename Method private appendToLog() : void renamed to private appendToLogAndSync() : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Rename Method private appendToLogPlus(count int) : void renamed to private appendToLogAndSync(count int) : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Rename Method public testReplicationSourceWALReaderThread() : void renamed to public testReplicationSourceWALReader() : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type wals : SortedSet<String> to wals : NavigableSet<String> in method private cleanOldLogs(wals NavigableSet<String>, key String, inclusive boolean, id String) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Rename Variable | 2 | ||
| Rename Variable batcher : ReplicationSourceWALReader to reader : ReplicationSourceWALReader in method private createReader(recovered boolean, conf Configuration) : ReplicationSourceWALReader in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Rename Variable batcher : ReplicationSourceWALReader to reader : ReplicationSourceWALReader in method public testReplicationSourceWALReader() : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Map<String,Map<String,SortedSet<String>>> to Map<String,Map<String,NavigableSet<String>>> in method package getWALs() : Map<String,Map<String,NavigableSet<String>>> in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Return Type Map<String,Map<String,SortedSet<String>>> to Map<String,Map<String,NavigableSet<String>>> in method package getWalsByIdRecoveredQueues() : Map<String,Map<String,NavigableSet<String>>> in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute lastReadPosition : long to currentPosition : long in method private updateLogPosition(batch WALEntryBatch) : boolean in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper | From | To | |
| Merge Parameter | 2 | ||
| Merge Parameter [log : Path, position : long, lastSeqIds : Map<String,Long>] to entryBatch : WALEntryBatch in method public logPositionAndCleanOldLogs(queueId String, queueRecovered boolean, entryBatch WALEntryBatch) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Merge Parameter [position : long, lastSeqIds : Map<String,Long>] to entryBatch : WALEntryBatch in method public logPositionAndCleanOldLogs(queueId String, queueRecovered boolean, entryBatch WALEntryBatch) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type | 12 | ||
| Change Variable Type entry : Map.Entry<String,SortedSet<String>> to entry : Map.Entry<String,NavigableSet<String>> in method public testLogRoll() : void in class org.apache.hadoop.hbase.replication.regionserver.TestReplicationSourceManager | From | To | |
| Change Variable Type wals : SortedSet<String> to wals : NavigableSet<String> in method package cleanOldLogs(log String, inclusive boolean, queueId String, queueRecovered boolean) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type walSet : SortedSet<String> to walSet : NavigableSet<String> in method private cleanOldLogs(wals NavigableSet<String>, key String, inclusive boolean, id String) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type entry : Map.Entry<String,Map<String,SortedSet<String>>> to entry : Map.Entry<String,Map<String,NavigableSet<String>>> in method public preLogRoll(newLog Path) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type walsEntry : Map.Entry<String,SortedSet<String>> to walsEntry : Map.Entry<String,NavigableSet<String>> in method public preLogRoll(newLog Path) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type wals : SortedSet<String> to wals : NavigableSet<String> in method public preLogRoll(newLog Path) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type walsByGroup : Map<String,SortedSet<String>> to walsByGroup : Map<String,NavigableSet<String>> in method package addSource(peerId String) : ReplicationSourceInterface in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type walsByGroup : Map<String,SortedSet<String>> to walsByGroup : Map<String,NavigableSet<String>> in method public run() : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.NodeFailoverWorker | From | To | |
| Change Variable Type walsByPrefix : Map<String,SortedSet<String>> to walsByPrefix : Map<String,NavigableSet<String>> in method public preLogRoll(newLog Path) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Variable Type wals : SortedSet<String> to wals : NavigableSet<String> in method public run() : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager.NodeFailoverWorker | From | To | |
| Change Variable Type logs : SortedSet<String> to logs : NavigableSet<String> in method package addSource(peerId String) : ReplicationSourceInterface in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Extract Method | 3 | ||
| Extract Method private appendToLog(count int) : long extracted from private appendToLogPlus(count int) : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Extract Method private updateLogPosition(batch WALEntryBatch) : boolean extracted from protected shipEdits(entryBatch WALEntryBatch) : void in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper | From | To | |
| Extract Method private createReader(recovered boolean, conf Configuration) : ReplicationSourceWALReader extracted from public testReplicationSourceWALReaderThread() : void in class org.apache.hadoop.hbase.replication.regionserver.TestWALEntryStream | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type walsByIdRecoveredQueues : ConcurrentMap<String,Map<String,SortedSet<String>>> to walsByIdRecoveredQueues : ConcurrentMap<String,Map<String,NavigableSet<String>>> in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Change Attribute Type walsById : ConcurrentMap<String,Map<String,SortedSet<String>>> to walsById : ConcurrentMap<String,Map<String,NavigableSet<String>>> in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceManager | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter entryBatch : WALEntryBatch to batch : WALEntryBatch in method private updateLogPosition(batch WALEntryBatch) : boolean in class org.apache.hadoop.hbase.replication.regionserver.ReplicationSourceShipper | From | To |