hbase 86e17858f73e742970e59936d34bfdb31fa286e1

86e17858f73e742970e59936d34bfdb31fa286e1

Files Diff

Added: 6
Removed: 4
Renamed: 0
Modified: 42

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	3
Rename Method public getGlobalMemStorePercent(c Configuration, logInvalid boolean) : float renamed to public getGlobalMemStoreHeapPercent(c Configuration, logInvalid boolean) : float in class org.apache.hadoop.hbase.io.util.MemorySizeUtil	From	To
Rename Method public getGlobalMemStoreLowerMark(conf Configuration, globalMemStorePercent float) : float renamed to public getGlobalMemStoreHeapLowerMark(conf Configuration, honorOldConfig boolean) : float in class org.apache.hadoop.hbase.io.util.MemorySizeUtil	From	To
Rename Method public checkForClusterFreeMemoryLimit(conf Configuration) : void renamed to public checkForClusterFreeHeapMemoryLimit(conf Configuration) : void in class org.apache.hadoop.hbase.io.util.MemorySizeUtil	From	To
Push Down Method	2
Push Down Method public init() : void from class org.apache.hadoop.hbase.regionserver.Chunk to public init() : void from class org.apache.hadoop.hbase.regionserver.OnheapChunk	From	To
Push Down Method public init() : void from class org.apache.hadoop.hbase.regionserver.Chunk to public init() : void from class org.apache.hadoop.hbase.regionserver.OffheapChunk	From	To
Move And Rename Method	1
Move And Rename Method private getMemStoreLAB(conf Configuration) : MemStoreLAB from class org.apache.hadoop.hbase.regionserver.SegmentFactory to public newInstance(conf Configuration) : MemStoreLAB from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Change Parameter Type	9
Change Parameter Type buf : byte[] to buf : ByteBuffer in method public write(buf ByteBuffer, offset int) : void in class org.apache.hadoop.hbase.CellUtil.TagRewriteCell	From	To
Change Parameter Type buf : byte[] to buf : ByteBuffer in method public write(buf ByteBuffer, offset int) : void in class org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder.OffheapDecodedCell	From	To
Change Parameter Type c : ByteBufferedCell to c : ByteBufferCell in method public KeyOnlyByteBufferCell(c ByteBufferCell, lenAsVal boolean) in class org.apache.hadoop.hbase.filter.KeyOnlyFilter.KeyOnlyByteBufferCell	From	To
Change Parameter Type mslab : HeapMemStoreLAB to mslab : MemStoreLABImpl in method private getChunkQueueTestThread(mslab MemStoreLABImpl, threadName String, cellToCopyInto Cell) : Thread in class org.apache.hadoop.hbase.regionserver.TestMemStoreLAB	From	To
Change Parameter Type buf : byte[] to buf : ByteBuffer in method public copyCellTo(cell Cell, buf ByteBuffer, offset int, len int) : Cell in class org.apache.hadoop.hbase.CellUtil	From	To
Change Parameter Type buf : byte[] to buf : ByteBuffer in method public write(buf ByteBuffer, offset int) : void in class org.apache.hadoop.hbase.ExtendedCell	From	To
Change Parameter Type chunk : PooledChunk to chunk : Chunk in method package putbackChunk(chunk Chunk) : void in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To
Change Parameter Type buf : byte[] to buf : ByteBuffer in method public write(buf ByteBuffer, offset int) : void in class org.apache.hadoop.hbase.io.encoding.BufferedDataBlockEncoder.OnheapDecodedCell	From	To
Change Parameter Type chunks : BlockingQueue<PooledChunk> to chunks : BlockingQueue<Chunk> in method package putbackChunks(chunks BlockingQueue<Chunk>) : void in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To
Move Method	1
Move Method public copyCellTo(cell Cell, buf byte[], offset int, len int) : KeyValue from class org.apache.hadoop.hbase.KeyValueUtil to public copyCellTo(cell Cell, buf ByteBuffer, offset int, len int) : Cell from class org.apache.hadoop.hbase.CellUtil	From	To
Rename Variable	1
Rename Variable globalMemStorePercent : float to upperMarkPercent : float in method public getGlobalMemStoreHeapLowerMark(conf Configuration, honorOldConfig boolean) : float in class org.apache.hadoop.hbase.io.util.MemorySizeUtil	From	To
Change Return Type	4
Change Return Type BlockingQueue<PooledChunk> to BlockingQueue<Chunk> in method package getPooledChunks() : BlockingQueue<Chunk> in class org.apache.hadoop.hbase.regionserver.MemStoreLABImpl	From	To
Change Return Type byte[] to ByteBuffer in method package getData() : ByteBuffer in class org.apache.hadoop.hbase.regionserver.Chunk	From	To
Change Return Type PooledChunk to Chunk in method package getChunk() : Chunk in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To
Change Return Type KeyValue to Cell in method public copyCellTo(cell Cell, buf ByteBuffer, offset int, len int) : Cell in class org.apache.hadoop.hbase.CellUtil	From	To
Move Attribute	5
Move Attribute package CHUNK_POOL_MAXSIZE_KEY : String from class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool to public CHUNK_POOL_MAXSIZE_KEY : String from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Move Attribute package CHUNK_POOL_INITIALSIZE_KEY : String from class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool to public CHUNK_POOL_INITIALSIZE_KEY : String from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Move Attribute package POOL_MAX_SIZE_DEFAULT : float from class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool to public POOL_MAX_SIZE_DEFAULT : float from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Move Attribute package POOL_INITIAL_SIZE_DEFAULT : float from class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool to public POOL_INITIAL_SIZE_DEFAULT : float from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Move Attribute package MSLAB_CLASS_NAME : String from class org.apache.hadoop.hbase.regionserver.SegmentFactory to public MSLAB_CLASS_NAME : String from class org.apache.hadoop.hbase.regionserver.MemStoreLAB	From	To
Rename Class	12
Rename Class org.apache.hadoop.hbase.io.util.HeapMemorySizeUtil renamed to org.apache.hadoop.hbase.io.util.MemorySizeUtil	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.LastOnRowByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.LastOnRowByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.LastOnRowColByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.LastOnRowColByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.filter.KeyOnlyFilter.KeyOnlyByteBufferedCell renamed to org.apache.hadoop.hbase.filter.KeyOnlyFilter.KeyOnlyByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.FirstOnRowByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.FirstOnRowByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.ByteBufferedCell renamed to org.apache.hadoop.hbase.ByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.FirstOnRowColByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.FirstOnRowColByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.regionserver.HeapMemStoreLAB renamed to org.apache.hadoop.hbase.regionserver.MemStoreLABImpl	From	To
Rename Class org.apache.hadoop.hbase.ByteBufferedKeyOnlyKeyValue renamed to org.apache.hadoop.hbase.ByteBufferKeyOnlyKeyValue	From	To
Rename Class org.apache.hadoop.hbase.TestCellUtil.ByteBufferedCellImpl renamed to org.apache.hadoop.hbase.TestCellUtil.ByteBufferCellImpl	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.FirstOnRowColTSByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.FirstOnRowColTSByteBufferCell	From	To
Rename Class org.apache.hadoop.hbase.CellUtil.EmptyByteBufferedCell renamed to org.apache.hadoop.hbase.CellUtil.EmptyByteBufferCell	From	To
Replace Variable With Attribute	1
Replace Variable With Attribute globalMemstoreLowerMark : float to globalMemStoreLimitLowMarkPercent : float in method public tune(context TunerContext) : TunerResult in class org.apache.hadoop.hbase.regionserver.DefaultHeapMemoryTuner	From	To
Change Variable Type	15
Change Variable Type kv2 : ByteBufferedCell to kv2 : ByteBufferCell in method public testCompressUncompressTagsWithOffheapKeyValue2() : void in class org.apache.hadoop.hbase.io.TestTagCompressionContext	From	To
Change Variable Type offheapKV : ByteBufferedCell to offheapKV : ByteBufferCell in method public testByteBufferBackedKeyValueWithTags() : void in class org.apache.hadoop.hbase.TestOffheapKeyValue	From	To
Change Variable Type cell : ByteBufferedCell to cell : ByteBufferCell in method public getCell() : Cell in class org.apache.hadoop.hbase.codec.prefixtree.PrefixTreeSeeker	From	To
Change Variable Type chunk : PooledChunk to chunk : Chunk in method package getChunk() : Chunk in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To
Change Variable Type bbCell : ByteBufferedCellImpl to bbCell : ByteBufferCellImpl in method public testKeyOnly() : void in class org.apache.hadoop.hbase.filter.TestKeyOnlyFilter	From	To
Change Variable Type kv1 : ByteBufferedCell to kv1 : ByteBufferCell in method public testCompressUncompressTagsWithOffheapKeyValue2() : void in class org.apache.hadoop.hbase.io.TestTagCompressionContext	From	To
Change Variable Type keyOnlyByteBufferedCell : KeyOnlyByteBufferedCell to keyOnlyByteBufferedCell : KeyOnlyByteBufferCell in method public testKeyOnly() : void in class org.apache.hadoop.hbase.filter.TestKeyOnlyFilter	From	To
Change Variable Type bbCell : ByteBufferedCell to bbCell : ByteBufferCell in method package addSize(context RpcCallContext, r Result, lastBlock Object) : Object in class org.apache.hadoop.hbase.regionserver.RSRpcServices	From	To
Change Variable Type offheapKeyOnlyKV : ByteBufferedCell to offheapKeyOnlyKV : ByteBufferCell in method public testGetKeyMethods() : void in class org.apache.hadoop.hbase.TestOffheapKeyValue	From	To
Change Variable Type nonRootIndexkeyOnlyKV : ByteBufferedKeyOnlyKeyValue to nonRootIndexkeyOnlyKV : ByteBufferKeyOnlyKeyValue in method package binarySearchNonRootIndex(key Cell, nonRootIndex ByteBuff, comparator CellComparator) : int in class org.apache.hadoop.hbase.io.hfile.HFileBlockIndex.BlockIndexReader	From	To
Change Variable Type mslab : HeapMemStoreLAB to mslab : MemStoreLABImpl in method public testLABChunkQueue() : void in class org.apache.hadoop.hbase.regionserver.TestMemStoreLAB	From	To
Change Variable Type offheapKV : ByteBufferedCell to offheapKV : ByteBufferCell in method public testByteBufferBackedKeyValue() : void in class org.apache.hadoop.hbase.TestOffheapKeyValue	From	To
Change Variable Type chunk : PooledChunk to chunk : Chunk in method package putbackChunks(chunks BlockingQueue<Chunk>) : void in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To
Change Variable Type kv2 : ByteBufferedCell to kv2 : ByteBufferCell in method public testCompressUncompressTagsWithOffheapKeyValue1() : void in class org.apache.hadoop.hbase.io.TestTagCompressionContext	From	To
Change Variable Type kv1 : ByteBufferedCell to kv1 : ByteBufferCell in method public testCompressUncompressTagsWithOffheapKeyValue1() : void in class org.apache.hadoop.hbase.io.TestTagCompressionContext	From	To
Change Attribute Type	6
Change Attribute Type bufBackedKeyOnlyKv : ByteBufferedKeyOnlyKeyValue to bufBackedKeyOnlyKv : ByteBufferKeyOnlyKeyValue in class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.HFileScannerImpl	From	To
Change Attribute Type currentKey : ByteBufferedKeyOnlyKeyValue to currentKey : ByteBufferKeyOnlyKeyValue in class org.apache.hadoop.hbase.io.encoding.RowIndexSeekerV1.SeekerState	From	To
Change Attribute Type data : byte[] to data : ByteBuffer in class org.apache.hadoop.hbase.regionserver.Chunk	From	To
Change Attribute Type pooledChunkQueue : BlockingQueue<PooledChunk> to pooledChunkQueue : BlockingQueue<Chunk> in class org.apache.hadoop.hbase.regionserver.MemStoreLABImpl	From	To
Change Attribute Type cell : ByteBufferedCell to cell : ByteBufferCell in class org.apache.hadoop.hbase.filter.KeyOnlyFilter.KeyOnlyByteBufferCell	From	To
Change Attribute Type reclaimedChunks : BlockingQueue<PooledChunk> to reclaimedChunks : BlockingQueue<Chunk> in class org.apache.hadoop.hbase.regionserver.MemStoreChunkPool	From	To

86e17858f73e742970e59936d34bfdb31fa286e1

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: