hbase a1f760ff763bacbfcfd6eb80d5076ec35e3b27e3

a1f760ff763bacbfcfd6eb80d5076ec35e3b27e3

Files Diff

Added: 0
Removed: 4
Renamed: 0
Modified: 7

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	27
Pull Up Method private buildUserInfo(ugi UserGroupInformation, authMethod AuthMethod) : RPCProtos.UserInformation from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private buildUserInfo(ugi UserGroupInformation, authMethod AuthMethod) : RPCProtos.UserInformation from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private startConnectionWithEncryption(ch Channel) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private startConnectionWithEncryption(ch Channel) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private getChannelHeaderBytes(authMethod AuthMethod) : byte[] from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private getChannelHeaderBytes(authMethod AuthMethod) : byte[] from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private writeRequest(call AsyncCall) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private writeRequest(call AsyncCall) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public isAlive() : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public isAlive() : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private createPreamble(byteBuf ByteBuf, authMethod AuthMethod) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private createPreamble(byteBuf ByteBuf, authMethod AuthMethod) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private writeChannelHeader(channel Channel) : ChannelFuture from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private writeChannelHeader(channel Channel) : ChannelFuture from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private startHBaseConnection(ch Channel) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private startHBaseConnection(ch Channel) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public getConnectionHashCode() : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public getConnectionHashCode() : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private shouldAuthenticateOverKrb() : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private shouldAuthenticateOverKrb() : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public hashCode() : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public hashCode() : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private handleSaslConnectionFailure(currRetries int, ex Throwable, user UserGroupInformation) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private handleSaslConnectionFailure(currRetries int, ex Throwable, user UserGroupInformation) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private retryOrClose(bootstrap Bootstrap, failureCount int, timeout long, e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private retryOrClose(bootstrap Bootstrap, failureCount int, timeout long, e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private getChannelHeader(authMethod AuthMethod) : RPCProtos.ConnectionHeader from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private getChannelHeader(authMethod AuthMethod) : RPCProtos.ConnectionHeader from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public AsyncRpcChannelImpl(bootstrap Bootstrap, client AsyncRpcClient, ticket User, serviceName String, address InetSocketAddress) from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public AsyncRpcChannel(bootstrap Bootstrap, client AsyncRpcClient, ticket User, serviceName String, address InetSocketAddress) from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public close(e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public close(e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method package removePendingCall(id int) : AsyncCall from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package removePendingCall(id int) : AsyncCall from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private connect(bootstrap Bootstrap) : ChannelFuture from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private connect(bootstrap Bootstrap) : ChannelFuture from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public equals(obj Object) : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public equals(obj Object) : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public getAddress() : InetSocketAddress from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public getAddress() : InetSocketAddress from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public callMethod(method Descriptors.MethodDescriptor, request Message, cellScanner CellScanner, responsePrototype R, messageConverter MessageConverter<R,O>, exceptionConverter IOExceptionConverter, rpcTimeout long, priority int) : Future<O> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public callMethod(method Descriptors.MethodDescriptor, request Message, cellScanner CellScanner, responsePrototype R, messageConverter MessageConverter<R,O>, exceptionConverter IOExceptionConverter, rpcTimeout long, priority int) : Promise<O> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private setupAuthorization() : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private setupAuthorization() : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private cleanupCalls() : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private cleanupCalls() : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public getEventExecutor() : EventLoop from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public getEventExecutor() : EventLoop from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private getSaslHandler(realTicket UserGroupInformation, bootstrap Bootstrap) : SaslClientHandler from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private getSaslHandler(realTicket UserGroupInformation, bootstrap Bootstrap) : SaslClientHandler from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method private close0(e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private close0(e Throwable) : void from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Method public toString() : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to public toString() : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Change Parameter Type	3
Change Parameter Type asyncRpcChannelImpl : AsyncRpcChannelImpl to asyncRpcChannelImpl : AsyncRpcChannel in method public CallWriteListener(asyncRpcChannelImpl AsyncRpcChannel, id int) in class org.apache.hadoop.hbase.ipc.AsyncRpcChannel.CallWriteListener	From	To
Change Parameter Type channel : AsyncRpcChannelImpl to channel : AsyncRpcChannel in method public AsyncServerResponseHandler(channel AsyncRpcChannel) in class org.apache.hadoop.hbase.ipc.AsyncServerResponseHandler	From	To
Change Parameter Type channel : AsyncRpcChannelImpl to channel : AsyncRpcChannel in method public AsyncCall(channel AsyncRpcChannel, connectId int, md Descriptors.MethodDescriptor, param Message, cellScanner CellScanner, responseDefaultType M, messageConverter MessageConverter<M,T>, exceptionConverter IOExceptionConverter, rpcTimeout long, priority int, metrics MetricsConnection) in class org.apache.hadoop.hbase.ipc.AsyncCall	From	To
Change Return Type	1
Change Return Type Future<O> to Promise<O> in method public callMethod(method Descriptors.MethodDescriptor, request Message, cellScanner CellScanner, responsePrototype R, messageConverter MessageConverter<R,O>, exceptionConverter IOExceptionConverter, rpcTimeout long, priority int) : Promise<O> in class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute	20
Pull Up Attribute private reloginMaxBackoff : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private reloginMaxBackoff : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package client : AsyncRpcClient from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package client : AsyncRpcClient from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private connected : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private connected : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private pendingCalls : Map<Integer,AsyncCall> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private pendingCalls : Map<Integer,AsyncCall> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private serverPrincipal : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private serverPrincipal : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute protected TOKEN_HANDDLERS : Map<Kind,TokenSelector<? extends TokenIdentifier>> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to protected TOKEN_HANDDLERS : Map<Kind,TokenSelector<? extends TokenIdentifier>> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private cleanupTimer : Timeout from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private cleanupTimer : Timeout from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private failureCounter : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private failureCounter : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package serviceName : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package serviceName : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private channel : Channel from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private channel : Channel from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private token : Token<? extends TokenIdentifier> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private token : Token<? extends TokenIdentifier> from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private LOG : Log from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private LOG : Log from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private MAX_SASL_RETRIES : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private MAX_SASL_RETRIES : int from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package useSasl : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package useSasl : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package name : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package name : String from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private closed : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private closed : boolean from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package authMethod : AuthMethod from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package authMethod : AuthMethod from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package ticket : User from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package ticket : User from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute package address : InetSocketAddress from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to package address : InetSocketAddress from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Pull Up Attribute private timeoutTask : TimerTask from class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl to private timeoutTask : TimerTask from class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To
Move Class	1
Move Class org.apache.hadoop.hbase.ipc.AsyncRpcChannelImpl.CallWriteListener moved to org.apache.hadoop.hbase.ipc.AsyncRpcChannel.CallWriteListener	From	To
Change Variable Type	2
Change Variable Type promise : Future<Message> to promise : Promise<Message> in method protected call(pcrc PayloadCarryingRpcController, md Descriptors.MethodDescriptor, param Message, returnType Message, ticket User, addr InetSocketAddress, callStats MetricsConnection.CallStats) : Pair<Message,CellScanner> in class org.apache.hadoop.hbase.ipc.AsyncRpcClient	From	To
Change Variable Type listener : ResponseFutureListener<Message> to listener : FutureListener<Message> in method private callMethod(md Descriptors.MethodDescriptor, pcrc PayloadCarryingRpcController, param Message, returnType Message, ticket User, addr InetSocketAddress, done RpcCallback<Message>) : void in class org.apache.hadoop.hbase.ipc.AsyncRpcClient	From	To
Change Attribute Type	3
Change Attribute Type rpcChannel : AsyncRpcChannelImpl to rpcChannel : AsyncRpcChannel in class org.apache.hadoop.hbase.ipc.AsyncRpcChannel.CallWriteListener	From	To
Change Attribute Type channel : AsyncRpcChannelImpl to channel : AsyncRpcChannel in class org.apache.hadoop.hbase.ipc.AsyncServerResponseHandler	From	To
Change Attribute Type channel : AsyncRpcChannelImpl to channel : AsyncRpcChannel in class org.apache.hadoop.hbase.ipc.AsyncCall	From	To
Rename Parameter	1
Rename Parameter cause : Throwable to e : Throwable in method public close(e Throwable) : void in class org.apache.hadoop.hbase.ipc.AsyncRpcChannel	From	To

a1f760ff763bacbfcfd6eb80d5076ec35e3b27e3

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: