hbase b35cf8f93a54b73389431ea7ba2d08f4aae7e104

b35cf8f93a54b73389431ea7ba2d08f4aae7e104

Files Diff

Added: 22
Removed: 11
Renamed: 0
Modified: 20

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Inline Method	4
Move And Inline Method public getStoreFileScanner(cacheBlocks boolean, pread boolean) : StoreFileScanner moved from class org.apache.hadoop.hbase.regionserver.StoreFileReader to class org.apache.hadoop.hbase.regionserver.TestStoreFile & inlined to public testMultipleTimestamps() : void	From	To
Move And Inline Method public getStoreFileScanner(cacheBlocks boolean, pread boolean) : StoreFileScanner moved from class org.apache.hadoop.hbase.regionserver.StoreFileReader to class org.apache.hadoop.hbase.regionserver.TestStoreFile & inlined to public testReseek() : void	From	To
Move And Inline Method public getStoreFileScanner(cacheBlocks boolean, pread boolean) : StoreFileScanner moved from class org.apache.hadoop.hbase.regionserver.StoreFileReader to class org.apache.hadoop.hbase.regionserver.TestStoreFile & inlined to public testBloomTypes() : void	From	To
Move And Inline Method public getStoreFileScanner(cacheBlocks boolean, pread boolean) : StoreFileScanner moved from class org.apache.hadoop.hbase.regionserver.StoreFileReader to class org.apache.hadoop.hbase.regionserver.TestStoreFile & inlined to private bloomWriteRead(writer StoreFileWriter, fs FileSystem) : void	From	To
Move Method	3
Move Method public testMatch_PartialRangeDropDeletes() : void from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to public testMatch_PartialRangeDropDeletes() : void from class org.apache.hadoop.hbase.regionserver.querymatcher.TestCompactionScanQueryMatcher	From	To
Move Method package isCellTTLExpired(cell Cell, oldestTimestamp long, now long) : boolean from class org.apache.hadoop.hbase.regionserver.HStore to private isCellTTLExpired(cell Cell, oldestTimestamp long, now long) : boolean from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Move Method private testDropDeletes(from byte[], to byte[], rows byte[][], expected MatchCode...) : void from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to private testDropDeletes(from byte[], to byte[], rows byte[][], expected MatchCode...) : void from class org.apache.hadoop.hbase.regionserver.querymatcher.TestCompactionScanQueryMatcher	From	To
Pull Up Attribute	22
Pull Up Attribute private get : Get from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected get : Get from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private row1 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected row1 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private data : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected data : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute package ttl : long from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected ttl : long from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private col5 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected col5 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private col2 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected col2 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private fam1 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected fam1 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private row2 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected row2 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private now : long from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected now : long from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private rowComparator : CellComparator from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected rowComparator : CellComparator from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private columns : ColumnTracker from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected columns : ColumnTracker from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private startKey : Cell from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected startKey : Cell from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private oldestUnexpiredTS : long from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected oldestUnexpiredTS : long from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private col3 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected col3 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private conf : Configuration from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected conf : Configuration from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private fam2 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected fam2 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private row3 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected row3 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private scan : Scan from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected scan : Scan from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private col4 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected col4 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute package rowComparator : CellComparator from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected rowComparator : CellComparator from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Attribute private stickyNextRow : boolean from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to protected stickyNextRow : boolean from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Attribute private col1 : byte[] from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to protected col1 : byte[] from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Move Attribute	2
Move Attribute private seePastDeleteMarkers : boolean from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to private seePastDeleteMarkers : boolean from class org.apache.hadoop.hbase.regionserver.querymatcher.NormalUserScanQueryMatcher	From	To
Move Attribute private get : boolean from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to private get : boolean from class org.apache.hadoop.hbase.regionserver.querymatcher.NormalUserScanQueryMatcher	From	To
Extract Class	2
Extract Class org.apache.hadoop.hbase.regionserver.querymatcher.NormalUserScanQueryMatcher from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher	From	To
Extract Class org.apache.hadoop.hbase.regionserver.querymatcher.TestCompactionScanQueryMatcher from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher	From	To
Move And Rename Class	2
Move And Rename Class org.apache.hadoop.hbase.regionserver.TestQueryMatcher moved and renamed to org.apache.hadoop.hbase.regionserver.querymatcher.TestUserScanQueryMatcher	From	To
Move And Rename Class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher moved and renamed to org.apache.hadoop.hbase.regionserver.querymatcher.LegacyScanQueryMatcher	From	To
Move Class	8
Move Class org.apache.hadoop.hbase.regionserver.ScanWildcardColumnTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.ScanWildcardColumnTracker	From	To
Move Class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher.MatchCode moved to org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher.MatchCode	From	To
Move Class org.apache.hadoop.hbase.regionserver.ExplicitColumnTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.ExplicitColumnTracker	From	To
Move Class org.apache.hadoop.hbase.regionserver.ColumnCount moved to org.apache.hadoop.hbase.regionserver.querymatcher.ColumnCount	From	To
Move Class org.apache.hadoop.hbase.regionserver.DeleteTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.DeleteTracker	From	To
Move Class org.apache.hadoop.hbase.regionserver.ScanDeleteTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.ScanDeleteTracker	From	To
Move Class org.apache.hadoop.hbase.regionserver.TestExplicitColumnTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.TestExplicitColumnTracker	From	To
Move Class org.apache.hadoop.hbase.regionserver.ColumnTracker moved to org.apache.hadoop.hbase.regionserver.querymatcher.ColumnTracker	From	To
Extract Method	8
Extract Method private getStoreFileScanner(reader StoreFileReader, cacheBlocks boolean, pread boolean) : StoreFileScanner extracted from private bloomWriteRead(writer StoreFileWriter, fs FileSystem) : void in class org.apache.hadoop.hbase.regionserver.TestStoreFile	From	To
Extract Method private getStoreFileScanner(reader StoreFileReader, cacheBlocks boolean, pread boolean) : StoreFileScanner extracted from public testCacheOnWriteEvictOnClose() : void in class org.apache.hadoop.hbase.regionserver.TestStoreFile	From	To
Extract Method private getStoreFileScanner(reader StoreFileReader, cacheBlocks boolean, pread boolean) : StoreFileScanner extracted from public testReseek() : void in class org.apache.hadoop.hbase.regionserver.TestStoreFile	From	To
Extract Method private getStoreFileScanner(reader StoreFileReader, cacheBlocks boolean, pread boolean) : StoreFileScanner extracted from public testMultipleTimestamps() : void in class org.apache.hadoop.hbase.regionserver.TestStoreFile	From	To
Extract Method private getStoreFileScanner(reader StoreFileReader, cacheBlocks boolean, pread boolean) : StoreFileScanner extracted from public testBloomTypes() : void in class org.apache.hadoop.hbase.regionserver.TestStoreFile	From	To
Replace Attribute	1
Replace Attribute private ttl : long from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher with protected oldestUnexpiredTS : long from class org.apache.hadoop.hbase.regionserver.StoreScanner	From	To
Rename Method	3
Rename Method public testGet_SingleVersion() : void renamed to public testGetSingleVersion() : void in class org.apache.hadoop.hbase.regionserver.querymatcher.TestExplicitColumnTracker	From	To
Rename Method public testMatch_ExplicitColumns() : void renamed to public testMatchExplicitColumns() : void in class org.apache.hadoop.hbase.regionserver.querymatcher.TestUserScanQueryMatcher	From	To
Rename Method public testGet_MultiVersion() : void renamed to public testGetMultiVersion() : void in class org.apache.hadoop.hbase.regionserver.querymatcher.TestExplicitColumnTracker	From	To
Pull Up Method	7
Pull Up Method public setToNewRow(curCell Cell) : void from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to public setToNewRow(currentRow Cell) : void from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Method public setUp() : void from class org.apache.hadoop.hbase.regionserver.TestQueryMatcher to public setUp() : void from class org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher	From	To
Pull Up Method public compareKeyForNextRow(nextIndexed Cell, kv Cell) : int from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to public compareKeyForNextRow(nextIndexed Cell, currentCell Cell) : int from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Method public compareKeyForNextColumn(nextIndexed Cell, currentCell Cell) : int from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to public compareKeyForNextColumn(nextIndexed Cell, currentCell Cell) : int from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Method package checkColumn(columnTracker ColumnTracker, bytes byte[], offset int, length int, ttl long, type byte, ignoreCount boolean) : MatchCode from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to package checkColumn(columnTracker ColumnTracker, bytes byte[], offset int, length int, ttl long, type byte, ignoreCount boolean) : MatchCode from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Method public getKeyForNextColumn(kv Cell) : Cell from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to public getKeyForNextColumn(cell Cell) : Cell from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Pull Up Method public getStartKey() : Cell from class org.apache.hadoop.hbase.regionserver.ScanQueryMatcher to public getStartKey() : Cell from class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Inline Method	1
Inline Method private _testMatch_ExplicitColumns(scan Scan, expected List<MatchCode>) : void inlined to public testMatchExplicitColumns() : void in class org.apache.hadoop.hbase.regionserver.querymatcher.TestUserScanQueryMatcher	From	To
Extract Superclass	2
Extract Superclass org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher from classes [org.apache.hadoop.hbase.regionserver.querymatcher.LegacyScanQueryMatcher]	From	To
Extract Superclass org.apache.hadoop.hbase.regionserver.querymatcher.AbstractTestScanQueryMatcher from classes [org.apache.hadoop.hbase.regionserver.querymatcher.TestUserScanQueryMatcher]	From	To
Rename Parameter	5
Rename Parameter curCell : Cell to currentRow : Cell in method public setToNewRow(currentRow Cell) : void in class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Rename Parameter kv : Cell to cell : Cell in method public moreRowsMayExistAfter(cell Cell) : boolean in class org.apache.hadoop.hbase.regionserver.querymatcher.LegacyScanQueryMatcher	From	To
Rename Parameter kv : Cell to cell : Cell in method public getKeyForNextColumn(cell Cell) : Cell in class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Rename Parameter kv : Cell to currentCell : Cell in method public compareKeyForNextRow(nextIndexed Cell, currentCell Cell) : int in class org.apache.hadoop.hbase.regionserver.querymatcher.ScanQueryMatcher	From	To
Rename Parameter kv : Cell to cell : Cell in method public getNextKeyHint(cell Cell) : Cell in class org.apache.hadoop.hbase.regionserver.querymatcher.LegacyScanQueryMatcher	From	To

b35cf8f93a54b73389431ea7ba2d08f4aae7e104

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: