hbase b3b1ce99c63d79401ddda9c114850dea61af0afb

b3b1ce99c63d79401ddda9c114850dea61af0afb

Files Diff

Added: 10
Removed: 5
Renamed: 0
Modified: 34

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Pull Up Method	7
Pull Up Method public stop(why String) : void from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to public stop(why String) : void from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method public finish(compactionName String) : void from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to public finish(opName String) : void from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method private throughputDesc(deltaSize long, elapsedTime long) : String from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected throughputDesc(deltaSize long, elapsedTime long) : String from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method public start(compactionName String) : void from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to public start(opName String) : void from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method public control(compactionName String, size long) : long from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to public control(opName String, size long) : long from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method public isStopped() : boolean from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to public isStopped() : boolean from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Method private throughputDesc(speed double) : String from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected throughputDesc(speed double) : String from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Move And Rename Method	1
Move And Rename Method private generateCompactionName() : String from class org.apache.hadoop.hbase.regionserver.compactions.Compactor to public getNameForThrottling(store Store, opName String) : String from class org.apache.hadoop.hbase.regionserver.throttle.ThroughputControlUtil	From	To
Change Parameter Type	34
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(request CompactionRequest, targetBoundaries List<byte[]>, majorRangeFromRow byte[], majorRangeToRow byte[], throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController, user User) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method private compactInternal(mw StripeMultiFileWriter, request CompactionRequest, majorRangeFromRow byte[], majorRangeToRow byte[], throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public abstract compact(throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.CompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, throughputController ThroughputController) : List<StoreFile> in class org.apache.hadoop.hbase.regionserver.HStore	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController, user User) : boolean in class org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook.CompactionCompletionNotifyingRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.TestCompaction.BlockingStoreMockMaker.BlockingCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public execute(compactor StripeCompactor, throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy.BoundaryStripeCompactionRequest	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.StripeStoreEngine.StripeCompaction	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController) : boolean in class org.apache.hadoop.hbase.TestIOFencing.CompactionBlockerRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.StripeStoreEngine.StripeCompaction	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController, user User) : boolean in class org.apache.hadoop.hbase.TestIOFencing.CompactionBlockerRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.DefaultStoreEngine.DefaultCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.TestCompaction.StoreMockMaker.TestCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(request CompactionRequest, throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.DefaultCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, throughputController ThroughputController, user User) : List<StoreFile> in class org.apache.hadoop.hbase.regionserver.HStore	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public execute(compactor StripeCompactor, throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy.SplitStripeCompactionRequest	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.TestCompaction.BlockingStoreMockMaker.BlockingCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, throughputController ThroughputController) : List<StoreFile> in class org.apache.hadoop.hbase.regionserver.Store	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.DefaultStoreEngine.DefaultCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method protected performCompaction(fd FileDetails, scanner InternalScanner, writer CellSink, smallestReadPoint long, cleanSeqId boolean, throughputController ThroughputController, major boolean) : boolean in class org.apache.hadoop.hbase.regionserver.compactions.Compactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method protected performCompaction(fd FileDetails, scanner InternalScanner, writer CellSink, smallestReadPoint long, cleanSeqId boolean, throughputController ThroughputController, major boolean) : boolean in class org.apache.hadoop.hbase.mob.DefaultMobStoreCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(request CompactionRequest, targetCount int, targetSize long, left byte[], right byte[], majorRangeFromRow byte[], majorRangeToRow byte[], throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController) : boolean in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.TestCompaction.StoreMockMaker.TestCompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, store Store, throughputController ThroughputController) : boolean in class org.apache.hadoop.hbase.coprocessor.TestRegionObserverScannerOpenHook.CompactionCompletionNotifyingRegion	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public abstract execute(compactor StripeCompactor, throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy.StripeCompactionRequest	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(request CompactionRequest, targetCount int, targetSize long, left byte[], right byte[], majorRangeFromRow byte[], majorRangeToRow byte[], throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public abstract compact(throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.CompactionContext	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, throughputController ThroughputController, user User) : List<StoreFile> in class org.apache.hadoop.hbase.regionserver.Store	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(compaction CompactionContext, throughputController ThroughputController) : List<StoreFile> in class org.apache.hadoop.hbase.regionserver.HMobStore	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public execute(compactor StripeCompactor, throughputController ThroughputController) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactionPolicy.StripeCompactionRequest	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method public compact(request CompactionRequest, targetBoundaries List<byte[]>, majorRangeFromRow byte[], majorRangeToRow byte[], throughputController ThroughputController, user User) : List<Path> in class org.apache.hadoop.hbase.regionserver.compactions.StripeCompactor	From	To
Change Parameter Type throughputController : CompactionThroughputController to throughputController : ThroughputController in method package compactStore(family byte[], throughputController ThroughputController) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Pull Up Attribute	6
Pull Up Attribute private stopped : boolean from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to private stopped : boolean from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Attribute private controlPerSize : long from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected controlPerSize : long from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Attribute package maxThroughput : double from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to private maxThroughput : double from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Attribute private offPeakHours : OffPeakHours from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected offPeakHours : OffPeakHours from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Attribute private tuningPeriod : int from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected tuningPeriod : int from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Pull Up Attribute private maxThroughputLowerBound : long from class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController to protected maxThroughputLowerBound : long from class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Change Return Type	3
Change Return Type Class<? extends CompactionThroughputController> to Class<? extends ThroughputController> in method public getThroughputControllerClass(conf Configuration) : Class<? extends ThroughputController> in class org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Change Return Type CompactionThroughputController to ThroughputController in method public create(server RegionServerServices, conf Configuration) : ThroughputController in class org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Change Return Type CompactionThroughputController to ThroughputController in method public getCompactionThroughputController() : ThroughputController in class org.apache.hadoop.hbase.regionserver.CompactSplitThread	From	To
Move Attribute	1
Move Attribute private NAME_COUNTER : AtomicInteger from class org.apache.hadoop.hbase.regionserver.compactions.Compactor to private NAME_COUNTER : AtomicInteger from class org.apache.hadoop.hbase.regionserver.throttle.ThroughputControlUtil	From	To
Move And Rename Class	3
Move And Rename Class org.apache.hadoop.hbase.regionserver.compactions.CompactionThroughputController moved and renamed to org.apache.hadoop.hbase.regionserver.throttle.ThroughputController	From	To
Move And Rename Class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController.ActiveCompaction moved and renamed to org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController.ActiveOperation	From	To
Move And Rename Class org.apache.hadoop.hbase.regionserver.compactions.NoLimitCompactionThroughputController moved and renamed to org.apache.hadoop.hbase.regionserver.throttle.NoLimitThroughputController	From	To
Move Class	3
Move Class org.apache.hadoop.hbase.regionserver.compactions.PressureAwareCompactionThroughputController moved to org.apache.hadoop.hbase.regionserver.throttle.PressureAwareCompactionThroughputController	From	To
Move Class org.apache.hadoop.hbase.regionserver.compactions.TestCompactionWithThroughputController moved to org.apache.hadoop.hbase.regionserver.throttle.TestCompactionWithThroughputController	From	To
Move Class org.apache.hadoop.hbase.regionserver.compactions.CompactionThroughputControllerFactory moved to org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Extract Superclass	1
Extract Superclass org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController from classes [org.apache.hadoop.hbase.regionserver.throttle.PressureAwareCompactionThroughputController]	From	To
Change Variable Type	4
Change Variable Type controller : CompactionThroughputController to controller : ThroughputController in method public create(server RegionServerServices, conf Configuration) : ThroughputController in class org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Change Variable Type clazz : Class<? extends CompactionThroughputController> to clazz : Class<? extends ThroughputController> in method public create(server RegionServerServices, conf Configuration) : ThroughputController in class org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Change Variable Type controller : CompactionThroughputController to controller : ThroughputController in method public compact(majorCompaction boolean) : void in class org.apache.hadoop.hbase.regionserver.HRegion	From	To
Change Variable Type old : CompactionThroughputController to old : ThroughputController in method public onConfigurationChange(newConf Configuration) : void in class org.apache.hadoop.hbase.regionserver.CompactSplitThread	From	To
Change Attribute Type	3
Change Attribute Type compactionThroughputController : CompactionThroughputController to compactionThroughputController : ThroughputController in class org.apache.hadoop.hbase.regionserver.CompactSplitThread	From	To
Change Attribute Type DEFAULT_THROUGHPUT_CONTROLLER_CLASS : Class<? extends CompactionThroughputController> to DEFAULT_THROUGHPUT_CONTROLLER_CLASS : Class<? extends ThroughputController> in class org.apache.hadoop.hbase.regionserver.throttle.CompactionThroughputControllerFactory	From	To
Change Attribute Type INSTANCE : NoLimitCompactionThroughputController to INSTANCE : NoLimitThroughputController in class org.apache.hadoop.hbase.regionserver.throttle.NoLimitThroughputController	From	To
Rename Parameter	6
Rename Parameter compactionName : String to name : String in method public control(name String, size long) : long in class org.apache.hadoop.hbase.regionserver.throttle.ThroughputController	From	To
Rename Parameter compactionName : String to name : String in method public finish(name String) : void in class org.apache.hadoop.hbase.regionserver.throttle.ThroughputController	From	To
Rename Parameter compactionName : String to opName : String in method public finish(opName String) : void in class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Rename Parameter compactionName : String to opName : String in method public control(opName String, size long) : long in class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To
Rename Parameter compactionName : String to name : String in method public start(name String) : void in class org.apache.hadoop.hbase.regionserver.throttle.ThroughputController	From	To
Rename Parameter compactionName : String to opName : String in method public start(opName String) : void in class org.apache.hadoop.hbase.regionserver.throttle.PressureAwareThroughputController	From	To

b3b1ce99c63d79401ddda9c114850dea61af0afb

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: