ccb22bd80dfae64ff27f660254afb224dce268f0
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 37
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method protected updateCurrBlock(newBlock HFileBlock) : void renamed to protected updateCurrentBlock(newBlock HFileBlock) : void in class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.HFileScannerImpl | From | To | |
| Inline Method | 1 | ||
| Inline Method public read(dstBuffer ByteBuffer, offset long) : int inlined to public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine | From | To | |
| Change Return Type | 5 | ||
| Change Return Type ByteBuff to Pair<ByteBuff,MemoryType> in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.ByteBufferIOEngine | From | To | |
| Change Return Type ByteBuff to HFileBlock in method public getMetaBlock(metaBlockName String, cacheBlock boolean) : HFileBlock in class org.apache.hadoop.hbase.io.hfile.HFile.Reader | From | To | |
| Change Return Type ByteBuff to HFileBlock in method public getMetaBlock(metaBlockName String, cacheBlock boolean) : HFileBlock in class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl | From | To | |
| Change Return Type ByteBuff to Pair<ByteBuff,MemoryType> in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.IOEngine | From | To | |
| Change Return Type ByteBuff to Pair<ByteBuff,MemoryType> in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type read : ByteBuff to read : Pair<ByteBuff,MemoryType> in method public testByteBufferIOEngineWithMBB() : void in class org.apache.hadoop.hbase.io.hfile.bucket.TestByteBufferIOEngine | From | To | |
| Extract Variable | 1 | ||
| Extract Variable compressedBlock : HFileBlock in method private getCachedBlock(cacheKey BlockCacheKey, cacheBlock boolean, useLock boolean, isCompaction boolean, updateCacheMetrics boolean, expectedBlockType BlockType, expectedDataBlockEncoding DataBlockEncoding) : HFileBlock from class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl | From | To | |
| Extract Method | 6 | ||
| Extract Method protected processFirstDataBlock() : boolean extracted from public seekTo() : boolean in class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.HFileScannerImpl | From | To | |
| Extract Method protected readAndUpdateNewBlock(firstDataBlockOffset long) : void extracted from public seekTo() : boolean in class org.apache.hadoop.hbase.io.hfile.HFileReaderImpl.HFileScannerImpl | From | To | |
| Extract Method private checkRamCache(cacheKey BlockCacheKey) : RAMQueueEntry extracted from public evictBlock(cacheKey BlockCacheKey) : boolean in class org.apache.hadoop.hbase.io.hfile.bucket.BucketCache | From | To | |
| Extract Method package metricsUpdateForGet(results List<Cell>) : void extracted from public get(get Get, withCoprocessor boolean) : List<Cell> in class org.apache.hadoop.hbase.regionserver.HRegion | From | To | |
| Extract Method public evictBlock(cacheKey BlockCacheKey, deletedBlock boolean) : boolean extracted from public evictBlock(cacheKey BlockCacheKey) : boolean in class org.apache.hadoop.hbase.io.hfile.bucket.BucketCache | From | To | |
| Extract Method package prepareGet(get Get) : void extracted from public get(get Get) : Result in class org.apache.hadoop.hbase.regionserver.HRegion | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter len : int to length : int in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.IOEngine | From | To | |
| Rename Parameter len : int to length : int in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.FileIOEngine | From | To | |
| Rename Parameter len : int to length : int in method public read(offset long, length int) : Pair<ByteBuff,MemoryType> in class org.apache.hadoop.hbase.io.hfile.bucket.ByteBufferIOEngine | From | To |