hbase ce64e7eb6e9a6c3954b8ab6b5441ca6e4f952b26

ce64e7eb6e9a6c3954b8ab6b5441ca6e4f952b26

Files Diff

Added: 1
Removed: 1
Renamed: 0
Modified: 15

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move And Rename Method	2
Move And Rename Method public retrieveGroupList(watcher ZooKeeperWatcher, groupBasePath String) : List<RSGroupInfo> from class org.apache.hadoop.hbase.rsgroup.RSGroupSerDe to package retrieveGroupListFromZookeeper() : List<RSGroupInfo> from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Move And Rename Method public retrieveGroupList(groupTable Table) : List<RSGroupInfo> from class org.apache.hadoop.hbase.rsgroup.RSGroupSerDe to package retrieveGroupListFromGroupTable() : List<RSGroupInfo> from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Move And Inline Method	2
Move And Inline Method public prepareRSGroupForTable(desc HTableDescriptor) : void moved from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer to class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint & inlined to public preCreateTable(ctx ObserverContext<MasterCoprocessorEnvironment>, desc HTableDescriptor, regions HRegionInfo[]) : void	From	To
Move And Inline Method public cleanupRSGroupForTable(tableName TableName) : void moved from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer to class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint & inlined to public postDeleteTable(ctx ObserverContext<MasterCoprocessorEnvironment>, tableName TableName) : void	From	To
Move Method	12
Move Method public moveServers(controller RpcController, request MoveServersRequest, done RpcCallback<MoveServersResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public moveServers(controller RpcController, request MoveServersRequest, done RpcCallback<MoveServersResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public listRSGroupInfos(controller RpcController, request ListRSGroupInfosRequest, done RpcCallback<ListRSGroupInfosResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public listRSGroupInfos(controller RpcController, request ListRSGroupInfosRequest, done RpcCallback<ListRSGroupInfosResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public removeRSGroup(controller RpcController, request RemoveRSGroupRequest, done RpcCallback<RemoveRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public removeRSGroup(controller RpcController, request RemoveRSGroupRequest, done RpcCallback<RemoveRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public serverRemoved(serverName ServerName) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl to public serverRemoved(serverName ServerName) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.ServerEventsListenerThread	From	To
Move Method public balanceRSGroup(controller RpcController, request BalanceRSGroupRequest, done RpcCallback<BalanceRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public balanceRSGroup(controller RpcController, request BalanceRSGroupRequest, done RpcCallback<BalanceRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public getRSGroupInfoOfServer(controller RpcController, request GetRSGroupInfoOfServerRequest, done RpcCallback<GetRSGroupInfoOfServerResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public getRSGroupInfoOfServer(controller RpcController, request GetRSGroupInfoOfServerRequest, done RpcCallback<GetRSGroupInfoOfServerResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public serverAdded(serverName ServerName) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl to public serverAdded(serverName ServerName) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.ServerEventsListenerThread	From	To
Move Method public getRSGroupInfoOfTable(controller RpcController, request GetRSGroupInfoOfTableRequest, done RpcCallback<GetRSGroupInfoOfTableResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public getRSGroupInfoOfTable(controller RpcController, request GetRSGroupInfoOfTableRequest, done RpcCallback<GetRSGroupInfoOfTableResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public moveTables(controller RpcController, request MoveTablesRequest, done RpcCallback<MoveTablesResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public moveTables(controller RpcController, request MoveTablesRequest, done RpcCallback<MoveTablesResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method public addRSGroup(controller RpcController, request AddRSGroupRequest, done RpcCallback<AddRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public addRSGroup(controller RpcController, request AddRSGroupRequest, done RpcCallback<AddRSGroupResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Method private createRSGroupTable(masterServices MasterServices) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl to private createRSGroupTable() : void from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.RSGroupStartupWorker	From	To
Move Method public getRSGroupInfo(controller RpcController, request GetRSGroupInfoRequest, done RpcCallback<GetRSGroupInfoResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint to public getRSGroupInfo(controller RpcController, request GetRSGroupInfoRequest, done RpcCallback<GetRSGroupInfoResponse>) : void from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl	From	To
Move Attribute	3
Move Attribute private LOG : Log from class org.apache.hadoop.hbase.rsgroup.RSGroupSerDe to private LOG : Log from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint	From	To
Move Attribute private LOG : Log from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.DefaultServerUpdater to private LOG : Log from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint	From	To
Move Attribute private masterServices : MasterServices from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.RSGroupStartupWorker to private masterServices : MasterServices from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Extract Class	2
Extract Class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl.ServerEventsListenerThread from class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Extract Class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint.RSGroupAdminServiceImpl from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminEndpoint	From	To
Move And Rename Attribute	1
Move And Rename Attribute public HBASE_GROUP_LOADBALANCER_CLASS : String renamed to public HBASE_RSGROUP_LOADBALANCER_CLASS : String and moved from class org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer to class org.apache.hadoop.hbase.rsgroup.RSGroupableBalancer	From	To
Change Variable Type	7
Change Variable Type request : RSGroupAdminProtos.AddRSGroupRequest to request : AddRSGroupRequest in method public addRSGroup(groupName String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type request : RSGroupAdminProtos.BalanceRSGroupRequest to request : BalanceRSGroupRequest in method public balanceRSGroup(groupName String) : boolean in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type request : RSGroupAdminProtos.GetRSGroupInfoOfTableRequest to request : GetRSGroupInfoOfTableRequest in method public getRSGroupInfoOfTable(tableName TableName) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type request : RSGroupAdminProtos.RemoveRSGroupRequest to request : RemoveRSGroupRequest in method public removeRSGroup(name String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type resp : RSGroupAdminProtos.GetRSGroupInfoResponse to resp : GetRSGroupInfoResponse in method public getRSGroupInfo(groupName String) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type request : RSGroupAdminProtos.GetRSGroupInfoOfServerRequest to request : GetRSGroupInfoOfServerRequest in method public getRSGroupOfServer(hostPort Address) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Variable Type request : RSGroupAdminProtos.MoveServersRequest to request : MoveServersRequest in method public moveServers(servers Set<Address>, targetGroup String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Inline Variable	1
Inline Variable RSGroupInfo : RSGroupInfo in method private rsGroupGetRegionsInTransition(groupName String) : Map<String,RegionState> from class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Rename Method	2
Rename Method public RSGroupBasedLoadBalancer(rsGroupInfoManager RSGroupInfoManager) renamed to public setRsGroupInfoManager(rsGroupInfoManager RSGroupInfoManager) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupBasedLoadBalancer	From	To
Rename Method private installNewMaps(newRSGroupMap Map<String,RSGroupInfo>, newTableMap Map<TableName,String>) : void renamed to private resetRSGroupAndTableMaps(newRSGroupMap Map<String,RSGroupInfo>, newTableMap Map<TableName,String>) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Variable	4
Rename Variable rsgi : RSGroupInfo to rsGroupInfo : RSGroupInfo in method private getRSGroupInfo(groupName String) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Variable rsgi : RSGroupInfo to rsGroupInfo : RSGroupInfo in method public removeRSGroup(name String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Rename Variable RSGroupInfo : RSGroupInfo to rsGroupInfo : RSGroupInfo in method private getRSGroupAssignmentsByTable(groupName String) : Map<TableName,Map<ServerName,List<HRegionInfo>>> in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Rename Variable rsgi : RSGroupInfo to rsGroupInfo : RSGroupInfo in method private getAndCheckRSGroupInfo(name String) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Inline Method	1
Inline Method private getRSGroupInfoManager() : RSGroupInfoManager inlined to public removeRSGroup(name String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Replace Variable With Attribute	3
Replace Variable With Attribute manager : RSGroupInfoManager to rsGroupInfoManager : RSGroupInfoManager in method public moveTables(tables Set<TableName>, targetGroup String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Replace Variable With Attribute manager : RSGroupInfoManager to rsGroupInfoManager : RSGroupInfoManager in method public moveServers(servers Set<Address>, targetGroupName String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Replace Variable With Attribute manager : RSGroupInfoManager to rsGroupInfoManager : RSGroupInfoManager in method public removeRSGroup(name String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Rename Attribute	3
Rename Attribute master : MasterServices to masterServices : MasterServices in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Attribute defaultServerUpdater : DefaultServerUpdater to serverEventsListenerThread : ServerEventsListenerThread in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Attribute NAMESPACEDESC_PROP_GROUP : String to NAMESPACE_DESC_PROP_GROUP : String in class org.apache.hadoop.hbase.rsgroup.RSGroupInfo	From	To
Change Attribute Type	3
Change Attribute Type defaultServerUpdater : DefaultServerUpdater to serverEventsListenerThread : ServerEventsListenerThread in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Change Attribute Type stub : RSGroupAdminProtos.RSGroupAdminService.BlockingInterface to stub : RSGroupAdminService.BlockingInterface in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Change Attribute Type LOG : org.apache.commons.logging.Log to LOG : Log in class org.apache.hadoop.hbase.rsgroup.TestRSGroupsOfflineMode	From	To
Rename Parameter	10
Rename Parameter hostPort : Address to serverHostPort : Address in method public getRSGroupOfServer(serverHostPort Address) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManager	From	To
Rename Parameter name : String to groupName : String in method public removeRSGroup(groupName String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdmin	From	To
Rename Parameter name : String to groupName : String in method public balanceRSGroup(groupName String) : boolean in class org.apache.hadoop.hbase.rsgroup.VerifyingRSGroupAdminClient	From	To
Rename Parameter name : String to groupName : String in method public balanceRSGroup(groupName String) : boolean in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminClient	From	To
Rename Parameter name : String to groupName : String in method public balanceRSGroup(groupName String) : boolean in class org.apache.hadoop.hbase.rsgroup.RSGroupAdmin	From	To
Rename Parameter hostPort : Address to serverHostPort : Address in method public getRSGroupOfServer(serverHostPort Address) : RSGroupInfo in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Parameter master : MasterServices to masterServices : MasterServices in method private RSGroupInfoManagerImpl(masterServices MasterServices) in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Parameter newGroupMap : Map<String,RSGroupInfo> to groupMap : Map<String,RSGroupInfo> in method private flushConfigTable(groupMap Map<String,RSGroupInfo>) : Map<TableName,String> in class org.apache.hadoop.hbase.rsgroup.RSGroupInfoManagerImpl	From	To
Rename Parameter RSGroupInfoManager : RSGroupInfoManager to rsGroupInfoManager : RSGroupInfoManager in method public RSGroupAdminServer(master MasterServices, rsGroupInfoManager RSGroupInfoManager) in class org.apache.hadoop.hbase.rsgroup.RSGroupAdminServer	From	To
Rename Parameter name : String to groupName : String in method public addRSGroup(groupName String) : void in class org.apache.hadoop.hbase.rsgroup.RSGroupAdmin	From	To

ce64e7eb6e9a6c3954b8ab6b5441ca6e4f952b26

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: